Problem/Motivation

I've inherited a legacy site with 500k+ nodes which needs the 7.x-2.x => 7.x-3.x update for Weight module.

This leads to an update process which can take many hours, and can timeout a lot of automated processes.

Proposed resolution

Optimize the update script.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 3214098_4_weight_update_7301_speed.patch3.04 KBMile23
#2 3214098_weight_update_7301_speed.patch770 bytesMile23
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mile23 created an issue. See original summary.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
FileSize
3214098_weight_update_7301_speed.patch770 bytes

Here's a patch which uses node_load_multiple() within weight_update_7301() to reduce the number of DB requests.

I am not entirely sure if the update process absolutely needs to load the nodes one at a time, but this does improve the speed.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Issue summary: View changes
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
FileSize
3214098_4_weight_update_7301_speed.patch3.04 KB

Better improvement.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Active » Needs review
VladimirAus’s picture

VladimirAus
Primary language English
Location Brisbane 🇦🇺
CreditAttribution: VladimirAus at Tomato Elephant Studio commented
Version: 7.x-3.1 » 7.x-3.x-dev
Status: Needs review » Reviewed & tested by the community

Thank you for patches. 😄

  • VladimirAus committed 4bcdf303 on 7.x-3.x authored by Mile23 
    Issue #3214098 by Mile23, VladimirAus: Speed improvement for...
VladimirAus’s picture

VladimirAus
Primary language English
Location Brisbane 🇦🇺
CreditAttribution: VladimirAus at Tomato Elephant Studio commented
Status: Reviewed & tested by the community » Fixed

Fixed! 🍻

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.