Support For Drupal 5

Planning to begin testing 5 on a development server and will begin porting the module shortly thereafter. Obviously also depends on the availability of documentation related to porting modules, which I have not yet looked into.

docs to update from modules from 4.7.4 - D5 http://drupal.org/node/64279

posted for convience, not to hurry.

Thanks. BTW, anyone who has the time and wishes to convert it themselves should feel free to do so and post a patch here against HEAD. Credit will be given in the README and module source if anyone does that.

Patch against HEAD. I've been using this for the past couple of days, trying to beat up on it as much as possible. A couple of quick notes:

- I didn't address the issue of everything disappearing when "Form type" is set to "form", since there's a separate issue for this: http://drupal.org/node/82732. Because of this, the form setting is not nearly as well tested as the link setting.

- I also didn't address the issue of dynamic content in emails showing up all ugly, for the same reason (issue link: http://drupal.org/node/68804). For the record, I think the patch for that is pretty good, but that's not for here.

- The .info file will be added as a separate issue; I am fairly new at patches, and I caught a discussion on another issue thread that .info files should be separate issues so as not to make patches messy, so I'll go with that.

Made an oopsie on t() tags wrt user links on outgoing email. Fixed.

Can someone apply this patch and tar it up on cvs?

Any Progress on this????

Well, I've applied for CVS access in hopes that I can help maintain the module, create a proper 5.x branch, and the like. I guess I'll also go ahead and assign the issue to myself; I don't really know what that does, but I did write the patch, after all :-). But the code is in "code needs review" status -- I see some comments asking for a rollup of this, but not one comment yet talking about whether or not/how well it worked for you. Please review the patch, as noted, maybe poke around a little and try to break it, and post what you find. Thanks!

I only just recently (last few days) got a 5.0 site set up that I can test this on. I'm applying the patch to my local copy right now and will test it over the next couple of days. I've decided to decline your request for now but may reconsider it at a later date. We use this module for all of our client sites and I'm a little nervous about giving anyone too much control over it just yet. Understand I do greatly appreciate the offer, though.

Patch appears to be working OK (but I had to create a .info file) and has been committed to HEAD. I'll branch it after I've tested it a little more thoroughly.

I'd read on another contrib module's discussion that .info files should really be separate issues from 5.x upgrades; I don't know if that's really true, but since I heard this shortly before writing this patch, I went ahead and created the .info as a separate issue here:
http://drupal.org/node/105837
It's very bare-bones, but I figured something was better than nothing.

I think my biggest concern with the patch is that the form submission type is of necessity untested, because of the issue at http://drupal.org/node/82732 off the pre-5.x HEAD. It's a quickie patch, so now that I know we're up and running on the 5.x conversion I'll go ahead and apply it by hand over here, and start testing out the form submit type. I'll probably get around to this Friday evening. (Or if you think that other patch is pretty much good to go, and you have a little time, maybe you could commit that to HEAD as well?)

Also need to add settings to menu

Seems to be working for me from HEAD.

subscribing.

Don't forget to upgrade to D5 FAPI or you'll end up with a nasty bit of recurssion (that killed our servers until we figured it out)!

This patch does not apply against HEAD. Did you neglect to update your local copy from HEAD before producing the patch?

My apologies, please ignore. I started this site upgrade almost a month ago and was working off of the 4.7 with the applied patches listed above. It appears that between my start of the upgrade and pushing the site live, that you already fixed this. Thanks!

Marking this closed since it was already done elsewhere.