m0Ray [m0ray]

Hello, and thank you for applying for a CVS account.

As per requirements, the motivation needs to include more than two sentences (possibly a paragraph) that describe the module features (the description should make clear what the module features are without to look at the code), and a comparison with the existing solutions.

I will report here a little checklist:

• The code needs to follow the coding standards; check in particular the format used for the control structures, and the name given to PHP variables, Drupal persistent variables, functions defined from the module.
• Files available from third-party sites should not be included within the module/theme. This is particularly true for files that are not licensed under GPL License v2, but it is also true for files that are licensed under the same license used by Drupal.
• The license file should not be included as well; the packaging script already include that file. In any cases, the code for modules/themes committed in drupal.org repository needs to be released under the same license used by Drupal; any compatible license is not allowed.
• Check the code passes the Coder validation.

Hi, I submitted Request for CVS for my Bitcoin related project (a CCK field for Bitcoin Addresses)
at http://drupal.org/node/1013890 in late December.

I've followed the instructions as best as I know including the three points mentioned above, could you please review my module submission?

Thanks,
--Darrell

--Bitcoin addresses range in size from 25 - 44 characters, I'd suggest updating the setting for this in the install file.

--I'd suggest that you take the bitcoin classes you've included and make them in to a library that gets installed (and maintained) separately.

--I don't recommend that you name this module bitcoin. I'd suggest something more descriptive like bitcoin_users or bitcoin_tools.

--It'd be nice to have a Readme.txt file with details about how to configure and use this module.

--I'd suggest that we make the base bitcoin module for something that provides just the functionality of the standard Bitcoin client, but allows it to interact with multiple instances of bitcoind, but not

Lets discuss this on the Bitcoin Drupal group, I'm opening a discussion there now.

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

Use the UberCart based payment method instead, it is far superior for letting your customers pay with Bitcoin in the equivalent amount that they checked out with in whatever currency your shop is setup with

As per previous comment, I am setting this issue as Won't fix.
Since new users can now create full projects, applications have a different purpose and they are handled on a different issue queue. See Apply for permission to opt into security advisory coverage for more information.