Computed Field Tools

Just some minor stuff...

- The title of the batch_set() operation title should be translated, see for example http://api.drupal.org/api/drupal/modules--user--user.module/function/use.... Something like t('Recomputing @field_name', array('@field_name' => $field['field_name'])).

- You don't need to call batch_process() in a form submit function, again, see the linked example above.

- "WHERE node.type IN (" . $types_string . ") "
You need to use the db_placeholders function: http://api.drupal.org/api/drupal/includes--database.inc/function/db_plac...

- db_query("UPDATE {" . $db_table . "} SET `%s_value` = '%s' WHERE `vid` = '%d'", $field['field_name'], $node_field[0]['value'], $result->vid);
I would recommend against using %s placeholder for anything else than actual values. This just works because Drupal 6 uses basic string search/replace to do the parameter replacement (in a secure way, of course). It will not work anymore in Drupal 7, where the replacement is actually done by the database. Also, you shouldn't use '%d' but just %d, the first won't work for PostgreSQL.

Hi frakke,

This looks good, but it seems like it may be more appropriate as a patch to Computed Field rather than a separate module. There are many open issues around similar functionality, e.g.:

http://drupal.org/node/195013
http://drupal.org/node/146608
http://drupal.org/node/924374

The code seems simple enough that it could be applied as a patch on one of these issues. Please set this back to "needs review" when responding to this.

Please approve this a a project - highly needed! And could you please change the .info file's package to "CCK" (currently it reads "Peytz & Co.")?

+1

subscribe

Sorry to push the priority to critical, but according to the Application Review Timelines given in Review process for Full Project Applications: What to Expect the priority should be raised to critical when an application is waiting for more than 4 weeks to be reviewed.

The feature this module is offering has been requested so many times in the mother's module issue queue - it's totally needed. I am using it since weeks without any problems. It does its job in a smart and speedy way. Adding this functionality into the mother module seems to delay progress significantly for now. This may be a goal for the wider future. Thanks for your considerations whoever will review this module.

This is definitely a very useful thing and I think it should make it one way or the other. That being said, I'm +1 for this being part of the main computed field module, as it doesn't make sense as a stand alone one. Also, the maintainers seem to be open for this.

(following my last phrase ...) So they could give you (frakke) commit rights I guess ...

I agree in having this module included as a sub module of Computed Field itself would be the best for now, if the Computed Field maintainers agree to do that soon. Has there yet been made a request in Computed Field's issue queue?

roball, I've just made the request in #1262820: Merge Computed Field Tools into Computed Field, Frakke feel free to close that issue if you don't like the idea.

Thank you Frakke, and I'm glad you found it alright, let's see what the maintainers say over there :)

I'm going to temporarily mark this as postponed on #1262820: Merge Computed Field Tools into Computed Field.

However, the maintainers seem to be absent of late, there is a chance you might need to follow the Abandoned Modules process.

Hi is anything happening with this module? I really need my computed field to update without re-saving the node. Are there any other options how to do this?

I need also a 7.x version of this module, i'm trying to update it but i'm not very friendly with drupal code and api...

That's great news! Where do I find the sandbox page?

I think I found the sandbox page http://drupal.org/sandbox/frakke/1079758. But I'm sorry I don't understand where the module is and how to download it?

Relevant note from the patch thread:

Ok, so there is no response from the maintainers. I am personally not interested in taking over the entire computed fields project, so I guess in an attempt to move things forward, I will try to re-open my project application in the hopes, that it will get approved at some point.

I'm not sure the best way to resolve this. In the one hand, it would be best as a patch. On the other hand, it can't be a patch with no maintainer prepared to patch it.

While we work that out, frakke, you'll need to address the open bug before this can move forward either way.

Great, thanks.

I'm marking this application as reviewed and tested. The code looks good and frakke has demonstrated a willingness to collaborate where possible. It's unfortunate that's not possible here, but getting an active maintainer for Computed Field is a bit beyond the scope of this review.

I'll leave this for someone else to actually approve, so others have an opportunity to disagree.

Hi Frakke, Thanks for this great module. Please can you explain how I can download it from the sandbox page. What do I do with git clone http://git.drupal.org/sandbox/frakke/1079758.git computed_field_tools ? Thank you.

frakke, you are now a vetted user, and can promote this to full project. If you feel the need to become a committer on computed fields (an occasional committer is better than a completely absentee maintainer), please ping me about that thread and access will be granted swiftly.

Clearly, people need to be able to easily download your module, and i'm sorry you had to serve as yet another reason there are strong moves now to make this application process faster and more automatic. Congratulations, and i look forward to your continued contributions.

Thanks to everyone and especially sreynan for review work and keeping this moving forward.

If commit access (and project page edit permission) to computed field module is possible, maybe it's best to include computed field tools as a sub-module of computed field, stating that you (Frakke) are maintaining just that. Otherwise, we are unnecessarily bloating the (bloated :) ) contrib repo.

my 2c

rafa.

I'm using drupal7 so what should I do?

Is there a way to update the node using drupal7? The computed_field_tools only has a drupal6 version.
Should I open a new issue?

LTech, you should open an issue on the project asking for a D7 version. This thread should not be used for general support.