currently, once you enable cvs.module, it thinks *every* project on your site has a corresponding directory in CVS, and requires a value. this is wrong. it's made worse by all the fancy validation i added to the cvs directory field, so now it's a pain to edit project nodes like documentation, webmasters, infrastructure, etc, that don't have code associated with them (e.g. http://drupal.org/node/107980).
what we should do is make <none> a valid choice for the CVS repository drop down (subject to all the restrictions on who can modify that -- see http://drupal.org/node/59504 and http://drupal.org/node/108109 for details), and save that in the DB as repo_id (rid) = 0. only if the rid != 0 should the cvs directory field be required (or even visible).
i'll be working on a patch soon, stay tuned.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | cvs_allow_no_repo.patch_2.txt | 6.05 KB | dww |
| #2 | cvs_allow_no_repo.patch_1.txt | 7.59 KB | dww |
| #1 | cvs_allow_no_repo.patch.txt | 7.56 KB | dww |
Comments
Comment #1
dwwi touched some of the same code with this as the patch in http://drupal.org/node/108109. so, this particular patch actually includes both, though i'd like to commit them separately. anyway, it's a start, so people can see what's up. i might just install this on s.d.o directly and see how it works there.
Comment #2
dww- convert some tabs to spaces from the previous patch
- fixed a bug: if the saved repo is 0 (none), we were erroneously using the site-wide setting instead of the saved value as the default in the drop-down.
isset()to the rescue.Comment #3
dwwhere's a patch for just this issue (relative to the cvslog directory, not site root, sorry) ;)
Comment #4
AjK commentedApplies clean. "Does what it says on the tin". Nice and simple patch :)
Comment #5
dwwcommitted to HEAD and DRUPAL-4-7--2 (i don't want to change this stuff in the stable 4.7.x-1.* series).
thanks (again) for the review AjK!
Comment #6
(not verified) commented