wysiwyg button

This integration could be very useful so my +1

Code in sandbox http://drupal.org/sandbox/zolexiy/1166988

subscribe
+1

The community can check it on 1168028-wysiwyg (D6) branch. This implementing Wysiwyg module's API, so it supports most of the editors.

Thanks for your feedback!

Cheers,
Kalman

Hello Kalman :)

It's looking much better now! I've had a play with it and here are my thoughts:

• Rename wysiwyg_plugins to simply wysiwyg. If there's a need to differentiate between plugins and other wysiwyg module components, please nest it as wysiwyg/plugins/ instead.
• The closing brace for Drupal.wysiwyg.plugins['quote'] on line 19 of quote.js is missing a semicolon.
• Trailing whitespace issues on empty lines.
• ckeditor: Works! The quote GIF icon appears to be a little too large.
• tinymce: Works! The quote GIF icon fits well. But it could use a transparent BG to suit the editor.
• fckeditor: is now ckeditor
• Whizzywig: No quote option seen.
• nicedit: No quote option seen.
• Credits: Please link to your Drupal page rather than your personal pages or e-mail addresses. I'll add your name & a link to your profile to the project page and README files shortly.

Any idea why some editors are not aware of the plugin? Also, do you foresee making use of this plug-in for the multiquote feature as well?

Regards,
-K

Hi,

I created the modifications:

• Rename wysiwyg_plugins to simply wysiwyg. If there's a need to differentiate between plugins and other wysiwyg module components, please nest it as wysiwyg/plugins/ instead. DONE
• The closing brace for Drupal.wysiwyg.plugins['quote'] on line 19 of quote.js is missing a semicolon. DONE
• Trailing whitespace issues on empty lines. DONE
• ckeditor: Works! The quote GIF icon appears to be a little too large. DONE
• tinymce: Works! The quote GIF icon fits well. But it could use a transparent BG to suit the editor. DONE
• fckeditor: is now ckeditor
• Credits: Please link to your Drupal page rather than your personal pages or e-mail addresses. I'll add your name & a link to your profile to the project page and README files shortly. DONE

I will update the wysiwyg feature after the multiquote feature will complete.

Thanks for your feedback!

Cheers,
Kalman

Hi,

The icon looks great! Just a couple of minor points:

• There is no need for the /* file */ in quote.js.
• Please add a blurb for the /* file */ in quote.inc.
• In quote.inc, "Implementation of hook_wysiwyg_plugin()." should be "Implements hook ..."
• I gather that there's no way around the superfluous "quote" directory within the "wysiwyg" directory. Is it a fixed structure?

Besides the above, things look good. Please proceed with the commit once you're ready. FYI, I actually tested this against the 7.x branch and all was peachy except for a minor conflict in .install.

Thanks for sticking with this :)
-K

Hi,

I did all the points above.

Now we've got only one plugin called "quote" but we'll have more in future, when the multiquote functionality will finish.

Waiting for your feedback!

Cheers,
Kálmán

Ah, I see. If you're done with the changes, please feel free to merge and commit accordingly to both 6.2 and 7. I will release alphas for both branches once you are done.

Thanks!
-K

I've committed this to D7.

-K

I've merged to 6.x-2.x so you can create the new alpha releases.

Cheers
Kálmán

-alpha1 released. Thanks.

-K

Could I delete 1168028-wysiwyg branch?

Kálmán

Please go ahead.
-K