New options with nodes and expand

Thank you! Works great.

Please post a patch! http://drupal.org/node/707484 http://drupal.org/project/taxonomy_menu/git-instructions

thanks for the patch. i have been looking for a way to add menu items for nodes under each term https://drupal.org/node/1293538

since that was one of your added features i tried to apply the patch to Taxonomy Menu 7.x-1.2 but received the following:

$ patch -b < display_only_linked_nodes-1192084-2.patch 
patching file taxonomy_menu.database.inc
patching file taxonomy_menu.module
Hunk #3 FAILED at 457.
Hunk #4 succeeded at 545 (offset 1 line).
Hunk #6 FAILED at 626.
Hunk #7 succeeded at 862 (offset 1 line).
Hunk #8 succeeded at 884 with fuzz 2.
Hunk #9 succeeded at 903 with fuzz 1 (offset 1 line).
2 out of 9 hunks FAILED -- saving rejects to file taxonomy_menu.module.rej

the rejection file is attached.

however, both the expand option and children nodes are now working. it is safe to continue to use this patch if it did not totally apply cleanly?

regardless, thanks for the help. i will be happy to test additional patches for you.

peace

i just realized that my problems in https://drupal.org/comment/reply/1192084/5049792#comment-5049792 were due to me not patching against the 7.x-1.x-dev version, instead of the 7.x-1.2 version which i had done. the patch does apply cleanly and seems to be working here with Drupal 7.8.

thanks again.

the patch from #6 worked for me against current 1.x-dev : adding nodes as childs is fine, expand / not expand is fine, but hiding terms without nodes not yet.

thanks and keep up the good work - Showing number of nodes in brackets would be next on my wishlist :)

subscribe

subscribe

subscribe

Edit: sorry, forgot about the new Follow button

nvm

Lahode: Looks like the bots didn't grab your latest patches for testing. Maybe a file naming issue?

Or is it that no-one remembered to set the status to "needs review"?

Tagging 'Needs tests'

I am anxious to test this, but havent done it - was busy with the other issues..

Tests as in http://drupal.org/simpletest-tutorial-drupal7

Hi, Will this be committed please? They are much wanted features and patches #24 is working.
Greetings, Martijn

Hi, Patch #24 is working, that the options arise. I hoped I got the possibility to have a menu on which:
1) I am able to set say the first two levels expanded:

- Europe    <=== Homepage situation at start, 2 levels expanded.
---France
---Austria
---Germany
etc..

1) When I click on a above level, the underneath levels are getting expanded:

-Europe
---France  <===== Click on France
-----Paris
-----Lyon
etc..

But I can't get this to work.. Could you help with this please?
Thanks a lot in advance!
Greetings, Martijn

Hi Martijn,
auto-expanding seems to be a problem with core.
Check for "Auto expand" in the core issue queue,
There are also some module regarding "Menu trail"

Hi,
@Johnv Did you solve this? I tried Taxonomy_menu_trail but it wouldn;t work...
Thanks a lot in advance!
Greetings, Martijn

No, I just set my menu to 'Expanded'...

This still needs tests but I committed it to 7.x-1.x. Check out the attached patch for what I committed, since it's a little different. http://drupalcode.org/project/taxonomy_menu.git/commit/09e7d88

The hash in the filename breaks the URL. Try this:

http://drupal.org/files/sync-menu-1192084-%2334.patch

#1350338: The Taxonomy Menu rebuild process encountered an error.

7.x-1.x is broken at the moment.

This patch should fix it.

I have applied the patch at #37 manually and it works fine.
I'm not sure whether to drop this in here, or whether it's even doable, but is it possible to have the menu item display order mirror the taxonomy listing order?
Edit: Further to this, they do obey the weights as given in the taxonomy list when the taxonomy menu is rebuilt, but not when reordering them in the taxonomy terms list.

patch in #37 works

Hi, Patch in #37 works, please commit, because the latest .dev version is not working now.
Thanks in advance,
greetings, Martijn

#37 works for me. Thanks.

Hi!

I patched 7.x-1.x version with #37, but it looks like the "Add all linked nodes to each terms" feature isn't there anymore. Did I do it right? How can I have that feature? I find it very important.

Thanks!

It looks like the show_nodes option (the "Add all linked nodes to each terms" feature) was removed between the patches in #6 and #12, and never made it into the commit (in #34.)

@lahode: was this intentional?

@lahode: Thanks for your response. I figured as much, considering that [the now abandond] Taxonomy Treemenu module requires >200kb of code to accomplish this. You put views underneath taxonomy menu terms? Contrib modules or custom implementation?

Yes, dstol committed the patch to 7.x-1.x-dev. See #34. (#37 is a fix post-commit.)

Patch works, though the perfectionist in me wants to replace

  $temp = $temp->fetchAllAssoc('term_count');
  $temp = reset($temp);

with

  $temp = $temp->fetchAssoc();

The return $temp->term_count on the next line functions exactly the same, and it's a line less of code ...

im getting this:

screenshot: http://prntscr.com/4btca

An AJAX HTTP error occurred. HTTP Result Code: 200 Debugging information follows. Path: /batch?id=22&op=do StatusText: OK ResponseText: Fatal error:

Using D7.9 and comes up after i link a taxo to a menu.

I just committed #37, with the tweak from #47 and I removed a notice that it would be throwing otherwise.

http://drupalcode.org/project/taxonomy_menu.git/commitdiff/632adcd

Please test.

Back to fixed.

I noted this comment at discussion(http://drupal.org/documentation/modules/taxonomy_menu#comment-5563868) as well (sorry)...

I used the "7.x-1.2" version on Drupal 7.12 but it doesn't give me the options for expand menu etc. So I installed the "7.x-1.x-dev" version that gives me the options but still doesn't help me at all. There's no difference whether I use "Auto expand menu items" or not...and the "Add item for vocabulary" is great out, I can't select this option... and I can't add anything in "Custom name for vocabulary item"...

Maybe I'm missing something because I can't get it displaying right...I want a menu item called "Category" which is my taxonomy term and then when I press that it drops down a menu with all the terms listed under Category...

Please help..and thank you :)

hmartens: see #45 here. The ability to list nodes in the menu was initially part of the patch here, but was removed and has not been added to this module.

aah shucks! So I'm a bit screwed then :) Thanks for replying though

I don't know why this was closed considering only half of what was positioned has been added.

If we are going to commit new features in 7.x-2.x, we are going to need tests shipped with them. Maybe it would help to create 3 separate issues, one for each feature.

So, to get this into 7.x-2.x, we'd need to add the functionality from #34 and #37, and add tests for them, right?

Always with tests yes. Maybe we should be careful not to add any feature, just the ones that are common use cases, else I worry we will have a very bloated admin interface. But that's up to discussion.

Ah. but 1) from the original post has already been implemented in 7.x.-2x. I didn't realize that. That's actually the one that I need, so I'll leave 2) and 3) to someone else.

Even 2) is implemented as well in 2.x as far as I understand what it means. I'll change the title to focus on 3) only, although I'm not really keen in adding this feature.

This thread is getting very long and complex. It contains 3 issues, of which 2 are fixed.
let's close this thread, and open a follow-up here: #2004266: Display all nodes related to each term in the menu