[D6] Acobot

It seems you need to work more on "Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards". Please run your code through the Coder and other online tools before submitting. Please consider the following report.

The below test was taken using online, automated PAReview tool.

sites/all/modules/pareview_temp/test_candidate/acobot.module:
+100: [critical] Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code.

Status Messages:
Coder found 1 projects, 1 files, 1 critical warnings, 0 warnings were flagged to be ignored

FILE: ...areview/sites/all/modules/pareview_temp/test_candidate/acobot.admin.inc

--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AND 1 WARNING(S) AFFECTING 8 LINE(S)
--------------------------------------------------------------------------------

FILE: ...-pareview/sites/all/modules/pareview_temp/test_candidate/acobot.install

--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------

FILE: ...7-pareview/sites/all/modules/pareview_temp/test_candidate/acobot.module

--------------------------------------------------------------------------------
FOUND 13 ERROR(S) AND 4 WARNING(S) AFFECTING 13 LINE(S)
--------------------------------------------------------------------------------

See the attached file for full report.

Even if your code is still in sandbox you should have a detailed description about the functionality on the project page (see documentation at http://drupal.org/node/632262).

Your commits are not very informative. Please be more detailed on your changes (see http://drupal.org/node/52287).

Also your readme is not very informative. How to use? How to install ? requirements? What about configuration?

/**
 * Implements hook_help().
 */
function acobot_help($path, $arg) {
  switch ($path) {
    case 'admin/settings/acobot':
      return;
  }
}

If you don't want to give help - don't implement it ;-)

further reviews will follow.

regards

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

Hi,

Manual Review :

1. Please avoid using HTML inside t() in acobot.module line 74.
2. Also use l() to create link markup, avoid creating by your own.
3. Please enclose l() with t(), so that it becomes translatable in acobot.admin.inc line 24 and in all other places.
4. acobot_requirements() is an installation hook and must be declared in an install file
5. It seems your code contains some validation errors.So please PAREVIEW your code.

Thanks,

I'm afraid I've to remove that tag because two of your reviews are mostly lining out what an automated review will tell you.
Please do manual reviews as described (#1410826: [META] Review bonus)

Here is a short manual review:

Missing RREADME.txt in master branch

You should have a README.txt pointing at the right versions in the master branch

Validate does not validate token

You only use the validation check to see if the input is not empty, what happens if the enter a token that is not valid?

Try not to use $_GET['q']

And if you need to, I think that you should use some filtering so bad stuff does not happen, this I think is a security issue.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Review info added.