Hi,
When a user is creating a link with the linkit plugin, and is clicking the Cancel button from the Linkit popup, the page is scrolling up to top.
A "return: false" was missing to prevent this in the js/linkit.dialog.js file. Patch provided.
Thanks

CommentFileSizeAuthor
linkit-cancel-dialog.patch425 bytesjulien.reulos

Comments

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented
Assigned: julien.reulos » Unassigned
Status: Needs review » Needs work

I have confirmed the issue, but unfortunatly the patch doesnt seems to fix this issue.

--- /opt/lampp/htdocs/drupal/sites/all/modules/linkit/js/old/linkit.dialog.js	2012-01-05 14:16:18.225676887 +0100
+++ /opt/lampp/htdocs/drupal/sites/all/modules/linkit/js/linkit.dialog.js	2012-01-05 14:12:07.235676841 +0100

Also, remember to always make patches from the module root.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented
Status: Needs work » Fixed

My bad, that solution works.

I have commited a patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.