Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
25 Jan 2012 at 09:27 UTC
Updated:
4 Mar 2012 at 04:36 UTC
This is a very simple module, it hides the label of form elements and display the label inside of particular element.
currently working for textbox, password field, and for textarea.
You can set your default option to using 'admin/config/user-interface/jform_label'.
Name of Module:
jform_label
Project Link:
http://drupal.org/sandbox/anilbhatt/1416224
Drupal core version:
7.x
GIT info:
git clone --branch 7.x-1.x anilbhatt@git.drupal.org:sandbox/anilbhatt/1416224.git jform_label
Reviews of other projects:
http://drupal.org/node/1221410#comment-5556594
http://drupal.org/node/1221410#comment-5556594
http://drupal.org/node/1424990#comment-5556576
Comments
Comment #1
thursday_bw commentedThere is nothing in this project other than an info file.. which is in both your master branch (the master branch should have only a README.txt file).. and your 7.x-1.x
Essentially this project currently does nothing.
I see no reason at this very early stage for this project to be seeking application.
Documentation on the review process is here: http://drupal.org/node/1011698
"After contributing a useful and working module or theme as a sandbox project, you may go through a one-time approval process"
Comment #2
anilbhatt commentedComment #3
thursday_bw commentedLooking at http://drupal.org/project/In-Field-Labels and http://drupal.org/project/compact_forms
Thinking in terms of collaboration over competition, how would you say this module differs significantly in ways that couldn't be integrated into one of those existing modules?
Comment #4
thursday_bw commentedYou still have jform_label.info in your master branch. Your master branch should contain a README.txt file only.
You are also missing README.txt from your 7.x-1.x branch.
You also have some formatting/coding standards issues. A report can be seen here: http://ventral.org/pareview/httpgitdrupalorgsandboxanilbhatt1416224git
Your hook_form_FORM_ID_validate() hook '_jform_label_settings_form_validate' begins with an underscore character, is this function disabled?. if so, consider adding a comment to say so or move that code into a feature branch.
Comment #5
anilbhatt commentedchanges done.
Comment #6
thursday_bw commentedGreat, fast turn around on those changes.
In jform_label_menu() the description for your menu item as
set on line 24 is 'Build google image sitemap.'
You still need to answer the query about the comparison of this module and http://drupal.org/project/In-Field-Labels and http://drupal.org/project/compact_forms in comment #3.
Some extra commenting and documentation would not go astray, give some information on what
you are thinking. Especially document the settings, providing some more insight into their
behavior and effects.
Comment #7
thursday_bw commentedComment #8
anilbhatt commentedThanks a lot for your review, Great, so fast reply really appreciated.
Answer of comment #3 .
Above modules as work in same manner but still either the they depend on some third party JQuery library or they add a css file to fulfill their requirements, but in case of this module a very simple logic has been implemented without use of any external css or third party js file. Also with this module i am attaching an admin form where user can easily select the color, opacity , background, fade time and form id for which he/she wants to attach this logic.
Also i am adding some documents for admin setting form with the project page (http://drupal.org/sandbox/anilbhatt/1416224) so that it will more prominent to user.
Thanks & Regards
Anil Bhatt
Comment #9
anilbhatt commentedComment #10
anilbhatt commentedGet PAReview: review bonus.
Comment #11
klausiNo list of reviews in the issue summary, removing review bonus tag. Please read #1410826: [META] Review bonus again.
Comment #12
anilbhatt commentedList of reviews added in issue summary.
Comment #13
klausiRemoving review bonus tag, you did not do a single manual review as required in #1410826: [META] Review bonus. Posting automated coding standards reports is not enough. Also, please don't post the output of automated review tools like pareview.sh inline in a comment, as it just clutters the issue. Better add it as .txt attachment instead.
Comment #14
thursday_bw commentedCollaboration rather than competition
It seems this module doesn't meet the guidelines as specified on the Collaboration rather than competition
page.
Specifically of note the guideline:
Possible new feature for existing module
An enhanced admin form could be an excellent addition to one of the existing similar modules.
Third party API's
I'm interested in feedback from other reviews on this idea. Using third party jQuery API's and plugins has a distinct advantage of support from maintainers of those API's, resulting in improved security and reduced duplication.. However there are advantages to natively supported API's when it comes to ease of installation of modules, and reduced dependencies.
What input do you other reviewer's have on this aspect?
Comment #15
anilbhatt commentedThanks for your reviews.
I am very ok with your view, don't competition with other modules, but here i am not doing any competition with other modules, you have given me two modules examples and even both are working in same manner, then i would like to ask you who have approved/ fixed these module because one of them already working in same manner?
Let me give you other examples as well like "fb" module and "fbconnect" module, many jquery slider modules , they all work in a same manner but there is no question of duplicate. We must have alternatives because many times some modules create problem.
Take an example of "FB" module, suppose facebook update its library then Owner or maintainer of "FB" module should have have to update this module as well, but if same time maintainer / owner don't get time to update it, what would happen? everyone will look forward for alternatives.
Comment #16
patrickd commentedIt appears that there have been multiple project applications opened under your username:
Project 1: https://drupal.org/node/1416240
Project 2: https://drupal.org/node/1413866
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue.
Please close one of them!
Comment #17
anilbhatt commentedclosed because other module need to be review first.
Comment #17.0
anilbhatt commentedreview of other projects added.