Integration with Commerce Recurring Framework

First pass. Not quite working for me yet but payments are processing. It may be an issue elsewhere in commerce_recurring module.

Hm bummer. Check out function commerce_recurring_load_payments_due() in commerce_recurring.rules.inc. For starters, check to see if there are orders being selected when you run Cron. If there aren't any, then it's a configuration issue in your sandbox. I'm looking at one of my recurring orders from three cycles back and it has three payments on it. I'm going to debug why every recurring child order is processed every time.

I just:

- deleted all my test orders
- added a new user
- checked out with a recurring product logged in with the new test user
- changed my server to the Invoice date on the parent order
- ran cron
- saw the child order created
- changed my server to the Payment Due date on the child order
- ran cron
- saw no payment attempted (no orders were collected by commerce_recurring_load_payments_due() as I saw in my debugger)
- changed my server to the day after the Payment Due date on the child order
- ran cron
- Received the following error after cron finished:

"Notice: Undefined offset: 1 in commerce_authnet_cim_cardonfile_charge() (line 1265 of /home/ubuntu/workspace/greenlink-pantheon/sites/all/modules/commerce_authnet/commerce_authnet.module)"

Debugging now...

I found a problem with my last patch, using a value I thought would provide the CID id didn't so now I just take the first Card On File and assume that's what the user wants to use. We'll have to implement some "Default Card On File" functionality later in the Card On File module.

Running this test I'm having success until the last step which is causing duplicate payments:

- deleted all my test orders
- added a new user
- checked out with a recurring product logged in with the new test user
- confirmed a payment was made on the parent order
- changed my server to the day after the Invoice date on the parent order
- ran cron
- confirmed child order was created
- confirmed parent order Next Invoice field increased by interval set in Parent products Billing Interval
- changed my server to the day after the Payment Due date on the child order
- ran cron
- confirm a payment was made on child order
- ran cron again to make sure the same order wasn't picked up again for processing... It was.

So in

/**
 * Rules action callback: Load orders
*/
function commerce_recurring_load_payments_due() {
  $query = new EntityFieldQuery();
  $query->entityCondition('entity_type', 'commerce_order');
  $query->entityCondition('bundle', 'recurring_order');
  $now = new DateObject('now');
  $query->fieldCondition('commerce_recurring_payment_due', 'value', $now->format('U'), '<=');
  $query->fieldCondition('commerce_recurring_payment', 'value', 0, '=');
  $query->range(0, variable_get('commerce_recurring_batch_process', 20));
  $results = $query->execute();
  if (!empty($results['commerce_order'])) {
    return array('orders' => commerce_order_load_multiple(array_keys($results['commerce_order'])));
  }
  return array('orders' => array());
}

The $query->fieldCondition('commerce_recurring_payment', 'value', 0, '='); is not excluding orders that have payments. We have to figure out why.

bug filed on commerce_recurring: #1421848: Document what charge callbacks should return
feature request on commerce_cardonfile: #1421832: Option to define a User's Default Card On File

It turns out the charge callbacks need to return TRUE to avoid the issue of duplicate payments. The new patch takes this into account. From my testing, this is working now.