Spexe: is an communication system for all your websites, branch offices and employees. Your customer service representative communicates via a regular chat application, for example: Pidgin or Adium, and site visitors via web-chat.
Your customer communicates via chat on your website, and your customer service representative via Jabber IM.
Calls and Video-calls from the site.
The customer service representative’s online status updates without reload the webpage.
No additional load on your website, hosting service or server.
If the customer service representative is off-line, messages can be sent via eMail
http://www.spexe.com/en
http://drupal.org/sandbox/spexe/1422076
http://drupalcode.org/sandbox/spexe/1422076.git
It's for Drupal 6

Comments

drupaledmonk’s picture

Status: Needs review » Needs work

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

README.txt is missing, see the guidelines for in-project documentation.
Remove all old CVS $Id tags, they are not needed anymore.

spexe/spexe.install:2:// $Id: spexe.install $
spexe/spexe.module:2:// $Id: spexe.module,v 0.0.0.1 2012/01/31 0:0:0 SPEXE Exp $
spexe/spexe.admin.inc:2:// $Id: spexe.admin.inc,v 0.0.0.1 2012/01/31 0:0:0 SPEXE Exp $
Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards

sites/all/modules/pareview_temp/test_candidate/./spexe/spexe.install:
+2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file.

sites/all/modules/pareview_temp/test_candidate/./spexe/spexe.admin.inc:
+2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file.

Status Messages:
Coder found 2 projects, 2 files, 2 minor warnings, 0 warnings were flagged to be ignored

FILE: ...areview/sites/all/modules/pareview_temp/test_candidate/spexe/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------

4 | WARNING | Line exceeds 80 characters; contains 101 characters
7 | ERROR | Files must end in a single new line character

--------------------------------------------------------------------------------

FILE: ...ew/sites/all/modules/pareview_temp/test_candidate/spexe/spexe.admin.inc
--------------------------------------------------------------------------------
FOUND 129 ERROR(S) AND 5 WARNING(S) AFFECTING 62 LINE(S)
--------------------------------------------------------------------------------

2 | ERROR | You must use "/**" style comments for a file comment
2 | ERROR | There must be no blank line following an inline comment
8 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
8 | ERROR | There must be no blank line following an inline comment
11 | ERROR | You must use "/**" style comments for a function comment
12 | ERROR | Spaces must be used to indent lines; tabs are not allowed
12 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
13 | ERROR | Spaces must be used to indent lines; tabs are not allowed
13 | ERROR | Array indentation error, expected 3 spaces but found 2
14 | ERROR | Spaces must be used to indent lines; tabs are not allowed
14 | ERROR | Array indentation error, expected 3 spaces but found 2
15 | ERROR | Spaces must be used to indent lines; tabs are not allowed
15 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
16 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 0
17 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 0
20 | ERROR | Spaces must be used to indent lines; tabs are not allowed
20 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
21 | ERROR | Spaces must be used to indent lines; tabs are not allowed
21 | ERROR | Array indentation error, expected 3 spaces but found 2
22 | ERROR | Spaces must be used to indent lines; tabs are not allowed
22 | ERROR | Array indentation error, expected 3 spaces but found 2
23 | ERROR | Spaces must be used to indent lines; tabs are not allowed
23 | ERROR | Array indentation error, expected 3 spaces but found 2
23 | ERROR | Concat operator must be surrounded by spaces
23 | ERROR | Concat operator must be surrounded by spaces
24 | ERROR | Spaces must be used to indent lines; tabs are not allowed
24 | ERROR | Array indentation error, expected 3 spaces but found 2
25 | ERROR | Spaces must be used to indent lines; tabs are not allowed
25 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
27 | ERROR | Spaces must be used to indent lines; tabs are not allowed
27 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
28 | ERROR | Spaces must be used to indent lines; tabs are not allowed
28 | ERROR | Array indentation error, expected 3 spaces but found 2
29 | ERROR | Spaces must be used to indent lines; tabs are not allowed
29 | ERROR | Array indentation error, expected 3 spaces but found 2
30 | ERROR | Spaces must be used to indent lines; tabs are not allowed
30 | ERROR | Array indentation error, expected 3 spaces but found 2
30 | ERROR | Concat operator must be surrounded by spaces
30 | ERROR | Concat operator must be surrounded by spaces
31 | ERROR | Spaces must be used to indent lines; tabs are not allowed
31 | ERROR | Array indentation error, expected 3 spaces but found 2
32 | ERROR | Spaces must be used to indent lines; tabs are not allowed
32 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
34 | ERROR | Spaces must be used to indent lines; tabs are not allowed
34 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
35 | ERROR | Spaces must be used to indent lines; tabs are not allowed
35 | ERROR | Array indentation error, expected 3 spaces but found 2
36 | ERROR | Spaces must be used to indent lines; tabs are not allowed
36 | ERROR | Array indentation error, expected 3 spaces but found 2
37 | ERROR | Spaces must be used to indent lines; tabs are not allowed
37 | ERROR | Array indentation error, expected 3 spaces but found 2
37 | WARNING | Last item of an inline array must not be followed by a comma
38 | ERROR | Spaces must be used to indent lines; tabs are not allowed
38 | ERROR | Array indentation error, expected 3 spaces but found 2
39 | ERROR | Spaces must be used to indent lines; tabs are not allowed
39 | ERROR | Array indentation error, expected 3 spaces but found 2
40 | ERROR | Spaces must be used to indent lines; tabs are not allowed
40 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
42 | ERROR | Spaces must be used to indent lines; tabs are not allowed
42 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
43 | ERROR | Spaces must be used to indent lines; tabs are not allowed
43 | ERROR | Array indentation error, expected 3 spaces but found 2
44 | ERROR | Spaces must be used to indent lines; tabs are not allowed
44 | ERROR | Array indentation error, expected 3 spaces but found 2
45 | ERROR | Spaces must be used to indent lines; tabs are not allowed
45 | ERROR | Array indentation error, expected 3 spaces but found 2
45 | ERROR | Concat operator must be surrounded by spaces
45 | ERROR | Concat operator must be surrounded by spaces
45 | ERROR | Concat operator must be surrounded by spaces
45 | ERROR | Concat operator must be surrounded by spaces
45 | ERROR | Concat operator must be surrounded by spaces
45 | ERROR | Concat operator must be surrounded by spaces
46 | ERROR | Spaces must be used to indent lines; tabs are not allowed
46 | ERROR | Array indentation error, expected 3 spaces but found 2
47 | ERROR | Spaces must be used to indent lines; tabs are not allowed
47 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
49 | ERROR | Spaces must be used to indent lines; tabs are not allowed
49 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
50 | ERROR | Spaces must be used to indent lines; tabs are not allowed
50 | ERROR | Array indentation error, expected 3 spaces but found 2
51 | ERROR | Spaces must be used to indent lines; tabs are not allowed
51 | ERROR | Array indentation error, expected 3 spaces but found 2
52 | ERROR | Spaces must be used to indent lines; tabs are not allowed
52 | ERROR | Array indentation error, expected 3 spaces but found 2
52 | WARNING | Last item of an inline array must not be followed by a comma
53 | ERROR | Spaces must be used to indent lines; tabs are not allowed
53 | ERROR | Array indentation error, expected 3 spaces but found 2
54 | ERROR | Spaces must be used to indent lines; tabs are not allowed
54 | ERROR | Array indentation error, expected 3 spaces but found 2
55 | ERROR | Spaces must be used to indent lines; tabs are not allowed
55 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
57 | ERROR | Spaces must be used to indent lines; tabs are not allowed
57 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
58 | ERROR | Spaces must be used to indent lines; tabs are not allowed
58 | ERROR | Array indentation error, expected 3 spaces but found 2
59 | ERROR | Spaces must be used to indent lines; tabs are not allowed
59 | ERROR | Array indentation error, expected 3 spaces but found 2
60 | ERROR | Spaces must be used to indent lines; tabs are not allowed
60 | ERROR | Array indentation error, expected 3 spaces but found 2
60 | WARNING | Last item of an inline array must not be followed by a comma
61 | ERROR | Spaces must be used to indent lines; tabs are not allowed
61 | ERROR | Array indentation error, expected 3 spaces but found 2
62 | ERROR | Spaces must be used to indent lines; tabs are not allowed
62 | ERROR | Array indentation error, expected 3 spaces but found 2
63 | ERROR | Spaces must be used to indent lines; tabs are not allowed
63 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
66 | ERROR | Spaces must be used to indent lines; tabs are not allowed
66 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
67 | ERROR | Spaces must be used to indent lines; tabs are not allowed
67 | ERROR | Array indentation error, expected 3 spaces but found 2
68 | ERROR | Spaces must be used to indent lines; tabs are not allowed
68 | ERROR | Array indentation error, expected 3 spaces but found 2
69 | ERROR | Spaces must be used to indent lines; tabs are not allowed
69 | ERROR | Array indentation error, expected 3 spaces but found 2
69 | ERROR | Concat operator must be surrounded by spaces
69 | ERROR | Concat operator must be surrounded by spaces
69 | ERROR | Concat operator must be surrounded by spaces
69 | ERROR | Concat operator must be surrounded by spaces
69 | ERROR | Concat operator must be surrounded by spaces
69 | ERROR | Concat operator must be surrounded by spaces
70 | ERROR | Spaces must be used to indent lines; tabs are not allowed
70 | ERROR | Array indentation error, expected 3 spaces but found 2
71 | ERROR | Spaces must be used to indent lines; tabs are not allowed
71 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
74 | ERROR | Spaces must be used to indent lines; tabs are not allowed
74 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
85 | WARNING | Line exceeds 80 characters; contains 129 characters
89 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 0
112 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
114 | WARNING | Line exceeds 80 characters; contains 93 characters
146 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 0
154 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 0
156 | ERROR | Spaces must be used to indent lines; tabs are not allowed
156 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1

--------------------------------------------------------------------------------

FILE: ...areview/sites/all/modules/pareview_temp/test_candidate/spexe/spexe.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
10 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...view/sites/all/modules/pareview_temp/test_candidate/spexe/spexe.install
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AND 2 WARNING(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------

2 | ERROR | You must use "/**" style comments for a file comment
2 | ERROR | There must be no blank line following an inline comment
5 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
12 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."

--------------------------------------------------------------------------------

FILE: ...eview/sites/all/modules/pareview_temp/test_candidate/spexe/spexe.module
--------------------------------------------------------------------------------
FOUND 33 ERROR(S) AND 1 WARNING(S) AFFECTING 19 LINE(S)
--------------------------------------------------------------------------------

2 | ERROR | You must use "/**" style comments for a file comment
6 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
12 | ERROR | Expected "if (...) {\n"; found "if(...){ "
12 | ERROR | Closing brace must be on a line by itself
13 | ERROR | Expected "}\nelse {\n"; found "}\nelse { "
13 | ERROR | Closing brace must be on a line by itself
16 | ERROR | Expected "if (...) {\n"; found "if(...){ "
16 | ERROR | Closing brace must be on a line by itself
17 | ERROR | Expected "}\nelse {\n"; found "}\nelse { "
17 | ERROR | Closing brace must be on a line by itself
25 | ERROR | There must be a single space before an operator statement
26 | ERROR | There must be a single space before an operator statement
29 | ERROR | Expected "if (...) {\n"; found "if(...){ "
29 | ERROR | Concat operator must be surrounded by spaces
29 | ERROR | Closing brace must be on a line by itself
49 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
52 | ERROR | Spaces must be used to indent lines; tabs are not allowed
52 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
53 | ERROR | Spaces must be used to indent lines; tabs are not allowed
53 | ERROR | Array indentation error, expected 3 spaces but found 2
54 | ERROR | Spaces must be used to indent lines; tabs are not allowed
54 | ERROR | Array indentation error, expected 3 spaces but found 2
55 | ERROR | Spaces must be used to indent lines; tabs are not allowed
55 | ERROR | Array indentation error, expected 3 spaces but found 2
56 | ERROR | Spaces must be used to indent lines; tabs are not allowed
56 | ERROR | Array indentation error, expected 3 spaces but found 2
57 | ERROR | Spaces must be used to indent lines; tabs are not allowed
57 | ERROR | Array indentation error, expected 3 spaces but found 2
58 | ERROR | Spaces must be used to indent lines; tabs are not allowed
58 | ERROR | Array indentation error, expected 3 spaces but found 2
59 | ERROR | Spaces must be used to indent lines; tabs are not allowed
59 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
60 | ERROR | Spaces must be used to indent lines; tabs are not allowed
60 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
--------------------------------------------------------------------------------
spexe’s picture

Status: Needs work » Needs review

ok.
please review again

Spexe: is an communication system for all your websites, branch offices and employees. Your customer service representative communicates via a regular chat application, for example: Pidgin or Adium, and site visitors via web-chat.
Your customer communicates via chat on your website, and your customer service representative via Jabber IM.
Calls and Video-calls from the site.
The customer service representative’s online status updates without reload the webpage.
No additional load on your website, hosting service or server.
If the customer service representative is off-line, messages can be sent via eMail
http://www.spexe.com/en
http://drupal.org/sandbox/spexe/1422076
http://drupalcode.org/sandbox/spexe/1422076.git
It's for Drupal 6

drupaledmonk’s picture

Status: Needs review » Needs work

Please do a review of your code using http://ventral.org/pareview , fix all the errors / warnings and change the status.

spexe’s picture

Status: Needs work » Needs review
drupaledmonk’s picture

Looks like there are no formatting errors, Please move the development from master branch to a version specific branch. Also there seems to be a folder within the repo, move all the files to the base directory. The package, version, project, datestamp will be added by d.org, please remove them.

drupaledmonk’s picture

Status: Needs review » Needs work
spexe’s picture

Thanks.
If I understand you correctly then I have fulfilled your requirements,
how you can put the project out of the sandbox?

http://drupalcode.org/sandbox/spexe/1422076.git
http://drupal.org/sandbox/spexe/1422076
Kind Regards.
Maxim

drupaledmonk’s picture

Status: Needs work » Needs review

You still seem to be working in the master branch, please move your development to a version specific branch. Also remove the branch master-2. Moving from a master branch to a version specific branch
Thanks for your contributions!!

spexe’s picture

Thanks.
Maybe this time I did it?
http://drupalcode.org/sandbox/spexe/1422076.git

spexe’s picture

ok.
please review again
http://drupal.org/sandbox/spexe/1422076
http://drupalcode.org/sandbox/spexe/1422076.git

how you can put the project out of the sandbox?

patrickd’s picture

Assigned: spexe » Unassigned

Yes, you're on a version-specific branch now

But, PLEASE be a little more informative on your commits then "piu", "pum", "pipez", "final", ...

Please don't assign the issue to your self, only the current reviewer should do this.

as there are currently many applications in queue we need more reviewers,
so think about getting a review bonus and we will come back to your application sooner.

prashantgoel’s picture

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 6.x-1.x branch:

README.txt is missing, see the guidelines for in-project documentation.
Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

FILE: ...ew/sites/all/modules/pareview_temp/test_candidate/spexe/spexe.admin.inc
--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AFFECTING 7 LINE(S)
--------------------------------------------------------------------------------

25 | ERROR | Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
32 | ERROR | Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
39 | ERROR | If the line declaring an array spans longer than 80 characters,
| | each element should be broken into its own line
47 | ERROR | Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
54 | ERROR | If the line declaring an array spans longer than 80 characters,
| | each element should be broken into its own line
61 | ERROR | If the line declaring an array spans longer than 80 characters,
| | each element should be broken into its own line
68 | ERROR | Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal

--------------------------------------------------------------------------------

spexe’s picture

Thanks.
i think all fixed now.
Please review again
http://drupal.org/sandbox/spexe/1422076
http://drupalcode.org/sandbox/spexe/1422076.git
how you can put the project out of the sandbox?

prashantgoel’s picture

hi spexe,
There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 6.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

spexe’s picture

Assigned: Unassigned » spexe

I do not know why it throws this error,
README file is there

prashantgoel’s picture

Please don't assign the issue to your self, only the current reviewer should do this as pointed in http://drupal.org/node/1422160#comment-5684410.

This error is thrown because you have a separate directory inside your project folder.

And moreover your master branch is not empty I rechecked on that.

prashantgoel’s picture

Assigned: spexe » Unassigned
Status: Needs review » Needs work
spexe’s picture

Assigned: Unassigned » spexe
Status: Needs work » Needs review

i think all fixed now.
Please review again
Thanks

prashantgoel’s picture

Please don't assign the issue to your self, only the current reviewer should do this as pointed in http://drupal.org/node/1422160#comment-5684410.

I have personally rechecked still now your master branch contains file please do accomplish finally and then only ask for a review

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 6.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

prashantgoel’s picture

Assigned: spexe » Unassigned
Status: Needs review » Needs work
spexe’s picture

Assigned: Unassigned » spexe
Status: Needs work » Needs review

Yes you are right there were files
I deleted them
Thanks.

prashantgoel’s picture

Assigned: spexe » Unassigned
Status: Needs review » Reviewed & tested by the community

ok now everything seems good.

klausi’s picture

Status: Reviewed & tested by the community » Needs work

You have not listed any reviews of other project applications in your issue summary as strongly recommended here: http://drupal.org/node/1011698

manual review:

  1. "la la la" is a very bad commit message, see http://drupal.org/node/52287
  2. info file: the line "core = "6.x"" appears twice.
  3. info file: "; Information added by drupal.org packaging script on 2012-01-31" remove that line.
  4. spexe_install(): why do you need to set the module weight? Please add a comment about that.
  5. spexe_uninstall(): do not delete the entry about your module from the system table, that is Drupal core's responsibilty.
  6. spexe.install: @file doc block is too short, see examples on http://drupal.org/node/1354#files
  7. spexe.module: you are executing PHP code globally here, normally you should not have to do that. Why can't you use an appropriate hook?
  8. spexe_menu(): indentation errors, always use 2 spaces per level, not more.
  9. spexe_settings(): @function does not exist. See http://drupal.org/node/1354#functions
  10. "'lgreen' => 'Green',": all user facing text must run through t() for translation. Please check all your strings.
klausi’s picture

"spexe" looks like a shared company account. Please note: All user accounts are for individuals. Accounts created for more than one user will be blocked when discovered.

klausi’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.