Spexe: is an communication system for all your websites, branch offices and employees. Your customer service representative communicates via a regular chat application, for example: Pidgin or Adium, and site visitors via web-chat.
Your customer communicates via chat on your website, and your customer service representative via Jabber IM.
Calls and Video-calls from the site.
The customer service representative’s online status updates without reload the webpage.
No additional load on your website, hosting service or server.
If the customer service representative is off-line, messages can be sent via eMail
http://www.spexe.com/en
http://drupal.org/sandbox/spexe/1422076
http://drupalcode.org/sandbox/spexe/1422076.git
It's for Drupal 6
Comments
Comment #1
drupaledmonk commentedIt appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:
README.txt is missing, see the guidelines for in-project documentation.
Remove all old CVS $Id tags, they are not needed anymore.
spexe/spexe.install:2:// $Id: spexe.install $
spexe/spexe.module:2:// $Id: spexe.module,v 0.0.0.1 2012/01/31 0:0:0 SPEXE Exp $
spexe/spexe.admin.inc:2:// $Id: spexe.admin.inc,v 0.0.0.1 2012/01/31 0:0:0 SPEXE Exp $
Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
sites/all/modules/pareview_temp/test_candidate/./spexe/spexe.install:
+2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file.
sites/all/modules/pareview_temp/test_candidate/./spexe/spexe.admin.inc:
+2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file.
Status Messages:
Coder found 2 projects, 2 files, 2 minor warnings, 0 warnings were flagged to be ignored
FILE: ...areview/sites/all/modules/pareview_temp/test_candidate/spexe/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
FILE: ...ew/sites/all/modules/pareview_temp/test_candidate/spexe/spexe.admin.inc
--------------------------------------------------------------------------------
FOUND 129 ERROR(S) AND 5 WARNING(S) AFFECTING 62 LINE(S)
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
FILE: ...areview/sites/all/modules/pareview_temp/test_candidate/spexe/spexe.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
10 | ERROR | Files must end in a single new line character--------------------------------------------------------------------------------
FILE: ...view/sites/all/modules/pareview_temp/test_candidate/spexe/spexe.install
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AND 2 WARNING(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
FILE: ...eview/sites/all/modules/pareview_temp/test_candidate/spexe/spexe.module
--------------------------------------------------------------------------------
FOUND 33 ERROR(S) AND 1 WARNING(S) AFFECTING 19 LINE(S)
--------------------------------------------------------------------------------
Comment #2
spexe commentedok.
please review again
Spexe: is an communication system for all your websites, branch offices and employees. Your customer service representative communicates via a regular chat application, for example: Pidgin or Adium, and site visitors via web-chat.
Your customer communicates via chat on your website, and your customer service representative via Jabber IM.
Calls and Video-calls from the site.
The customer service representative’s online status updates without reload the webpage.
No additional load on your website, hosting service or server.
If the customer service representative is off-line, messages can be sent via eMail
http://www.spexe.com/en
http://drupal.org/sandbox/spexe/1422076
http://drupalcode.org/sandbox/spexe/1422076.git
It's for Drupal 6
Comment #3
drupaledmonk commentedPlease do a review of your code using http://ventral.org/pareview , fix all the errors / warnings and change the status.
Comment #4
spexe commentedThanks pls check again it.
http://drupal.org/sandbox/spexe/1422076
http://drupalcode.org/sandbox/spexe/1422076.git
It's for Drupal 6
Comment #5
drupaledmonk commentedLooks like there are no formatting errors, Please move the development from master branch to a version specific branch. Also there seems to be a folder within the repo, move all the files to the base directory. The package, version, project, datestamp will be added by d.org, please remove them.
Comment #6
drupaledmonk commentedComment #7
spexe commentedThanks.
If I understand you correctly then I have fulfilled your requirements,
how you can put the project out of the sandbox?
http://drupalcode.org/sandbox/spexe/1422076.git
http://drupal.org/sandbox/spexe/1422076
Kind Regards.
Maxim
Comment #8
drupaledmonk commentedYou still seem to be working in the master branch, please move your development to a version specific branch. Also remove the branch master-2. Moving from a master branch to a version specific branch
Thanks for your contributions!!
Comment #9
spexe commentedThanks.
Maybe this time I did it?
http://drupalcode.org/sandbox/spexe/1422076.git
Comment #10
spexe commentedok.
please review again
http://drupal.org/sandbox/spexe/1422076
http://drupalcode.org/sandbox/spexe/1422076.git
how you can put the project out of the sandbox?
Comment #11
patrickd commentedYes, you're on a version-specific branch now
But, PLEASE be a little more informative on your commits then "piu", "pum", "pipez", "final", ...
Please don't assign the issue to your self, only the current reviewer should do this.
as there are currently many applications in queue we need more reviewers,
so think about getting a review bonus and we will come back to your application sooner.
Comment #12
prashantgoel commentedThis automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 6.x-1.x branch:
README.txt is missing, see the guidelines for in-project documentation.
Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
FILE: ...ew/sites/all/modules/pareview_temp/test_candidate/spexe/spexe.admin.inc
--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AFFECTING 7 LINE(S)
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Comment #13
spexe commentedThanks.
i think all fixed now.
Please review again
http://drupal.org/sandbox/spexe/1422076
http://drupalcode.org/sandbox/spexe/1422076.git
how you can put the project out of the sandbox?
Comment #14
prashantgoel commentedhi spexe,
There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 6.x-1.x branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
Source: http://ventral.org/pareview - PAReview.sh online service
Comment #15
spexe commentedI do not know why it throws this error,
README file is there
Comment #16
prashantgoel commentedPlease don't assign the issue to your self, only the current reviewer should do this as pointed in http://drupal.org/node/1422160#comment-5684410.
This error is thrown because you have a separate directory inside your project folder.
And moreover your master branch is not empty I rechecked on that.
Comment #17
prashantgoel commentedComment #18
spexe commentedi think all fixed now.
Please review again
Thanks
Comment #19
prashantgoel commentedPlease don't assign the issue to your self, only the current reviewer should do this as pointed in http://drupal.org/node/1422160#comment-5684410.
I have personally rechecked still now your master branch contains file please do accomplish finally and then only ask for a review
There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 6.x-1.x branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
Source: http://ventral.org/pareview - PAReview.sh online service
Comment #20
prashantgoel commentedComment #21
spexe commentedYes you are right there were files
I deleted them
Thanks.
Comment #22
prashantgoel commentedok now everything seems good.
Comment #23
klausiYou have not listed any reviews of other project applications in your issue summary as strongly recommended here: http://drupal.org/node/1011698
manual review:
Comment #24
klausi"spexe" looks like a shared company account. Please note: All user accounts are for individuals. Accounts created for more than one user will be blocked when discovered.
Comment #25
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.