JSONP SPARQL

Welcome with your application.
It's going to take some time to get a full review, but hopefully you will get as soon as possible.

Anyhow, it seem that you included third party code (js-file), you should not have that in projects on drupal.org: http://drupal.org/node/422996

Just a few coding issues. See the attached file with the scan results.

Please see documentation standards and coding standards. The documentation is not following convention:
Example:

/**
 * Build the settings form.
 */
function jsonp_sparql_admin_settings($form, &$form_state) 
function jsonp_sparql_admin_settings($form, &$form_state)

This needs to have a full documented header. Same throughout.

See:
http://drupal.org/coding-standards
http://drupal.org/node/1354

Hi,
I am trying to install your module and I'm getting the following warning.
The JQuery JSONP plugin must be installed in order to do any client side queries. Please go to Status Report for instructions.
In the .install file you check for the 2.2.0 version. I downloaded the latest version which is 2.2.1. The name for the 2.2.1 version is a bit different also. You should fix this with a more robust check.

if (file_exists($path . '/jquery.jsonp-2.2.0.min.js') || file_exists($path . '/jquery.jsonp-2.2.0.js')) {

I've tried to execute a basic sparql query from dbpedia, but I encountered a 404 error. See attachment screenshot. I don't have a proxy.

.module file line 162 ... :)

else: {
  // TODO: Write som clever stuff here.
  dsm('damn');
}

Parareview did not mention any issues.

What is SPARQL and what does a SPARQL endpoint do?
It would be nice having some basic information and maybe an external link at your project page.

/**
 * On uninstall: remove module variables and clear variable cache.
 */
function jsonp_sparql_uninstall() {
  db_query("DELETE FROM {variable} WHERE name LIKE 'jsonp_sparql_%'");
  cache_clear_all('variables', 'cache');
}

You should mention "Implements hook_uninstall()." at the beginning of doc-comment.

'page callback' => '_jsonp_sparql_ajax_test'
Page callbacks should be public functions, so you should remove "_"

Consider putting the following code into a template-function or into event template-file, see http://api.drupal.org/api/drupal/includes!theme.inc/function/theme/7

        $block['content'] .= '<div style="text-align:center;" id="sparqlloading' . $i . '"><img src="' . $base_path . $modulepath . '/img/loading.gif"></div>';
        $block['content'] .= '</div>';

  $form['jsonp_sparql_block_set' . $delta]['second']['jsonp_sparql_test_query_' . $delta] = array(
    '#type' => 'markup',
    '#title' => 'Test Sparql query',
    '#prefix' => '<div class="sparqltestquery" id="jsonp_sparql_querytest_' . $delta . '"><button class="' . $delta . '">' . t('Test Sparql query') . '</button>',
    '#suffix' => '<div class="testquerydesc">' . t('This magic button will also fill out the column presentation in the presentation tab') . '</div></div>',
  );

The response time for a review is now approaching 4 weeks.
Get a review bonus and we will come back to your application sooner.
See: http://drupal.org/node/1410826

You could for example start by evaluatating my own project:
http://drupal.org/node/1302786

Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: ...7/sites/all/modules/pareview_temp/test_candidate/jsonp_sparql.admin.inc
  --------------------------------------------------------------------------------
  FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   33 | ERROR | Function comment short description must end with a full stop
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

1. "variable_get('jsonp_sparql_blocks_number')": instead of checking the result for this call you can just pass the default value "1" to variable_get() as second parameter.
2. "t('JSONP SPARQL block') . ' ' . $human_number": don't concatenate variables into translatable strings, use placeholders instead.
3. "php_eval($phpcode)": I hate it when I see that. Is that really necessary? Executing user provided input is a security and maintenance nightmare. You should only do that if the php module is enabled, so that there is some restriction possible for site administrators. I see that you check for the PHP permission in jsonp_sparql_block_configure(), so it is probably ok.
4. "function_exists('php_eval')": that function always exists in Drupal, so this check is not necessary.
5. "t('The SPARQL endpoint at !server did not answer our request. The error returned was: !error', array('!server' => $server, '!error' => $data->error))": this is vulnerable to XSS exploits, as $server is user provided input and needs to be sanitized. See http://drupal.org/node/28984 . Use the "@" placeholder and t() will run check_plain() automatically for you.
6. "drupal_add_js('Drupal.jsonpSparqlParse(' . $i . ', ' . $data . ');',": $data is untrusted third party input. You can't just embed it like that, as the server could return a malicious script snippet that would get embedded and executed. Why can't you pass the response as javascript setting?
7. jsonp_sparql.js: Contains a strange first character, see http://drupalcode.org/sandbox/eiriksm/1409172.git/blob/refs/heads/7.x-1....
8. jsonp_sparql_form.js: "$(document).ready(function() {": I think you should use Drupal.behaviors instead. See http://drupal.org/node/756722 and http://drupal.org/node/304258#drupal-behaviors
9. "Drupal.t('Oh no. An error. The server returned an error code !code with the following message: !error', {'!code': data['code'], '!error': data['error']}": again, you should use the "@" placeholder to be safe.
10. "module_exists('libraries')": that call is useless as you module depends on libraries anyway, so remove it.
11. jsonp_sparql_admin_settings(): no need to check for the library again here, hook_requirements() already ensures that.
12. jsonp_sparql_block_save(): It is too late to check for access here. And you already check in jsonp_sparql_block_configure(), so remove the check here.
13. "'#title' => 'Custom PHP code to use for input',": all user facing text must run through t() for translation. Same for "array(TRUE => 'yes', FALSE => 'no'),". Please check all your strings.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

manual review:

1. jsonp_sparql_ajax_test(): you should use drupal_json_output().
2. jsonp_sparql_admin_settings(): you could use element_validate_number() as #element_validate callback.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Thanks for your contribution and welcome to the community of project contributors on drupal.org!

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.