[D7] Novalnet Payment Module

You're working in the master branch instead of a version-specific branch (here's how to fix it. Also, please add your git clone URL to this issue for the convenience of reviewers.

Ventral's online PAReview code checker finds a lot of problems. See the attached file for a full list. You're missing README.txt, and you've also got code style issues; those are pretty straightforward. PAReview also takes issue with the names of your files, but I don't know whether this rule applies to a drupalcommerce payment module.

Should be 'needs work'

Novalnet, why did you change status? Also you need to add git (git clone) link and sandbox link to the first post. Read this, http://drupal.org/node/1011698, if you have not done that allready, and update your post.

The link to the the repo should be:
git clone http://git.drupal.org/sandbox/Novalnet/1443688.git novalnet_payment_module

The link to the Project page should be: http://drupal.org/sandbox/Novalnet/1443688

You also need to add a good project description, and follow the instructions in http://drupal.org/node/1011698. When you have done that, you could set back to Need review. I am doing a manual review of the code right now.

Manual review:

drupalcommerce_v_D_7.x-1.0_novalnet_v_1.0.1

You should remove the folder drupalcommerce_v_D_7.x-1.0_novalnet_v_1.0.1 and all the content. Relevant instructions should be in the README.txt.

There are scripts in that folder. That are the purpose of them?

You have a sites-folder in here, it should not be any folders like that in a module, the module files that you have placed inside the module folder should be in the first folder.

In the module folder you have 11 module files. Why?

novalnet_payment.info and novalnet_payment_module.info

You need to add the relevant info in the info file, you are missing important information, read more about it here: http://drupal.org/node/171205

I do not understand why you have two info files

Before we could review your code, you have to put together this project according to drupal-standards.

Do not change to need review if you are not ready for review. And again, please read the link, and update your post with the correct information.

Regarding structure of the project, look at existing projects, and see how they are structured.

You still have wrong path for you module files. Please check the structure of existings projects.

Please don't assign the issue to your self, only the current reviewer should do this.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1443928
Project 2: https://drupal.org/node/1468662
Project 3: https://drupal.org/node/1483532

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)'.

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.