The Webform Localization module provides multilingual features to the Webform Module. Special options in the webform and component configuration let you enable different ways to manage translation of forms and questionnaires.
This module emerges from a very long issue in webform (almost 3 years of discussions) and my work on it begins here: http://drupal.org/node/245424#comment-5412686
The Webform Localization let you choose two different ways to manage localization that cover this scenarios:
A) If you want to keep a single webform across all nodes in a translation set:
Use i18n_string integration to translate webform strings. This module expose webform properties, components and emails strings through the i18n module. All submissions results are related to the original node only.
(You have a "localization by string translation" fieldset in the form settings to enable this)
B) If you want to keep a webform per node per language but synchronized:
The entire webform structure is replicated when a translated node is created then you can customize it at will. You can add specific options or components per language and choose to keep sync: webform properties, components properties, roles and emails recipients. In this scenario make no sense of having results attached to one node since each webform could have a different structure with only a few components in sync.
(You have a "localization by sync" fieldset in the form settings to enable this)
For further details and configuration examples see the Readme.txt file provided.
Version:
Drupal 7
Project Page:
http://drupal.org/sandbox/GDrupal/1407100
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | drupalcs-result.txt | 11.85 KB | klausi |
| #2 | phpcs-webform_localization.txt | 16.5 KB | kongoji |
Comments
Comment #1
patrickd commentedwelcome,
while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxgdrupal1407100git
You can also get a review bonus and we will come back to your application sooner.
Comment #2
kongoji commentedHi GDrupal,
your module seems to work really great.
During manual review I couldn't find anyting important, I write below some very minor points:
1) in
webform_localization.i18n.incfile several times there iswhen in the .info files is already specified the dependency. Maybe you could remove those checks.
2) consider mentioning in README.txt the needing to enable "Content translation" and "Multilingual content" modules to accomplish Example B.
Doing an automatic review with phpcs, there is some code cleaning you should operate. I attach the results.
For me this module is RTBC, but I would like to wait for someone upper than me to set it that way.
Greetz
Comment #3
GDrupal commented@kongoji: Thanks for reviewing this! yeah you are right about the checks.... i will fix them ASAP and update the readme too.
Comment #4
GDrupal commented@kongoji: I forget to mention one thing, the automated test class is a work in progress for now. I will not include in the stable branch until is finished.
Comment #5
rv0 commented+1 for RTBC
The code is good, uses drupal api, coding standards, integrates with other modules and is a much needed feature.
I've already contributed some patches to further improve it, and I'm writing integration in my own module for it ( http://drupal.org/project/webform_template )
btw, important to note that 7.x-1.x is the active one, ignore the master branch.
Comment #6
alexweber commentedWorks well, follows standards and solves a much needed problem.
Comment #7
klausiYou have not listed any reviews of other project applications in your issue summary as strongly recommended here: http://drupal.org/node/1011698
Review of the 7.x-1.x branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
manual review:
"module_load_include('inc', 'webform_localization', 'includes/webform_localization.i18n');": No need to use module_load_inlcude as you are including files from your own module which you already know where they are. Use something like
require_once dirname(__FILE__) . '/mymodule.inc';But that are just minor issues, so ...
Thanks for your contribution, GDrupal! Welcome to the community of project contributors on drupal.org.
I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.
Thanks to the dedicated reviewer(s) as well.
Comment #8
alexweber commentedCongrats GDrupal, here's hoping to see more quality contributions from you in the future! :)
Felicitaciones boludo! :P
Comment #9
GDrupal commented@klausi: Thanks! I will do my best as always!
@alexweber: Gracias Loco! Ya nos vamos a juntar en algun code sprint!
Comment #10
int_ua commentedgit clone http://git.drupal.org/sandbox/GDrupal/1407100.git webform_localizationgives me an empty dir. Am I doing something wrong or is it a server-side issue?
Comment #11
GDrupal commentedRead carefully the notes... you need the 7.x-1.x branch