Translate Terms

Welcome!

I see you've already started fixing the codestyle issues found by drupalcs, great!

Please take a moment to make your README.txt follow the guidelines for in-project documentation.

We do really need more hands in the application queue and highly recommend to get a review bonus so we will(/can) come back to your application sooner.

regards

Hi

Your README need to give more info on how to use your module. You can maybe repeat the synopsis of your project page on Drupal.org. The project page on Drupal.org should also contain a direct link to the README.txt.

We also really need more hands in the application queue. So please consider to get a review bonus so we will come back to your application sooner.

See also http://drupal.org/node/1011698
See also #1410826: [META] Review bonus

By the way I will not use 'und' but LANGUAGE_NONE instead...

Yes usage and installation instructions would be nice

(I don't think this is so critical for needs work)

no but LANGUAGE_NONE could be.

but fine by me if applications can stay 'need review' even if we spot something wrong...

manual review:

• "'access arguments' => array('administer translate terms'),": where does that permission come from? Is this provided by i18n or did you forget to implement hook_permission()?
• "$languages = array(LANGUAGE_NONE => 'Undefined');": all user facing text must run through t() for translation. Also elsewhere.
• "// For each vocabulary.": Comment is a bit too short, for each vocabulary you are doing what?
• "if (module_exists('locale')) {": that check does not make sense, as the dependency chain of your module always requires that "locale" is enabled.
• 'admin/translate_terms': do you think this is a good menu location? I first searched in admin/structure/taxonomy but did not find anything there.
• Your module is XSS vulnerable. If I enter a term with the name <script>alert('XSS');</script> and go to admin/translate_terms I get a nasty javascript popup. Make sure to read http://drupal.org/node/28984 again.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Hi

The rule is to store exactly what the user typed but make sure it is secure when it is displayed.

So to prevent XSS you need to perform the conversion when content is output, not when saved into the database ;-)

Please check http://drupal.org/node/28984

Try to get another review bonus to speed up the process.

Cheers,

Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: ...-7/sites/all/modules/pareview_temp/test_candidate/translateterms.module
  --------------------------------------------------------------------------------
  FOUND 3 ERROR(S) AFFECTING 3 LINE(S)
  --------------------------------------------------------------------------------
   12 | ERROR | Do not use t() in hook_menu()
   13 | ERROR | Do not use t() in hook_menu()
   40 | ERROR | Expected 1 space between the closing parenthesis and the opening
      |       | brace; found 0
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:
"translateterms_textbox_combo($term->tid, $globallang, check_plain($term->name))": instead of doing the check_plain in the function call you should do it as late as possible to the output, i.e directly in translateterms_textbox_combo(). And as the form API sanitizes #default_value automatically you are now doing double escaping, which is bad.

But that are just minor issues, otherwise I would say this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects. Assigning to tim.plunkett as he might have time to finally approve this.

Hi SeyVaneerdewegh,

Thanks for your contribution and welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects, at your discretion.