Feedback Patch - Bug fixes, new features, and general design cleanup

Hello.

Thanks for these changes, they are really good and make a lot of sense.

A few of them have already been applied to the CVS HEAD.

Since 4.5.0 cannot be fixed and retagged (a very bad practice in development), all changes have to go to the CVS version.

So if you can kindly get the CVS version, and apply the patch to it, I will be more than happy to commit them to CVS.

If it helps, here are the results of a failed attempt to apply them to CVS. You can fix the three sections that failed:

Hunk #1 FAILED at 20.
Hunk #3 succeeded at 58 (offset 1 line).
Hunk #4 succeeded at 74 (offset 1 line).
Hunk #5 succeeded at 105 (offset 1 line).
Hunk #6 FAILED at 141.
Hunk #7 succeeded at 205 (offset -1 lines).
Hunk #8 FAILED at 337.

Alrighty, this is now patched against the CVS version. Please disregard all previous patches.

A couple of notes --

1. The previous fixes for the sender's address check are no longer neccessary - However, given the poor performance of the MX lookup, I believe it's better to default this feature of OFF. Fixed.

2. Newly settable Page header and response strings from previous patches remain the same, along with the interface cleanup.

3. The 'type' => MENU_CALLBACK setting broke access permissions on my drupal install (v4.5.1), so I commented it out.

4. Access perms description has changed (same as previous patch).

Let me know if there's any other questions.

thnx

Hi

Thanks for the patches.

I applied them all except for the MENU_CALLBACK one. The reason is I have Drupal 4.5.0 and the CVS version of feedback, and it works fine without issues. So I am not sure what is wrong at your end.

What you can do is checkout the new version from here http://cvs.drupal.org/viewcvs/contrib/contributions/modules/feedback/ and give it a test drive.

If you find any bugs let me know.

Thanks for the work on this patch!

FYI, I had to remove the 'type' => MENU_CALLBACK setting also or else the 'feedback' menu item would not show up in either the administer->menus screen or in the menu itself. I'm running on 4.5.1.

Another FYI for those applying this patch: be sure to go back to user permissions and reset your feedback permissions since this patch changes the name of the permission.

A side effect of this patch that could be undesirable for some: you MUST show the user email field on the form or the send won't work. It uses this value as the "From" address. A nice feature for the future might be to allow anonymous feedback such that if this field is ommitted some default "From" address would be used.

Dan

Using the latest version from CVS as listed previously in this thread (feedback.module,v 1.27). Having trouble, known error as listed above:
--------------------------------------------------------------
warning: fsockopen(): unable to connect to mx01.1and1.com:25 in /homepages/16/d90044543/htdocs/antnottv/modules/feedback.module on line 385.
--------------------------------------------------------------
Also, Bread Crumb navigation does not display on Feedback node. I would like the link back Home to be present there as it is for other nodes, simply for consistency.

Thanks for your help,
Josh

> Having trouble, known error as listed above:
> warning: fsockopen(): unable to connect to mx01.1and1.com:25 in
> /homepages/16/d90044543/htdocs/antnottv/modules/feedback.module on line 385.

This may be dependant on your ISP.
Many ISP block all traffic on port 25 (SMTP) from entire subnet blocks that are known to be for home users (e.g. DSL, dialup, cable, ...etc).

The reason they do this, is SPAM, and trojans that create spambots on unsuspecting users' machines. Some ISPs are more aggressive and block host machines that are block listed (rightly or wrongly).

To verify that this is the case, go to the same machine you have Drupal installed, and try to connect manually to that mx host. For example, if this is Linux or some UNIX variant, then do:

telnet mx01.1and1.com 25

See if you get a prompt. I tried from here, and it worked.

If 1and1.com is indeed blocking your host, then you can contact them and ask them to unblock it.

Otherwise, just uncheck the checkbox that says 'validate sender's email address' in the feedback setup.

>Also, Bread Crumb navigation does not display on Feedback node. I would like the link back
> Home to be present there as it is for other nodes, simply for consistency.

OK. I added htis feature to feedback. It now displays a breadcrumb to Home

Get it from here, and give it a try.

http://cvs.drupal.org/viewcvs/contrib/contributions/modules/feedback/fee...

Thank you.
Bread Crumb now displays with this latest version.
I did not check if my host is blocking port 25, I would assume so.
I disabled the "validate sender's email address" option, and the form now works.