Sentry Nodeinfo

Hi and welcome @rrbambrey

Please take a moment to make your project page follow tips for a great project page.

I noticed some very small code style issues. Please run the Coder module on "minor" setting to help catch these. The coding standards have even more information in this area.

Please note: The Coder module currently has an unresolved flaw which will prompt you to add file declarations to your .info file even when it's not necessary to do so. Please do not try to make this warning go away by declaring files which do not contain classes or interfaces.

You need fix these issues first and is highly recommend to get a review bonus so we can come back to your application sooner.

Regards

Instead of using coder I'd rather recommend having a look at the results of drupalcs/pareview.sh:
An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.

You can find the results of the automated report at http://ventral.org/pareview/httpgitdrupalorgsandboxrrbambrey1612554git

Major issue here: All functions should be prefixed with your module/theme name to avoid name clashes.

regards

manual review:

1. "define(CLIENT_MODULE, 'sentry_client_nodeinfo');": all constants in your module need to prefixed with your module's name ot avoid name collisions.
2. sentry_nodeinfo_overview(): "$row[] = $entry->name;": names are user provided input, so you need to sanitize it before printing to avoid XSS exploits. See http://drupal.org/node/28984
3. Same here: "$row[] = '<a href="' . $entry->url_alias . '" target="_blank" title="View this node">' . $entry->title . '</a>';: better use l() to create the link markup and it will autmatically sanitize the link text for you.
4. sentry_nodeinfo_sentry_report(): all user facing text should run through t() for translation (Comments, Users, etc.).

Otherwise looks nearly ready. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

I can confirm all the issues from Drupal Code Sniffer were removed.

The module & code looks sound.

Thanks for your contribution, rrbambrey! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.