Commerce File Bundle

Please review your project using Coder Module and see the automated ventral review report here.
It is strongly recommended that you take part in the review bonus program, otherwise you will not get reviews of your code for several weeks. So make sure to review three project applications before posting your own.

I will review code and functionality in several days. Assign.

in several days? - assign if you do it now. don't block earlier reviews....

Thanks for contributing this project, tbenice.

I'm not incredibly familiar with Commerce, but I glanced over your code, and it seems well-ordered. I'm looking forward to seeing what more experienced Commerce users thinks, so I added Commerce's review tag.

* The only things that seemed worth fixing are linked in #2 with the ventral review. Hence the 'needs work' change.
* Would it be possible and/or more desirable to integrate this directly in commerce_file or commerce_product_bundle?
* If you could provide a feature package that demonstrates this functionality, I'd be happy to test it out.

Thank you very much for contributing - I hope I'm able to support your effort with this review :)

I'm not to familiar with the commerce_file module an thus can't provide any statement if it would be applicable to include this functionality there.
I'd suggest to join the commerce IRC channel #drupal-commerce and ask there.

However, I found some other points that should be taken care before this can become a full project.
The automated tests on ventral.org came up with some notices (or see the attached pdf).
Further I'd suggest to move the definition of the rules actions as well as the callbacks into a dedicated file as rules api documentation says: hook_rules_action_info: This hook is required in order to add a new rules action. It should be placed into the file MODULENAME.rules.inc, which gets automatically included when the hook is invoked.
And then there's the implementation of hook_enable - this hook should be implemented in the module's .install file.
This also brings up the question what happens if the module is disabled / uninstalled. Are there no necessary cleanup actions?

That's all I, no biggies :)

@tbenice I just talked with Bojan, he told me he will take a look into this. I just sent him the link to this issue.

Hello @tbenice
You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch.

You still need to fix the issue listed on http://ventral.org/pareview/httpgitdrupalorgsandboxtbenice1690422git:

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Major coding standards / best practice issues

An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.

You can find the results of the automated report at http://ventral.org/pareview/httpgitdrupalorgsandboxtbenice1690422git.

One additional question: in hook_install() you are calling commerce_file_configure_line_item_type() if module commerce_line_item is enabled. Is there a way to check this later? E.g. if commerce_line_item is installed after your module the function does not seem to be called.

Only things i like to mention is about the installation and configuration.

Your module depends on these modules, please mention it in your description.

http://drupal.org/project/commerce_product_attributes
http://drupal.org/project/commerce_file
http://drupal.org/project/commerce_product_bundle

Also more description about how to use your module would be great, i know it is the most boring part but necessary.

I read through the comments, the project issue queue, and glanced over the code. It appears that the module has reached an acceptable state, the requested changes have been made, and the code is confirmed to work.

Setting to rtbc. For the remaining code improvements, please use the project's issue queue.

Thanks for your contribution, tbenice!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Thanks to the dedicated reviewers as well.