Finer permission for revision edit [#174900]

In my case, I need users to be able to edit revisions, even if they do not have 'administer nodes' permission. The attached patch makes this possible. And its a reasonable change, considering my user can access the edit tab to edit the current revision. It's reasonable to let them edit the latest revision, too.

This work sponored by medem.com.

Comment	File	Size	Author
	revision_edit.diff	540 bytes	Dave Cohen

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Leeteq CreditAttribution: Leeteq commented 2 April 2008 at 17:52

I hope this will be implemented in the next stable release.

Comment #2

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 6 April 2008 at 10:34

How about testing it rather than hoping? ;)

Comment #3

Anonymous (not verified) CreditAttribution: Anonymous commented 19 August 2008 at 10:46

I implimented the code above as it seemed to do what i wanted. but was unable to see the block of Pending revisions

I set revision moderation for Content type X and granted my user edit content type X permisions and view revisions

I changed the last line of following code which then provided the block to this user based on view revisions rather than administer nodes

/**
 * Implementation of hook_block().
 */
function revision_moderation_block($op = 'list', $delta = 0, $edit = array()) {
  if ($op == 'list') {
    $blocks[0]['info'] = t('Pending revisions');

    return $blocks;
  }
  elseif ($op == 'view') {
    $block = array();

    if (user_access('administer nodes')) {

/**
 * Implementation of hook_block().
 */
function revision_moderation_block($op = 'list', $delta = 0, $edit = array()) {
  if ($op == 'list') {
    $blocks[0]['info'] = t('Pending revisions');

    return $blocks;
  }
  elseif ($op == 'view') {
    $block = array();

    if (user_access('view revisions')) {

I am not sure exactly if this is thr correct way of doing things as i am still getting to grips with permissions. If a users view revisions permission is applicable only to those edit content types that have permission granted it seems ok

Comment #4

add1sun CreditAttribution: add1sun commented 19 December 2008 at 23:02

Version:	5.x-1.x-dev	» 6.x-1.x-dev
Category:	bug	» feature

this is a feature request and should be rolled against the 6 branch now

Comment #5

mdupont

French

Switzerland

CreditAttribution: mdupont commented 10 February 2009 at 15:16

Subscribing. This is a must have for designing custom moderation processes, where only some roles (which shouldn't have the "administer nodes" permission) are able to edit pending revisions.

Comment #6

stacysimpson CreditAttribution: stacysimpson commented 13 February 2009 at 14:34

We need this ability on D6 as well. Any idea how to adjust the latest '6.x-1.0-alpha1' version?

Comment #7

ilfelice CreditAttribution: ilfelice commented 13 February 2009 at 18:55

Comment #8

stacysimpson CreditAttribution: stacysimpson commented 18 February 2009 at 17:50

Well, after getting some time to look into this deeper. Turns out that the original requested change in 'revision_edit.diff' has been integrated into the 6.x 1.0-alpha1 release.

However, we were running up against two issues:
1. Only users with 'administer nodes' can choose whether or not to create new revisions. We wanted to restrict this capability to particular node types and roles. Reference this feature request / hack: http://drupal.org/node/376385.
2. Also, revision_moderation seems to let users modify revisions when they do not have rights to modify the node itself. We made the following change in 'revision_moderation_nodeapi'
from:
$access_update = user_access('revert revisions');
to:
$access_update = user_access('administer nodes') || (user_access('revert revisions') && node_access('update', $node));