This is a lightweight mobile detection based on the Mobile_Detect.php library.

This module is intended to aid developers utilizing mobile-first and responsive design techniques who also have a need for slight changes for mobile and tablet users. An example would be showing (or hiding) a block or content pane to a particular device.

This module is not intended (and never will be enhanced) to provide theme switching or redirection; other modules already provide this functionality.

It is inteded to have a smaller footprint than http://drupal.org/project/browscap and http://drupal.org/node/1793534 demonstrates that this module provides features that browscap doesn't. It is not inteded to replace http://drupal.org/project/mobile_tools, but serve as an alternate for users who don't need all of those features.

The module is currently for Drupal 7 only. If there is interest, I will backport to Drupal 6. I will also make this available for Drupal 8 once I am familiar with the API changes.

Project Link: http://drupal.org/sandbox/matthew.donadio/1780496
Git Link: http://git.drupal.org/sandbox/matthew.donadio/1780496.git
Git Clone: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/matthew.donadio/1780496.git mobile_detect

Initial Reviews:
http://drupal.org/node/1800682#comment-6559318
http://drupal.org/node/1784562#comment-6559448
http://drupal.org/node/1784144#comment-6563066

Followup Reviews (per comment #5):
http://drupal.org/node/1804856#comment-6572626
http://drupal.org/node/1222472#comment-6573844
http://drupal.org/node/1693054#comment-6577790

Comments

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented

I have read through the project application checklist, and am having trouble with moving from a master branch to a version branch. I am working to figure out what is wrong (I am an svn user and trying to get up to speed with git).

I will also work on reviewing other project and will list them here.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Issue summary: View changes

Made project and git links more obvious, and similar to others in the queue

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Issue summary: View changes

Started reviewing.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Issue tags: +PAreview: review bonus

Addressed Comment #1 and think I have a good candidate for review.

jibus’s picture

jibus commented

Hello !

Cool module !

Just a few minor notices:

- You could mention the url where to get the library in the error message set at /admin/reports/status. (also in your error message, you mean README.txt no ?)
- Librairies is not required but you set the default library path in sites/all/libraries/Mobile_Detect. Since the user doesn't use the libraries module, why not set the default plugin path to sites/all/modules/mobile_detect/ ? You can also him choose the path.
- Could you provide one example with tablet detection ?
- When the plugin is found, in /admin/reports/status, the description message is just the path, maybe you can merge this in the title: Fould (%path).

I let the module status to "needs review" since i notice no bug.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented

Thanks for the feedback.

Improving the status report / error reporting is a good idea: http://drupal.org/node/1804794

I am not using a UI for the path because too many users fat-finger it, or don't know what it should really be. Keeping the default location out of the module itself makes upgrading the module easier, and also is becoming a best practice even when Libraries API isn't being used.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus

manual review:

  1. Project page: you should not only list similar modules, you should also describe briefly what makes them different and in what situation one might choose the other.
  2. mobile_detect_registry_files_alter(): ah, you need that so that the lib class can be autoloaded, right? Please add a comment.
  3. "$module_path = drupal_get_path('module', 'mobile_detect');": use dirname(__FILE__) instead?

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented

Project page: you should not only list similar modules, you should also describe briefly what makes them different and in what situation one might choose the other.

Done.

mobile_detect_registry_files_alter(): ah, you need that so that the lib class can be autoloaded, right? Please add a comment.

Done

"$module_path = drupal_get_path('module', 'mobile_detect');": use dirname(__FILE__) instead?

This would use the full pathname and not the one relative to DOCROOT. I eliminated the need for thi, and have an open issue (http://drupal.org/node/1804794) to improve error/status reporting.

Will review over the next day or two.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Issue summary: View changes

Added third review

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Issue summary: View changes

Reviewing again.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Issue summary: View changes

Another review.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Issue tags: +PAreview: review bonus

Did another round of reviews, linked in sumary.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

no objections for more than a week, so ...

Thanks for your contribution, matthew.donadio!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Third review in sound two.