A Drupal 6 module:

Collapsed Text and Text area is a composite collapsible field for CCK (Content Construction Kit). This field is collapsed by default.

Primary use was to built feature lists but you can change sub-fields labels as you like. For example, it could be used to build collapsed :
- Definition lists (dl)
- FAQ (Frequently Asked Questions)
- Criteria

CTT was built to avoid mistakes made by beginners using Collapse Text. Advanced users may use Collapse Text which is an input filter available in a textarea field.

CTT requires CCK as it provides a new field for CCK.

CTT 6.x-1.x supports Views 2.

Installation is easy and you can get details in README.txt.

Project page: http://drupal.org/sandbox/chipway-drupal/1779910

GIT Repository details: git clone --recursive --branch 6.x-1.x chipway-drupal@git.drupal.org:sandbox/chipway-drupal/1779910.git

Reviews of other projects
http://drupal.org/node/1687552#comment-6609414
http://drupal.org/node/1191486#comment-6613068
http://drupal.org/node/1811646#comment-6609554

More reviews of other projects
http://drupal.org/node/1191486#comment-6651958
http://drupal.org/node/1799766#comment-6652836
http://drupal.org/node/1813774#comment-6660338

CommentFileSizeAuthor
CTT_add-new-content-view-collapsed.png19.63 KBchipway
CTT_add-new-CCK-field.png27.72 KBchipway

Comments

developmenticon’s picture

developmenticon commented

Review of the 6.x-1.x branch:

  • Remove the translations folder, translations are done on http://localize.drupal.org
  • Remove all old CVS $Id tags, they are not needed anymore.

    translations/ctt.pot:1:# $Id$<br>
translations/fr.po:1:# $Id$<br>
chipway’s picture

chipway commented

@developmenticon,

Thanks for your review.

I striped $Id$ in translation files.

For the first point, I have hundreds of .po files in a single d6 updated install. So I am wondering why should we use only http://localize.drupal.org for translations?
Do you have more info or links about this new rule "don't put .po file in module" ?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus

Thank you for your reviews. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

manual review:

  1. Translations are done on localize.drupal.org so that you do not have to permanently commit translations and changes to them. Other users and translation admins can easily add translations without you being needed to contribute.
  2. _ctt_process(): empty function that could be removed?
  3. "notice: Undefined index: format in ctt.module on line 325.": Please enable PHP notices in your development environment. See http://randyfay.com/content/if-you-edit-php-code-please-work-enotice-turned

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

chipway’s picture

chipway commented
Status: Reviewed & tested by the community » Needs review

@klausi,

Thank you for you review and passing to RTBC.

I fixed points 2 and 3, and did more reviews, since the ones at the top:
http://drupal.org/node/1191486#comment-6651958
http://drupal.org/node/1799766#comment-6652836
http://drupal.org/node/1813774#comment-6660338

chipway’s picture

chipway commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +PAreview: review bonus

Oups, forgot to keep the RTBC status :(

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

no objections for more than a week, so ...

Thanks for your contribution, chipway-drupal!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

chipway’s picture

chipway commented
Status: Fixed » Reviewed & tested by the community

@klausi,

Thank you very much for your reviews and this step up. I will try to keep involved in project reviews.

Thanks to all CTT's reviewers for your help.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

This application is finished, marking as fixed. See also http://drupal.org/node/532400

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Added more reviews.