Workbench Moderation OG

Hi,

The code have following errors

FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 6 WARNING(S) AFFECTING 6 LINE(S)
--------------------------------------------------------------------------------
1 | WARNING | Line exceeds 80 characters; contains 215 characters
3 | WARNING | Line exceeds 80 characters; contains 119 characters
4 | WARNING | Line exceeds 80 characters; contains 135 characters
6 | WARNING | Line exceeds 80 characters; contains 165 characters
7 | WARNING | Line exceeds 80 characters; contains 134 characters
11 | WARNING | Line exceeds 80 characters; contains 276 characters
11 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...s/all/modules/pareview_temp/test_candidate/workbench_moderation_og.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
7 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...all/modules/pareview_temp/test_candidate/workbench_moderation_og.module
--------------------------------------------------------------------------------
FOUND 17 ERROR(S) AFFECTING 13 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | You must use "/**" style comments for a file comment
4 | ERROR | Missing function doc comment
12 | ERROR | Whitespace found at end of line
14 | ERROR | Inline control structures are not allowed
23 | ERROR | Spaces must be used to indent lines; tabs are not allowed
23 | ERROR | Line indented incorrectly; expected 6 spaces, found 5
24 | ERROR | Spaces must be used to indent lines; tabs are not allowed
24 | ERROR | Line indented incorrectly; expected 8 spaces, found 6
25 | ERROR | Closing brace indented incorrectly; expected 5 spaces, found 6
27 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
27 | ERROR | No space found after comma in function call
28 | ERROR | Line indented incorrectly; expected 8 spaces, found 10
30 | ERROR | Closing brace indented incorrectly; expected 4 spaces, found 3
35 | ERROR | Missing function doc comment
49 | ERROR | Spaces must be used to indent lines; tabs are not allowed
49 | ERROR | Closing brace indented incorrectly; expected 2 spaces, found 1
51 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

Regards
Alok

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

There are some minor issues in your code.
You can test your code here -
http://ventral.org/pareview/httpgitdrupalorgsandboxhernani1788510git

Project applications are tasks.

You need to set the status to "needs review" if you want to get a review.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

@hernani,

Here some results of my Manual Review:

PAReview online or local did not find any problems.

You could enhance your Project page by following "Tips for a great project page" (http://drupal.org/node/997024)

Lines' length: In workbench_moderation_og.module, there are too long lines like 39, 58, 62, 67, 129. You coud make them more readable by going to next line.

Length and functions number: You code has 138 lines and 4 functions. It seems short in regard of the application process.

Hope this helps.

@hernani,

You may enhance your README.txt which messes in my netbeans editor.

@hernani,

Project page is more comprehensive and README.txt and workbench_moderation_og.module more easy to read.
Thks.

I feel your module is useful in the defined use case, but I am not enough experienced about reviews to tell is only 4 functions is a blocking point or not.

I have not enough time right now to install and test the module. Could you ask someone else to test it and give feedback on it?

Hello @hernani,

First of all, that's a great idea for a module.

I have some questions regarding your project:
- why did you create git branch 7.x-2.x while there is no branch 7.x-1.x ?
- the link git clone http://git.drupal.org/sandbox/hernani/1788510.git workbench_moderation_og doesn't work now, maybe you could update the link to the current git repository on http://drupal.org/sandbox/hernani/1788510 ?
- I think there is OG 7.x-2.x branch, not 7.2-X Branch, maybe you could update README.txt and dependencies on http://drupal.org/sandbox/hernani/1788510
- what is the specific reason for adding dependency dependencies[] = og_ui in the .info file while there is already a dependency to the og added ? Users won't be able to turn off the og ui after enabling the module.

@hernani,

- git clone http://git.drupal.org/sandbox/hernani/1788510.git workbench_moderation_og works now, my mistake, sorry
- I think you need at least one more function in your code to satisfy the minimal requirement for review step 2.2

Review based on http://drupal.org/node/1587704

1. Basic application checks
1.1 Ensure your application contains a repository and project page link. - OK
1.2 Ensure your project is not a duplication. - OK
1.3 Ensure you don't have multiple applications. - OK

2. Basic repository checks
2.1 Ensure the repository actually contains code. - OK
2.2 Ensure you are working in a version specific branch. - OK (http://drupal.org/node/1015226)
2.3 Ensure your project contains a minimum of handwritten code. - FAILED

We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed, that means we can't make sure you're able to write secure code and use Drupal's APIs correctly.
If this is the case, we can't approve you as git vetted user (giving you the permission to create full projects). Either we can see that you have the needed knowledge by other contributions within the drupal community or we can promote it to a full project manually.

3. Security Review

3.1 Ensure the project does not contain any security issues. - (http://drupal.org/writing-secure-code) - SKIPPED

4. Licensing checks

4.1 Ensure the repository does not contain a ‘LICENSE.txt’ file. - OK
4.2 Ensure the repository does not contain any 3rd party (non-GPL) code. - OK

5. Documentation checks

5.1 Ensure the project page contains detailed information. - OK

Project pages should be helpful; there are literally thousands of modules, themes and installation profiles and site builders need a clear way to understand what a project does. Please have a look at the tips for a great project page, you may also use HTML-tags for better structure.

5.2 Ensure the repository contains a detailed README.txt. - OK
5.3 Ensure the code contains a well-balanced amount of inline-comments. - OK

6. Coding standards and style

6.1 Run an automated review and ensure there are no major issues. - SKIPPED

7. API and best practices Review

7.1 Ensure you are using Drupals API correctly. - SKIPPED

@hernani,

#10, good to hear from you too!

Tried to use the module:

I enabled it hru drush;
entityreference was enabled successfully. [ok]
og was enabled successfully. [ok]
workbench_moderation_og was enabled successfully. [ok]
workbench_moderation was enabled successfully. [ok]

On the page "admin/config/workbench/moderation", I clicked on the first line link (admin/config/group/permissions) and went to "admin/config", so There an issue with your path. I am a bit lost.

Could you fix it?

@hernani,

Drush enabling should work and enable all required modules. Now og_ui is not enabled.

Could you add og_ui as a dependency in .info?

Could you also update the project page and REDAME.txt for required modules?

Please don't post the output of automated review tools like pareview.sh inline in a comment, as it just clutters the issue. Better add it as .txt attachment instead.

manual review:

• "/* get group nodes */": C style comments (/* */) and are discouraged within function bodies, use "//" instead.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

no objections for more than a week, so ...

Thanks for your contribution, hernani!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Unsubscribe from: Wiki page posts in Code Review of Full Project Ap