Chinese Social Networks Authentication (CSNA)

Welcome,

please get a review bonus first. Link to sandbox does not work in the issue summary.

Review:

Hi please remove your manster branch.

1. All varaible names should be prefixed with your module name.
2. Same as the functions
3. All files should end with new line.
4. please see : http://ventral.org/pareview/httpgitdrupalorgsandboxmiloyz1787440git for more coding standards error.

These errors should be fixed;

Kind regards.

change git repository URL

No problems found in automatic review from ventral
http://ventral.org/pareview/httpgitdrupalorgsandboxmiloyz1787440git

Function to handle the title seems to not use the provider argument
in csna.module

function csna_redirect_title($provider) {
 return t('CSNA');
}

This comment seems wrong

/**
  61  * Implements csna_providers().
  62  */
  63 function csna_provider_load($provider_id) {

Function function csna_admin_settings() { could probably be moved to another file (csna.admin.inc), to be called only when needed.

I was not able to test the module but its architecture looks correct and expandable.

Manual review:

csna.module:

Line 50: Remove this if it's not needed, don't leave blocks of code commented out without explanation.

Line 66: Need to key if array key is valid using isset() and return FALSE if it does not exist. Current implementation would raise notices if invalid keys were entered in the URL.

README.txt

Needs to give a clear description of the module's purpose and installation/usage guidelines. Not 100% sure on the policy but I'd imagine this should be in English. Don't asume all admins implementing this module will be native speakers.

Hi miloyz,

The code are perfect. And I think it is a good example of making use drupal hook mechanism.
Just a little concern about code line 177 in csna.module file as below:
$form['submitted']['user_login_block']['#suffix'] = theme('csna_providers', $providers);
I know here you need to add the provider list in login block via '#suffix'. But if the '#suffix' is not empty,
that means if any other modules already use this approach to alter the login block, then your code would
conflict with theirs.

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/README.txt
  --------------------------------------------------------------------------------
  FOUND 1 ERROR(S) AND 2 WARNING(S) AFFECTING 3 LINE(S)
  --------------------------------------------------------------------------------
    1 | WARNING | Line exceeds 80 characters; contains 88 characters
   13 | WARNING | Line exceeds 80 characters; contains 117 characters
   19 | ERROR   | Files must end in a single new line character
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. "define('OAUTH2', 'oauth2');": all constants that your module defines must be prefixed with your module's name to avoid name collisions.
2. csna_provider_load(): this is not a hook? So it should be documented as normal function? See http://drupal.org/node/1354#functions . Same for all other functions that are not hooks.
3. csna_hook_info(): why is this needed? You do not use $module.$group.inc files for your providers anywhere?
4. csna_execute_user_login(): why do you need to write the global form state here? Just passing a local variable should be enough? Please add a comment.
5. csna_providers(): please remove the confusing PayPal comments and replace them with something useful.

Otherwise looks nearly ready to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

manual review:

1. csna_execute_user_login(): doc block is wrong. Same for csna_providers().
2. "module_invoke($module, 'csna_provider_info')": Hooks that are provided by a module should be documented in MODULENAME.api.php, see http://drupal.org/node/161085#api_php
3. theme_csna_providers(): doc block is wrong, see http://drupal.org/node/1354#themeable

But that are not application blockers, so I guess this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

No objections for more than a week, so ...

Thanks for your contribution, miloyz!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.