Posted by damiankloip on November 3, 2012 at 7:13pm
10 followers
| Project: | Views |
| Version: | 7.x-3.x-dev |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | BADCamp2012UX, Novice, Usability, VDC |
Issue Summary
So currently we have this code determining what is displayed for an empty path in the edit UI.
<?php
$path = strip_tags('/' . $this->getOption('path'));
if (empty($path)) {
$path = t('None');
}
?>Because a '/' is always appended to the path, it's never empty. So for an empty path we are just left with the '/' character.
Comments
#1
Here is a patch with the text changed to 'No path defined', based on the Views usability study feedback.
We should probably add a test for this too.
#2
This looks perfect
I guess screenshots would show how great this actual improvement is.
#3
Yhea, this is a bit of an unwritten rule. But we generally really like to have screens before UX improvements are RTBC, just to provide that last check.
I would love if we can actually not use "defined", and just say "No path is set"
#4
#5
Sounds good to me!
#6
#7
Fine, here is one.
#8
:)
#9
Too late now, but +1 from me. This came up in 2 of my sessions. Plus '/' is a tiny target area!
#10
Is this worth adding a test for per #2?
#11
Let's do it, you never know.
#12
Committed/pushed to 8.x, thanks!
#13
Will this get ported to 7.x?
#14
No reason it cant
#15
#16
Good point! That is nothing really complicated to implement.
#17
Drupal 7 backport ready for review.
#18
Let's not backport the test unless someone is willing to take the effort.
+++ b/plugins/views_plugin_display_page.incundefined@@ -251,9 +251,13 @@ class views_plugin_display_page extends views_plugin_display {
+ ¶
We shouldn't introduce that whitespace here.
#19
Thanks for spotting that. I've updated the patch to remove the extra whitespace. Patch applies without warning now.
#20
Thanks. Its seems to work ok for me, it applies and works fine without any warnings or errors.
#21
Awesome! Committed and pushed
#23
Automatically closed -- issue fixed for 2 weeks with no activity.