Download & Extend
Date » Issues

exposed grouped filter for date not working

Posted by tchurch on December 29, 2012 at 11:51am
Project:Date
Version:7.x-2.6
Component:Views Filter
Category:bug report
Priority:major
Assigned:Unassigned
Status:needs work

Issue Summary

I've already raised this on the Views module but they say it might be a problem with the date handlers.
#1764902: exposed grouped filter for date not working

I have an exposed "grouped" filter for a date field (field has start and end dates but I expose the start date).
I have 2 options:
- Any -
"Future Events", greater or equal to a relative date "now".

When I preview the view and test the filter, it works.
When I try it on the actual page, it's not working.

Login or register to post comments

Comments

#1

Posted by ali_b on January 9, 2013 at 9:08am

Any updates? We are running a pet adoption website and we would love to have an age filter ...

#2

Posted by windmaomao on March 3, 2013 at 6:58pm

i don't see the input box for entering value either when using grouped exposed filter.

#3

Posted by kclarkson on March 19, 2013 at 3:01pm

I am also patiently waiting a fix for this,. I am not provided with a box to enter relative dates.

#4

Posted by sinn on March 29, 2013 at 11:54am

My date filter (I made it as described on http://drupal.org/node/1764902#comment-6732320)

  $handler->display->display_options['filters']['field_recall_date_value']['id'] = 'field_recall_date_value';
  $handler->display->display_options['filters']['field_recall_date_value']['table'] = 'field_data_field_recall_date';
  $handler->display->display_options['filters']['field_recall_date_value']['field'] = 'field_recall_date_value';
  $handler->display->display_options['filters']['field_recall_date_value']['operator'] = '<=';
  $handler->display->display_options['filters']['field_recall_date_value']['exposed'] = TRUE;
  $handler->display->display_options['filters']['field_recall_date_value']['expose']['operator_id'] = 'field_recall_date_value_op';
  $handler->display->display_options['filters']['field_recall_date_value']['expose']['label'] = 'Recall date';
  $handler->display->display_options['filters']['field_recall_date_value']['expose']['operator'] = 'field_recall_date_value_op';
  $handler->display->display_options['filters']['field_recall_date_value']['expose']['identifier'] = 'field_recall_date_value';
  $handler->display->display_options['filters']['field_recall_date_value']['is_grouped'] = TRUE;
  $handler->display->display_options['filters']['field_recall_date_value']['group_info']['label'] = 'Recall date';
  $handler->display->display_options['filters']['field_recall_date_value']['group_info']['identifier'] = 'field_recall_date_value';
  $handler->display->display_options['filters']['field_recall_date_value']['group_info']['group_items'] = array(
    1 => array(
      'title' => 'Current',
      'operator' => '<=',
      'value' => array(
        'value' => array(
          'value_choose_input_type' => 'relative',
          'value' => NULL,
          'default_date' => 'now',
        ),
        'min' => array(
          'min_choose_input_type' => 'relative',
          'min' => NULL,
          'default_date' => 'now',
        ),
        'max' => array(
          'max_choose_input_type' => 'relative',
          'max' => NULL,
          'default_to_date' => 'now',
        ),
      ),
    ),
    2 => array(
      'title' => 'Future',
      'operator' => '>',
      'value' => array(
        'value_group' => array(
          'value_choose_input_type' => 'relative',
          'value' => NULL,
          'default_date' => 'now',
        ),
        'min_group' => array(
          'min_choose_input_type' => 'relative',
          'min' => NULL,
          'default_date' => 'now',
        ),
        'max_group' => array(
          'max_choose_input_type' => 'relative',
          'max' => NULL,
          'default_to_date' => 'now',
        ),
      ),
    ),
  );
  $handler->display->display_options['filters']['field_recall_date_value']['default_date'] = 'now';

Filter works in view preview only.

Group filter values from exposed filter aren't processed correctly. Attached patch fix it (it isn't very good decision, but I think maintainer will understand where bug is).

AttachmentSizeStatusTest resultOperations
date_expose_group_filter.patch1.03 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch date_expose_group_filter.patch. Unable to apply patch. See the log in the details link for more information.View details | Re-test

#5

Posted by sinn on March 29, 2013 at 12:07pm
Status:active» needs review

#6

Posted by System Message on March 29, 2013 at 12:10pm
Status:needs review» needs work

The last submitted patch, date_expose_group_filter.patch, failed testing.

#7

Posted by sinn on March 29, 2013 at 6:17pm
Status:needs work» needs review
AttachmentSizeStatusTest resultOperations
date_expose_group_filter.patch1.12 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch date_expose_group_filter_0.patch. Unable to apply patch. See the log in the details link for more information.View details | Re-test

#8

Posted by System Message on March 29, 2013 at 6:34pm
Status:needs review» needs work

The last submitted patch, date_expose_group_filter.patch, failed testing.

#9

Posted by windmaomao on April 3, 2013 at 3:30pm

sinn, can you explain a bit what you did and what bug you fixed ? because after i applied your patch, i still don't see the input box appear. Thanks a ton.

#10

Posted by sinn on April 8, 2013 at 7:17pm

with my patch exposed filter works not only in preview.
i didn't fix UI of settings page.

#11

Posted by kclarkson on April 9, 2013 at 12:35pm

if the UI wasn't fixed how were you able to enter anything in the fields ?

#12

Posted by sinn on April 13, 2013 at 5:28pm

http://drupal.org/node/1764902#comment-6732320 -> export views -> change settings -> import views.

#13

Posted by svajlenka on April 24, 2013 at 7:08pm

I was able to use (more or less) the same group filter as in #4, but when I needed to use this view not in preview *and* using ajax, I had to make the following modifications to the patch in #7 for it work appropriately. This patch includes the changes in #7.

AttachmentSizeStatusTest resultOperations
date-expose_group_filter-1876168-13.patch1.44 KBIgnored: Check issue status.NoneNone

#14

Posted by sinn on April 25, 2013 at 5:06pm

Check line 104 - you have changed meaning of "if" condition.

elseif (isset($this->options['expose']['identifier']) && !isset($_REQUEST[$this->options['expose']['identifier']])) {

#15

Posted by windmaomao on May 3, 2013 at 9:12pm

i'm pretty shocked when I see this bug is still not fixed or committed by the author. And the last updated developer version was from last year.

#16

Posted by windmaomao on May 4, 2013 at 2:51am

ok, maybe this has been fixed by date_views ? actually it's working without the above patch. see attached picture.

AttachmentSizeStatusTest resultOperations
Screen Shot 2013-05-03 at 10.48.34 PM.png102.49 KBIgnored: Check issue status.NoneNone

#17

Posted by kclarkson on May 5, 2013 at 3:19pm

@windmaomao

Two questions:

What version of date are u using ?
Did u test this with a custom date field that has a start and end date ?

My use case is for filtering events

#18

Posted by Murz on May 5, 2013 at 8:19pm

Confirm this issue with Views 3.7 and Date 2.6. Patch from #13 isn't solve the problem.
When I change manually group item type from 'offset' to 'relative' (export > change in text editor > import) - it saved correctly, but not work normally, dates are generated like date, not relative.

#19

Posted by CIsSharp on May 8, 2013 at 6:27pm

#18 confirmed. Not fixed yet in views 3.7 and date 2.6. :-(