Closed (fixed)
Project:
Webform
Version:
5.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
7 Nov 2007 at 17:24 UTC
Updated:
14 Dec 2023 at 07:31 UTC
Jump to comment: Most recent file
Comments
Comment #1
uberellis-dupe commentedI can confirm this. Multiple select fields (checkboxes) all export to CSV with value of "No". WebForm analysis displays the correct data.
Comment #2
quicksketchCritical is for issues that render the module inoperable. I'm not working on webform much these days but trying to keep the bugs down. I'd appreciate any patches that could be contributed to fix this problem
Comment #3
holydrupal commentedI have the same problem
Comment #4
matason commentedThe problem appears to be in components/select.inc
I've attached a patch, use at your own risk - comments appreciated :)
Drop the file select.inc.patch into webform/components/ and run patch < select.inc.patch
matason
Comment #5
holydrupal commentedI patched it but nothing changed!!
Comment #6
holydrupal commentedcould someone help us?
the select fields doesn't work in csv and table view.
Comment #7
holydrupal commentedanyone can fix this issue, please help us?
Comment #8
matason commentedOK, my original patch grouped all the values selected into a single cell (similar to the results table view), this patch should however fix it properly. Revert to the original select.inc before applying this patch.
Comment #9
holydrupal commentedstill some keywords in csv and table is the key not the label.
what I did:
replace the patched select.inc with the original one
replace the line
generate the csv
viewing the table view
Comment #10
kalee commentedthe patch code worked for me...
i replaced the line that said "-" in the patch code that matason gave us with the line that said "+".
Thanks to you!!!
Comment #11
jpsalter commentedThe suggested change in #8 worked for me.
Thanks!
Comment #12
suit4 commentedI'd like to confirm that the patch from #8 works as expected.
Very nice! Thank you!
Comment #13
holydrupal commentedbut it sadly didn't worked for me and I don't know why!
Comment #14
quicksketchThanks everyone for the great collaboration on this fix. Extra kudos to matason for coming up with the patch :D
I'm running through the queue this week and this'll be included in the 1.8 release. Thanks!
Comment #15
Bodo Maass commentedI still have this problem in 5.x-1.x-dev, so if the patch has indeed been committed in 5.x-1.8, it didn't work for me.
Comment #16
Bodo Maass commentedComment #17
Bodo Maass commentedI found that reversing the patch from #8 made it work for me again.
Line 431 of select.inc (from 5.x-1.x-dev) should be:
The patch from #8 changed this into if (in_array($item...
However, this is almost certainly problematic even if it might work in some cases. $item will be the translatable display name of the item, and that should not be used as key.
It seems that we have different uses cases here (check boxes, lists, radio buttons, and also items with or without display names). Could the people for whom the patch from #8 worked explain their use case?
For me, I used a checkbox with a display name. In that case the patch broke it.
Comment #18
matason commentedBodo Maass, is this working for you with 5.x-1.9? Looks like the check needed to be made against item and key...
Comment #19
richardatval commentedThanks Matason that solved it for me! You have saved me three hours of data entry thanks so much!
Comment #20
quicksketchBoth keys and items are being checked in the latest versions of 1.x and 2.x. Please open a new ticket for any new problems with this issue.