Scald Kitdigital

Looking good. Ventral.org only has one warning (http://ventral.org/pareview/httpgitdrupalorgsandboxddoak1913454git).

I'm guessing you call scald_kitdigital_player.tpl.php file in an iframe or something. I'd love to see you create nodes associated with each video. That way you can leverage Drupal's theme and block features to allow themers and content editors to implement these videos anywhere they need to.

Hi dDoak,

Why don't you put the description you wrote for the project application on your sandbox page ? It's a pity, because this one is better
"Scald Kitdigital is a Scald provider which allows users to add video hosted on the french Kigital Video platform : http://www.kitd.fr/.'

I don't know if it's a blocking point but Drupal's documentation says :

Lines containing comments (including docblocks) must wrap as close to 80 characters as possible without going over, with a few exceptions (noted in the Tag Reference below).

http://drupal.org/node/1354#drupal

As you said the code look similar to others submodules in Scald and looks good to me

manual review:

1. project page is too short, see http://drupal.org/node/997024
2. Same for README.txt, see http://drupal.org/node/447604
3. "variable_get('scald_kitdigital_appkey', '')": all variables used by your module need to be removed in hook_uninstall().

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to jthorson as he might have time to finally approve this.

Now actually assigning to jthorson.

Thanks for your contribution, dDoak!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.