[D7] Commerce Klarna Checkout

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxMaxOne1943442git

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and put yourself on the PAReview: review bonus high priority list. Then I'll take a look at your project right away :-)

I'm a robot and this is an automated message from Project Applications Scraper.

1. Please provide more details on the project page (see http://drupal.org/node/997024). You can copy details from your README.txt file.
2. Provide correct Git clone instruction in the Issue:
git clone http://git.drupal.org/sandbox/MaxOne/1943442.git commerce_klarna_checkout
3. Consider justifying tabs and indent in order to keep code well formatted. For example, in commerce_klarna_checkout.module on line 13:

  $items['commerce_klarna_checkout/payment/%commerce_order/%'] = array(
    'page callback' => 'commerce_klarna_checkout_process_payment',
    'access callback' => TRUE,
    'page arguments' => array(2, 3),
    'type' => MENU_CALLBACK,
  );

replace with

  $items['commerce_klarna_checkout/payment/%commerce_order/%'] = array(
    'page callback'   => 'commerce_klarna_checkout_process_payment',
    'access callback' => TRUE,
    'page arguments'  => array(2, 3),
    'type'            => MENU_CALLBACK,
  );

3. commerce_klarna_checkout.install:
- line 35: remove $t(), leave just:

$download_url = l('https://docs.klarna.com/en/downloads/php', 'https://docs.klarna.com/en/downloads/php');

added testing credentials

I'm not sure why there's a sleep() in commerce_klarna_checkout_redirect_form_validate(). In commerce_klarna_checkout_process_payment() you should sanitize/validate any values from the _GET string.

I'm not sure why Mobile-Detect would be required - you seem to be using it just to determine layouts and gui information. Perhaps this should be an optional component instead? If not present you could let the admin choose a default 'desktop' or 'mobile'.

Otherwise looks good, setting to needs work for the security problem.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Thanks for the updates, looks good. There are a few minor issues still reported at http://ventral.org/pareview/httpgitdrupalorgsandboxmaxone1943442git.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Code still looks good. Consider integrating with the Payment module - it will make your payment processor compatible with Commerce, Ubercart, and Webform all in one go.

Thanks for your contribution, MaxOne!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.