[D7] Scald: Datawrapper

You have some errors in code. See: http://ventral.org/pareview/httpgitdrupalorgsandboxpoukram1966660git

Hello poukram!

Thanks for contribute, review your module in to vental.org and fix errors.

Add README.txt to module.

http://ventral.org/pareview/httpgitdrupalorgsandboxpoukram1966660git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi poukram,

Few comments:
1. scald_datawrapper.info:
Please consider use .css on necessary pages if possible.
2. Why do you use within your fields many times "LANGUAGE_NONE", instead of relevant language? (example at .module file)

Your defined constants should start with SCALD_DATAWRAPPER_*. The note about LANGUAGE_NONE above is a good one, you're preventing your module from working with translations.

Minor issues though, the code looks fine.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/scald_datawrapper.module
  --------------------------------------------------------------------------------
  FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   199 | ERROR | Files must end in a single new line character
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. scald_datawrapper.info: php = 5.x is not necessary, Drupal 7 already depends on PHP 5.2.
2. scald_datawrapper.info: the "core" property is duplicated?
3. scald_datawrapper_library_alter(): why do you need this? Please add a comment.
4. I suspect there is an XSS vulnerability in scald_datawrapper_scald_prerender() where width and height are passed unsanitized to the theme function. Unfortunately I was not able to exploit this because I was not able to create a datawrapper atom. The example "weD23" resulted in "EntityMalformedException: Missing bundle property on entity of type scald_atom. in entity_extract_ids()". What does a datawrapper URL look like, where do I get it? Where do I get the ID? http://datawrapper.de/gallery/#/a4HH2 for example does not work. Please update your README.txt and/or project page.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Looking good, what's the dnd module in scald_datawrapper_library_alter() ?

----
Top Shelf Modules - Enterprise modules from the community for the community.

Thanks for your contribution, poukram!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.