Description:
Bootstrap Barrio is a sub-theme of the Bootstrap Theme, theme based on Twitter Bootstrap, a sleek, intuitive, and powerful front-end framework for faster and easier web development.
While Bootstrap Theme add Twitter Bootstrap functionallity, Bootstrap Barrio focus on layout flexibility and customization using theme parameters and the Skinr module.
- Layout is handle by Bootstrap.
- Two columns, with configurable widths.
- Fixed and fluid layouts.
- Responsive features turn on and off.
- Fixed and fluid layouts.
- Configurable header behavior, using Bootstrap "fixed to top".
- Any block could be defined as "modal" with one click using Skinr.
- Full screen width slider region.
- Skinr controlled, collapse, fixed, row, content and span over blocks.
- Flexible blocks layout using span over row defined regions.
Project location:
http://drupal.org/sandbox/hatuhay/1997362
git clone --branch master hatuhay@git.drupal.org:sandbox/hatuhay/1997362.git
Previous reviewers:
http://drupal.org/user/36762
http://drupal.org/user/262198
http://drupal.org/user/125473
Previous projects:
http://drupal.org/node/1291488
Moved to http://drupal.org/project/spanish due to timeless aproval to upload my project.
Comments
Comment #1
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxhatuhay1997362git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
hatuhay commentedObservations generated by pareview solved.
Comment #3
lexicon commentedHi,
I downloaded your theme and tested it in a fresh install I got the following errors:
Notice: Undefined variable: title in include() (line 11 of E:\wamp\www\drupaltheme\sites\all\themes\bootstrap_barrio\templates\block.tpl.php).
Notice: Trying to get property of non-object in drupal_alter() (line 1035 of E:\wamp\www\drupaltheme\includes\module.inc).
Notice: Trying to get property of non-object in drupal_alter() (line 1035 of E:\wamp\www\drupaltheme\includes\module.inc).
Notice: Trying to get property of non-object in drupal_alter() (line 1035 of E:\wamp\www\drupaltheme\includes\module.inc).
Notice: Undefined variable: title in include() (line 11 of E:\wamp\www\drupaltheme\sites\all\themes\bootstrap_barrio\templates\block.tpl.php).
Notice: Undefined variable: title in include() (line 11 of E:\wamp\www\drupaltheme\sites\all\themes\bootstrap_barrio\templates\block.tpl.php).
Notice: Undefined variable: title in include() (line 11 of E:\wamp\www\drupaltheme\sites\all\themes\bootstrap_barrio\templates\block.tpl.php).
Notice: Trying to get property of non-object in drupal_alter() (line 1035 of E:\wamp\www\drupaltheme\includes\module.inc).
Notice: Trying to get property of non-object in drupal_alter() (line 1035 of E:\wamp\www\drupaltheme\includes\module.inc).
Notice: Trying to get property of non-object in drupal_alter() (line 1035 of E:\wamp\www\drupaltheme\includes\module.inc).
Notice: Trying to get property of non-object in drupal_alter() (line 1035 of E:\wamp\www\drupaltheme\includes\module.inc).
This is the major issues that's need to be fixed
Thanks
Lexicon
Comment #4
hatuhay commentedThanks @lexicon,
I just did a clean installation and cannot replicate the error.
The strange thing is that "title" variable is a Drupal core standard variable, it is not generated on the subtheme.
I am updating a .info file to standarize with new bootstrap theme version 2.0, but this change has no relation with the source of your reported error.
Comment #5
develcuy commentedWhat PHP version and error_reporting settings do you both have? All those warnings are common in PHP 5.4, also use to appear on PHP 5.3 with weird error_reporting settings.
Comment #6
hatuhay commentedThanks Fernando @Develcuy, tested on PHP 5.3 and 5.4, with no issues.
Comment #7
medienverbinder commentedHi!
The details of your GIT repository in the Project Description is not correct i think...
Thus, the download works with git (anonymous), you'd have the following here:
=> git clone http://git.drupal.org/sandbox/hatuhay/1997362.git bootstrap_barrio
The error description of lexicon (#3) I get when I have the theme bootstrap not installed under sites/all/themes/
Manual review (Tested on PHP 5.3.18)
- Install a fresh drupal 7.22
- Upload Drupal Bootstrap Theme to sites/all/themes
- Upload Drupal Bootstrap Barrio Sub Theme to sites/all/themes
- Upload Skinr to sites/all/modules
- Enable Skinr
- Enable Bootstrap Barrio Sub Theme
- Add Content and played around with theme settings.
The theme works so far, but I get a Javascript error on the firebug delivered when I use CDN Theme-Settings to load in the bootstrap files
TypeError: a(...).on is not a function
http://netdna.bootstrapcdn.com/twitter-bootstrap/2.3.1/js/bootstrap.min....
Line 7
Your theme works also without the separate download of bootstrap. This property I still would write in the README.txt
Best regards.
Comment #8
medienverbinder commentedComment #9
hatuhay commentedThanks @medienverbinder.
Already made modifications to readme.txt.
Urge users to use CVN, this can be avoid once Twitter Bootstrap can be loaded via libraries, so do not give the option to download, eventhough bootstrap theme explain how to.
Cannot replicate your error, but as the code comes compressed all the code is line 7.
We have already the theme on working environments with the same configuration without errors.
Please check our business site www.df.pe, it shows no error.
Warm regards
Comment #10
kscheirerYou should remove Thumbs.db and img/Thunbs.db from the repo. I think the whole img/ directory can go, since it's empty aside from that file. Your README has a typo in "requiered".
Those issues are minor though, this theme looks ready to go.
----
Top Shelf Modules - Enterprise modules from the community for the community.
Comment #11
hatuhay commentedThanks @kscheirer minor changes done, just waiting for approval move sandbox to project.
Comment #12
kscheirerNo further action is required, but the best thing you can do is get a Review Bonus by reviewing other applications. That will get you to the top of the list of projects to get reviewed (and hopefully approved). Only manual reviews count, just using http://ventral.org is not enough.
----
Top Shelf Modules - Enterprise modules from the community for the community.
Comment #12.0
kscheirerAdded reviewed projects
Comment #13
mlncn commentedThanks for your contribution, hatuhay! You are now a vetted Git user. You can promote this to a full project.
When you create new projects (typically as a sandbox to start) you can then promote them to a full project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
And thanks to the awesome reviewers, including medienverbinder, lexicon, and kscheirer!
Comment #14
hatuhay commentedThanks man appreciated!!
Nice coding.
Alberto
Comment #15.0
(not verified) commentedAdd third manual review
Comment #16
laurapapaleo commentedHi,
I downloaded the Theme and I did all the necessary configurations (both bootstrp and barrio are in sites/all/themes) but I received always the following warning:
Notice: Undefined variable: title in include() (linea 11 di [...]/sites/all/themes/bootstrap_barrio/templates/block.tpl.php).
Can somebody help me?
Thanks in advance,
Laura