[D7] Remove Duplicates

Used check_plain on static messages, no need to do that.

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxdman1422586git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi, thanks for your contribution. I just reviewed your project:

First of all, you should define a correct git clone command. Took me some time to figure out which project to clone:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/virtuoworks/2005296.git

Line 172ff: No need to cast types on php variables.

UI suggestions:
* On the "Remove duplicates" form there should be a big message saying "Be careful, you might be losing data! I recommend doing a backup before using this module."
* Also there is no safety line, like a checkbox or a confirmation I have to click. Given the fact, that there are default values for all fields. If a user access the form and accidentaly hits enter, some of his nodes might be gone.
* Leading to the next issue: The module isn't really clear, which nodes will be deleted. Also it doesn't tell me what has been deleted afterwards.

I somehow posted this twice...

Verify that suggestions on #6 were done.

Couple of lines that cannot be translated on following function, description and title:

<?php
function remove_duplicates_menu() {

  $items['admin/config/content/remove_duplicates'] = array(
    'title' => 'Remove Duplicates',
    'description' => 'Delete Duplicate Contents',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('remove_duplicates_settings_form'),
    'access arguments' => array('administer remove_duplicates'),
    'type' => MENU_NORMAL_ITEM,
  );
  return $items;
}
?>

From users experience point of view I have a three suggestions:

• A hint to diferentiate each node, I will suggest date of creation/last edition, author
• The chance to delete the other duplicate.
• Look if nodes could be display in table format.

I will also suggest to use the watchdog function to leave registration of action.

Finnally, I suggest to evaluate using flags, views and VBO to reduce code on nodes handling.

Hello,
I tested the module and it works, but here are some points that I believe needs work.

First, it's not very clear "which duplicates" this module can remove. It could be comments, taxonomy terms, users, and other entities as well.

- Do not call theme_item_list function directly. Use theme('item_list', $variables) pattern.
- isset($form_state['storage']['confirm']) && $form_state['storage']['confirm'] can be replaced with empty($form_state['storage']['confirm'])
- I think it would better if we replace "cancel" buttons with a simple link.
- Consider replacing raw database calls to fetch nodes matching a specific field with EntityFieldQuery (doc)

I wish you all the best, and thank you for your hard work on this useful module!

PAReview: Individual user account

It seems you are using a non-individual account.
All user accounts are for individuals. Accounts created for more than one user or those using anonymous mail services will be blocked when discovered (see Get a Drupal.org account).

Can you confirm that the virtuoworks account is a single user? Please change your account information and enter your realname.

If you prefer, we can also promote this sandbox to a full project without granting you "git vetted user" status.

----
Top Shelf Modules - Crafted, Curated, Contributed.

• Why are you clearing messages in remove_duplicates_settings_form()? If there are some present, they are likely to be useful. Also in remove_duplicates_build_confirm_settings_form().
• The multiple comments about t() not being needed in watchdog is kind of excessive, maybe just the first time?
• Also, you don't need the last 3 parameters for watchdog if they are array(), WATCHDOG_INFO, NULL - those are the defaults anyway.
• The menu item has an access check for administer remove_duplicates but I don't see a matching hook_permission() declaration.
• The functions are just a big wall of text - that's mostly my problem, but I'm having trouble evaluating those.

Most of the code seems sane though. Needs work for the missing permission.

----
Top Shelf Modules - Crafted, Curated, Contributed.

You don't need to list PHP >= 5.2.0, Drupal 7 already requires PHP 5.2.5.
Good project page.
Since this is a D7 module, you can probably remove the references to CCK fields.

Thanks for the updates, this looks good to me!

----
Top Shelf Modules - Crafted, Curated, Contributed.

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, Sami Radi!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.