With the new weblink module the visit link does not work anymore.

greetings

MM

CommentFileSizeAuthor
#14 weblink.module_1.patch397 bytesmgifford
Tag1 supports Drupal development!Tag1 logo

Comments

Mad Maks’s picture

this error is in my log when somebody tries to viit a link in the list

Location	/index.php?q=weblink/goto/16
Message	      array_merge() [function.array-merge]: Argument #1 is not an array in                       d:\www\stichtingbacu.nl\www\includes\menu.inc on line 351.
Mad Maks’s picture

i only have this problem at a site that uses php 5, an othet site that is running on a older php version has no problem

Bèr Kessels’s picture

Thanks for reporting. PHP5 is very strict about arrays ans objects . will look into this later.

Mad Maks’s picture

what is the status?

Bèr Kessels’s picture

no change yet. but this week the links bundle will be released. look out for that :)

ron_mahon’s picture

What is the name of the links bundel? I cant find it.
Thanks

Bèr Kessels’s picture

It does not yet exist.

mahcsig’s picture

I got mine to work by making the 'callback arguments' in weblink_menu an array like this:

'callback arguments' => array(arg(2)),

don't know if this breaks anything else, but it seems to work for me

ron_mahon’s picture

Ber
I am getting the same error at the top of the screen.

Warning: array_merge() [function.array-merge]: Argument #1 is not an array in W:\www\inmrc\includes\menu.inc on line 351.

Using PHP5, Drupal 4.6.3, and weblink from Head

Do you think the error is in the weblink module?
Or the menu.inc file?
Or Both?
Thanks
Ron

Bèr Kessels’s picture

the problem is almost certainly in weblink module.

19th’s picture

I have replaced $arguments = array_merge($arguments, explode('/', $arg));
with $arguments = array_merge((array) $arguments, explode('/', $arg));
in menu.inc and it works ok.

Timotheos’s picture

Any chance some of you are using the article module to create a directory of web links like I am?

I found that if I change the article.module line 102 to

$items[] = array('path' => 'article', 'title' => t('Article listings'), 'callback' => 'article_page', 'callback arguments' => array(arg(2)), 'access' => user_access("access content"), 'type' => MENU_CALLBACK);

Then the menu.inc on line 351 error goes away.

dumell’s picture

I followed the advice by 19th (in #11) and changed line 351 in menu.inc and now weblinks work again. Weblinks stoped working when we moved Drupal 4.6.4 from one hosting company to another and it turns out the old one used PHP4 and the new one PHP5. I had not thoguht about this difference before as Drupal seemed to work in general, this is the only problem so far that we have run into because of PHP5.

mgifford’s picture

FileSize
397 bytes

The weblink patch worked for me.

mgifford’s picture

Status: Active » Needs review
Bèr Kessels’s picture

Status: Needs review » Closed (won't fix)

Thanks you for your work. But CVS is no longer maintained. Everythnig has moved over to links.http://drupal.org/node/24719