Interesting.
I've had something like this in my private util library for a while, and went looking for a module to finally release it to last week.
It's now proposed but not yet commited to edit_term.module.
I can't see a lot of difference between what we are doing here.

Just a cross-reference FYI.

Comments

OliverColeman’s picture

OliverColeman commented

Hehe, interesting indeed, I feel that Drupal has been crying out for this functionality for a long time... :)

I'm not sure what would be the best way to merge these modules. I was thinking that this module is very small and might be better suited being part of a general utilities module, but edit_term doesn't seem to be that (simply because of its name). So the two options I can see are:

  1. Perhaps yet another module could be created for (small) taxonomy related modules (assuming one doesn't exist already, pretty sure one doesn't)
  2. Integrate them all with an existing general purpose utilities module.

Perhaps modules like http://drupal.org/project/primary_term could also be merged into a taxonomy utils module (I'm guessing this one isn't too big). We could contact authors of other such modules to do a round up...

What do you think?

dman’s picture

dman commented

Well, the general utilities library you are looking for is probably tweakbox. Which is where I was going to go before I decided that "edit_term" was the best name for what I was doing, and I had 3 enhancements that were all just about the term UI. In dev I was calling it 'termedit' :)
So I felt like dumping all that functionality on that existing module.
I feel it's a good enough place to put your #1 idea. I don't think agaric will mind. The existing edit_term module is 1 whole function long ;-)

I think that "taxonomy term menu" is a bit of a mouthful, especially when directly up against the other handful of taxonomy menu mods ;-). I only found it by accident in the updates, looked at it and went ... huh? Who's been looking over my shoulder?

.dan.

OliverColeman’s picture

OliverColeman commented

Yes, :) taxonomy_term_menu (TTM) is a bit of a mouthful, but I had to differentiate from the existing automated menu modules and still have it be descriptive. I definitely don't propose lumping all the little taxo utils under TTM...

The general utilities module I was thinking of is http://drupal.org/project/util

Yes, perhaps edit_term is a generic enough name (it could even be re-interpreted as editing the functionality of terms... :))

I wish you'd shared your term menu code sooner :) I like the look of the interface better than mine I think, the checkbox for enabling/disabling the menu item is much better than looking to see if the title field is non-empty and then later providing a checkbox to delete it (I only modified the code used to add menu items for nodes to make it work for terms, then decided against modifying the way it works to keep it consistent with the nodes menu form).

So, I agree with putting it all in edit_term. When this is done I'll modify this project description to tell people to use edit_term which now has the same functionality. And add some extra features to edit_term and the menu code that I'd like to see (integration with http://drupal.org/project/taxonomy_manager). :)

dman’s picture

dman commented

OK, let's go there then. I've left a note for Agaric.
I guess the old delete checkbox sorta evolved/mutated into the node edit form as we see it today. But I built my functionality forward, thinking "how to enable this option?" ... before copying and pasting the rest of the code from the menu.module :)

Thinking about it, this layout should probably be thrown back at menu.module ... if it's not already there in D6.

Yes, I was about to mention taxonomy_manager :-} ... but got scared. Lets leave that be for a bit ;-)

.dan.

mlncn’s picture

mlncn commented

If dman's patch does what you want, please review it and I'll commit it.

Agaric's happy to add functionality to edit_term (that doesn't add a database table) or to merge it into another module, preferably that's taxonomy specific and doesn't create any new tables (there's value in being targeted and light). And certainly core is the best home for this sort of basic usability aid!

Also: a non-tabbed 'edit term' link seems to be in D5 branch HEAD, or maybe I'm losing my mind. I can't find where it's coming from in my dev environment.

benjamin, Agaric Design Collective

dman’s picture

dman commented

No new tables, and as few side-effects as possible, yeah. Not even a config page.

No idea where your edit term comes from. I just can't see how non-tabbed would work.
OK, if anyone but me can get the patch I submitted over there running OK,
http://drupal.org/node/231559#comment-763774
we can call that testing ;-)

There's always a chance I missed something specific to my environment, so take it for a drive.

dman’s picture

dman commented

Oliver, would you like to test, vote on that patch? I've just patched the patch over there. Looks for an RTBC

dman’s picture

dman commented
Status: Active » Fixed

Release up over there. try it out.

OliverColeman’s picture

OliverColeman commented

Looks awesome, trying it out now, have updated this modules description to point to Edit Term. Brilliant! :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.