Closed (outdated)
Project:
Drupal core
Version:
11.x-dev
Component:
request processing system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Sep 2014 at 15:37 UTC
Updated:
1 Aug 2025 at 20:36 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Crell commentedComment #2
fgmHere is one possible implementation. I'm not totally sold on this, though :
But at least it seems to work.
Comment #3
dawehnerShould this extend the normal one? Just wondering.
Comment #5
fgm@dawehner : yes, that would obviously be a tempting choice, but then it would violate the basic principle of interface segregation.
I do not see how this change can break the TermTranslationFieldViewTest, though. Especially as it passes on my machine. Bot fluke ?
Comment #7
dawehner@crell agreed that we should extend the interface.
test was broken.
Comment #8
fgmRerolled accordingly. This turned out to allow more extensive use of the interface. Let's see if it breaks any tests.
Comment #9
Crell commented80 chars. :-( We can probably just drop everything after the comma.
We don't need to repeat this from the parent interface.
Er, no?
Just doc fixes, easy to address. Then we're good here.
Comment #10
Crell commentedComment #11
fgmRerolled accordingly. Actually, there was an actual earlier bug : a reference to Title::CHECK_PLAIN without its namespace, so I added it too.
Comment #12
Crell commentedUnless bot disapproves. Thanks, fgm!
Comment #16
fgmThe single test which fails on the bot passes on my machine, and does not seem related to the patch in any way. This looks like a bot fluke to me : can anyone triple check ? It was not possibly to check it on simplytest.me, because displaying the testing page eats more than the 256 MB allocated to test instances, even with the minimal profile.
Comment #18
Crell commentedLooks like it passed again. Bot fluke.
Comment #19
catch#2352155: Remove HtmlFragment/HtmlPage will remove HtmlFragment/HtmlPage for now. Some of the concepts could be re-introduced in 8.1.x or later if we can find use cases. Moving to 8.1.x/postponed for now.
Comment #20
catchWhich is probably more likely to be baby steps towards #1843798: [meta] Refactor Render API to be OO.
Comment #36
smustgrave commentedThank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Comment #37
smustgrave commentedWanted to bump one more time before closing.
Comment #38
longwaveThis is long obsolete since #2352155: Remove HtmlFragment/HtmlPage, the ideas from there have not returned, let's close this out.