Problem/Motivation

MigrateExecutable is type hinted in a few places, it has public methods but doesn't have an interface.

Proposed resolution

Add an interface with all the current public methods.
Updated anywhere that is type hinting with MigrateExecutable and then change it to MigrateExecutableInterface

Remaining tasks

Write patch

User interface changes

n/a

API changes

n/a

CommentFileSizeAuthor
#5 interdiff.txt1 KBbenjy
#5 2443615-5.patch50.91 KBbenjy
#3 2443615-3.patch50.93 KBbenjy
#1 2443615-1.patch24.59 KBbenjy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

benjy’s picture

benjy CreditAttribution: benjy commented
Status: Active » Needs review
FileSize
2443615-1.patch24.59 KB

Patch attached.

Status: Needs review » Needs work

The last submitted patch, 1: 2443615-1.patch, failed testing.

benjy’s picture

benjy CreditAttribution: benjy commented
Status: Needs work » Needs review
FileSize
2443615-3.patch50.93 KB

Replaced MigrateExecutable with MigrateExecutableInterface in migrate_drupal as well.

Status: Needs review » Needs work

The last submitted patch, 3: 2443615-3.patch, failed testing.

benjy’s picture

benjy CreditAttribution: benjy commented
Status: Needs work » Needs review
FileSize
2443615-5.patch50.91 KB
interdiff.txt1 KB

Bad F&R

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

Yay, cleaner code! Here to unit testing as well.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

This looks like it's bringing things in-line with similar code elsewhere in D8. Migrate is unfrozen in beta.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 752b99f on 8.0.x 
    Issue #2443615 by benjy: Add an interface to MigrateExecutable

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.