Support from Acquia helps fund testing for Drupal Acquia logo

Comments

clemens.tolboom’s picture

peterpoe’s picture

I tested the patch. It seems to work fine on node edit, but on node view the controlled field is never visible even if triggered.

clemens.tolboom’s picture

dawehner’s picture

patchak’s picture

I've applied the three patches and it works fine, all the fields are showing even when using a taxonomy field controller, I think we should commit and release a beta version to keep track more easily of all the changed that were made recently??

Patchak

SocialNicheGuru’s picture

subscribing

patchak’s picture

Please commit this one too!!! ;)

dawehner’s picture

as a comment to this, i think it should be a patch in content taxonomy than making a patch to conditions fields
// The problem is that content taxonomy doesn't use '#value'

Taras Zavaliy’s picture

Status: Needs work » Active

This is great! Thank's for these patches, they are working just as needed (so far).

patchak’s picture

@ dereine, so you think we should change the project for this issue ?? But does the patch needs to be redone to be working with content taxonomy ???

tanc’s picture

Yes, these patches work for me also. Using the dev version of Content Taxonomay now includes the patch: http://drupal.org/node/250710#comment-860312

So the only patches to make this work are the two in this issue, in comment #1 and comment #4.

Here is a single unified patch of the two required patches against the dev version of this module.

Anonymous’s picture

Status: Active » Needs work

This patch does not seem to respect the 'Specify terms to show' in the Content Taxonomy Field window.

Aside from that, if your Vocabulary is enabled as a hierarchy, the patch will also ignore any child terms.

txcrew

sam_RiteTimeDirect’s picture

Status: Active » Needs work

I am new to this. How would I go about impementing the patch.

I am getting the error below. I am using Drupal 5.x. Will it help with this issue?

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of conditional_fields_set_required_for_render(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /home/content/r/i/t/ritetimedirect/html/sites/all/modules/conditional_fields/conditional_fields.module on line 899

Thanks,

Sam

mitchell’s picture

Title: Patch Content Taxonomy as controller field » Integrate with Content Taxonomy
Version: 5.x-1.x-dev » 6.x-1.x-dev

Moving to 6.x

izarco’s picture

hi, any solution for use this module with content taxonomy ,or better, with core taxonomy?
If I can help on something, I am willing to help.

yngvewb’s picture

Is this on the way in 6? I really need content taxonomy support too. PS. great module!

Heilong’s picture

Also need it under D6.
Subscribing.

andyhu’s picture

Title: Compatibilty with Content Taxonomy » Integrate with Content Taxonomy
Version: 6.x-2.x-dev » 6.x-1.x-dev
Component: Compatibility w/ other modules » Code
Status: Closed (fixed) » Needs work
FileSize
1.7 KB

Hi, I've made a patch for D6, please try

Drupaler China

Heilong’s picture

Hi,

I applied the patch, it's working when the fields are filled but there is a warning message when the fields are empty.

Please check this thread : http://drupal.org/node/250748#comment-1667274.

Zythyr’s picture

Priority: Normal » Critical

Please have Conditional Fields be compatible with Content Taxonomy as soon as possible. Thanks.

dawehner’s picture

Priority: Critical » Normal

come one, critical is everything else. Does this missing feature break your full site? NO!

So its not critical.

I Guess the #18 patch works here, but needs some more work so help there.

matteogeco’s picture

Subscribe

andyhu’s picture

Can you let me know how to reproduce the issue? I've tested creating a node using an empty vocabulary and there's no error message. Thanks.

Andy

shiolo’s picture

It would be great to be able to use content taxonomy with conditional fields...subscribing

peterpoe’s picture

Title: Integrate with Content Taxonomy » Compatibilty with Content Taxonomy
Component: Code » Compatibility w/ other modules

Changing component, and just letting know that Conditional Fields 1.0 will be out next week if no new bug is found!

Zythyr’s picture

Great to hear that. I am waiting for the release, can't wait!!! Conditional field + content taxonomy is a make/break feature on my site so I am really looking forward to your release so I can continue working on my site.

x-lette’s picture

Hi,

there is a strange behaviour which I can't correctly assign to content_taxonomy or conditional_fields (or the special connection between them).

I have four fields in one group, with the first field controlling the latter three. For each controlled field there is exactly one entry in the controlling field and all four fields are of type content_taxonomy.

When editing a node, everything looks fine, selecting one of the controlling values triggers the controlled field to be shown. But even in preview and also after saving the node the value of the controlled field is not shown while the value of the controlling field is visible.

I played a little with the available options and two settings are making this field visible again:

  • the setting "Administrators see all fields"; but obviously this only works for users with "administer conditional fields" rights
  • the setting "on node view: show" in the option group "Orphaned controlled fields settings"

For me this looks like the controlled field is treated like an orphaned one but in fact it isn't. Actually I use the second example and also turned on the option "Reset untriggered fields to default values" so there should not be any real "orphaned" fields. But I guess, this is not the way it was supposed to be.

Does anybody know about this behaviour? Might there be some other settings where I could change this behaviour? Or is this a bug?

I'm using D 6.14, conditional_fields dev as of aug, 16th, the patch from #18 and content_taxonomy 1.0rc2

(I hope this is not the wrong place for this question but there is actually no better place I know of)

Bilmar’s picture

I look forward to help testing patches for new issues.
I am also exploring conditional field + content taxonomy for my website at the moment.

EgorfromMurmansk’s picture

subscribing

mairav’s picture

Suscribe

peterpoe’s picture

Version: 6.x-1.x-dev » 6.x-2.x-dev
xqbzzr’s picture

So, i installed both the latest dev versions of CF and CT.But there is no difference. I cannot set the CT-Field as controller. Neighter can I drop a regular CF in another fieldgroup. I thought the 2.dev Version included these changes?!?
Thank you for contributing this!

rburgundy’s picture

I am needing this very much and can't wait for development of this feature.
Glad to see there is many eyes on this so testing will be fast.
Subscribing

benone’s picture

+

robby.smith’s picture

+1 this is the last feature stopping me from launching my new website. looking forward to updates

andyhu’s picture

Hi everyone,
It seems that the maintainer haven't noticed this issue. For my patch at #18, if there's any issues you could contact me at here at http://drupal.org/user/172337/contact? I'm willing to provide fixes for my patch.

Cheers,
Andy

Bilmar’s picture

hello andyhu,

I am very glad to hear that you will be involved in really getting the compatibility between conditional fields and content taxonomy going for the drupal community.

I will be testing your patch at #18 tonight and will come back with feedback.

Below are some comments from people in this thread so far:
#19 http://drupal.org/node/250748#comment-1689000
#27 http://drupal.org/node/250748#comment-2145846

Thanks for your hard work!

Bilmar’s picture

Patched #18 without any problems. I set a content taxonomy as controlled field and it worked. I will be doing more tests in the coming week.
Thanks for the great work!

rburgundy’s picture

Status: Needs work » Needs review

Changing status to 'needs review'

rburgundy’s picture

Status: Needs review » Reviewed & tested by the community

Tested #18 and everything worked great. Thank you

xqbzzr’s picture

Used the latest dev of CT and CF. Applied patch #18 manually and everything works as expected. Thank you! Can we nail this as a new dev release?

rburgundy’s picture

it would be awesome to see this in the latest dev. thanks again for the great work

samkat12’s picture

HI,
I am new to drupal and without much knowledge with applying patches. How do i get the Conditional field to work with content taxononmy. i am desparate. A quick response will be welcome. any advise will be appreciated.

samkat12’s picture

sorry my question really is how did you apply the patch maunally. did you apply it in the content taxonomy module or conditioanal field module.
I am curiouse if it would help if you just attched the full code from the module you patched. that way i can just copy and paste. or you can give me some tips how you manually patched the moduules in question.

peterpoe’s picture

You have to apply the patch to Conditional Fields.
Documentation for applying patches manually: http://drupal.org/node/534548

samkat12’s picture

Thanks. I downloaded both dev versions of conditional fields and content taxononmy. and then applied the patch from#18. Worked like a cham. i was terrified about how to apply a patch but the manual application worked well for the first time.thanks again.

robby.smith’s picture

tested and works great! little more testing needed before commit?

thekayra’s picture

subscribing.

thekayra’s picture

Tried out patch #18 with non-dev versions of Content Taxonomy (6.x-1.0-rc2) and Conditional Fields (6.x-1.0). Working smoothly. did not run into any issues during the preliminary tests.

rburgundy’s picture

applied patch and tested on my website without any problems.
hoping this gets committed soon. awesome module! regards

Aron Novak’s picture

I re-rolled a patch so now it applies without fuzz.
I did not modify on the code, the code from #18 (andyhu) is perfect, so i also confirm that it works and RTBC.

benshell’s picture

I just applied this patch and it works for me.

samkat12’s picture

coditional fields do not play well when put into cck Group.
when you put both the controlling field and the controlled field in a group.The controlled field does not hide it stays open.Therefore useless since you only want the controlled field to show when triggered by the controlling field.This might be a conflict of javascript...am not sure. Any help would be appriciated.

my-family’s picture

subscribing

samkat12’s picture

6.x-2.x-dev works. my issue #53 is been solved. THANK YOU VERY MUCH FOR THE PROMPT RESPONSE TO THIS ISSUE

smartchecker’s picture

Version: 6.x-2.x-dev » 6.x-1.1
Category: feature » support
Status: Reviewed & tested by the community » Needs review

I have CCK Taxonomy Subset in my content type.
When I try to control it from selection list it does not work.

Bilmar’s picture

fyi - the patch only works against 6.x-1.x-dev. Just tested and it works fine.

I tested the newest 6.x-1.1 and 6.x-2.x-dev and content taxonomy was still not supported.
Applying the patch at #51 against 6.x-2.x-dev results in error:

Hunk #1 FAILED at 364.
Hunk #2 succeeded at 519 (offset 42 lines).
Hunk #3 succeeded at 1280 (offset 73 lines).
1 out of 3 hunks FAILED -- saving rejects to file conditional_fields.module.rej
thekayra’s picture

@trupal218:

I tried the patch #18 with non-dev versions of Content Taxonomy (6.x-1.0-rc2) and Conditional Fields (6.x-1.0).

I tried putting the controlling and the controlled fields in the same fieldgroup. The controlled fields (checkbox) were hidden as expected, so it worked quite ok for me.

I don't know if something has happened with Conditional Fields (6.x-1.1) but I am scared to upgrade it on my live site right now. Once I have some time, I will try it on my demo side and let you know.

sotiris’s picture

Hello,

I have installed CF 6.x-1.1 and Content Taxonomy 6.x-1.0-rc2.

I want to make a content taxonomy field controlling a text/simple select field, but i can't.

I can see Conditional Field settings only in the taxonomy field with result to have this field behave as a controlled field.

In the text/simple select field CF settings are missing.

If anyone can help me, will be much appreciated.

EDIT:

Finally i installed 6.x-2.x-dev and patched it manually with the patch from #51 and now is working. I can use my Content Taxonomy field as a Controller.

My only problem is that it doesn't work with Hierarchical Select widget, and i have to figure out a way to make selection from my subcategories.

Thanks for the patch!

thekayra’s picture

Strangely enough, once I upgraded to CF 6.x-1.1, WITHOUT applying any patch, even the small problem I had with required fields (on CF 6.x-1.0 plus patch #18) vanished.

So I can use Controlling and Controlled fields in the same group with Content Taxonomy (controlling and controlled fileds), one main field controlling approximately 10 other fields with checkboxes. So far, I have not seen any bugs and will keep it this way but let you guys know if I run into any issues.

PS: I do not think that the patch I have applied on CF 6.x-1.0 has anything to do with CF 6.x-1.1 running smoothly, but I might be wrong.

robby.smith’s picture

@thekayra - do you mean that the patch is included in the latest dev version of Conditional Fields?

aboros’s picture

i used the patch in #51 against conditional_fields.module 6.x-1.1
the patch finished without any errors and solved the issue.

thekayra’s picture

@robby.smith:

Yes. However I played a little too much with my modules at that time. So it is better if somebody else can confirm this.

peterpoe’s picture

Version: 6.x-1.1 » 6.x-2.x-dev
Category: support » feature
Status: Needs review » Fixed

The latest 2.x-dev includes a patch that makes Conditional Fields fully compatible with Content Taxonomy (and any other module that uses a custom allowed values function). The code used to obtain this was adapted from the optionwidgets module and looks like this:


/**
 * Find the allowed values for a field
 */
function conditional_fields_allowed_values($field) {
  $function = $field['module'] .'_allowed_values';
  $options = function_exists($function) ? $function($field) : content_allowed_values($field);
  return $options;
}

Enjoy!

benone’s picture

yeee :)

Bilmar’s picture

thanks peterpoe!

YK85’s picture

Status: Fixed » Needs work

EDIT: the issue I had posted before was due to my incorrect setup of the taxonomy vocabulary. Setting status back to Fixed.
Thank you!

YK85’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xjm’s picture

Just wanted to say this is an awesome feature. (The 2.x branch is a great step up all around.) Thanks so much for your work on this.

momper’s picture

also - thank you very much

enkara’s picture

Can you tell if this is going to be part of the beta or the stable release soon? Is it very dangerous to use the dev? Thank you!

EDITING: Sorry I thought it had to work with taxonomy module, not content taxonomy. It's all ok.

Lloyd’s picture

Status: Closed (fixed) » Active

A little confused. Does the current build of 6.x-2.x-dev provide compatibility with Content Taxonomy natively, or does it require it to be patched?

fyi I do have 6.x-2.x-dev of conditional fields installed along with the most recent 6.x-2.x-dev version of content taxonomy. A content taxonomy select list field is not one of the controlling fields available.

xjm’s picture

#73: I am using a content taxonomy field as a controlling field with the current 6.x-2.x-dev and it works fine. Maybe there is a different reason you can't add the field?

Lloyd’s picture

Is there anything special that needs to be done when adding the content taxonomy field? There aren't any "allowed values" specified since it just pulls it from the underlying taxonomy, so I'm not sure if that's the problem. I've tried using both select list and checkbox fields, and different taxonomies.

sunshinee’s picture

subscribing

cposer’s picture

I have a problem using two content taxonomy fields.
Althoug I can specify one term of the one field to be the condition for the other (and it is displayed correctly in the 'manage fields' overview), on editing a node of this type the second field is displayed whatsoever, and not hidden except for when the specified term is selected.

FYI: The two fields use the same vocabulary, only one represents the parent-terms and one the child-terms. I can't use Hierarchical Select Content Taxonomy because the widget is not supported by multigroups, so I figured this might be a solution.

Any ideas?

peterpoe’s picture

Status: Active » Fixed

#73: Re-tested with Conditional Fields 2.0 and Content Taxonomy 2.x-dev, works fine for me. Please read the documentation to ensure that your setup is correct and retry, if the problem persists feel free to reopen this issue.
#77: Probably your problem is with multigroups, see #357506: Compatibility with CCK 3x multigroup.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

cposer’s picture

#78 I'm using the multigroups module, yes, but the fields I'm talking about are in normal groups.

cposer’s picture

I have found the explicit scenario in which the problem occurs:

CF has problems with Content Taxonomy when the fields are on different hierarchical levels due to grouping.
As long as the controlling CT-Field is on the base level and the depending field within a standard group, everything works as it should.
But putting this whole construct into another standard group, so that the controlling field is in the second level and the controlled field on the third, it's not working any more and the depending field is displayed whatsoever.

I haven't tested it with deeper layers and different forms of nesting, but I guess the result would be the same.

Please help =)

xjm’s picture

Issue summary: View changes
Status: Needs work » Closed (fixed)