Ported to Drupal 6 - Code Needs Testing

roopletheme - July 8, 2008 - 22:56
Project:Simple Paypal Framework
Version:5.x-1.0
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

I've ported the Simple Paypal and Donation modules to Drupal 6 and added a handful of features that make the modules easier to configure. I'll submit patches to the issue queues for both modules, but I was first hoping to get some help testing the initial cuts.

In addition to Drupal 6 compatibility, this version of the Simple Paypal module adds support for the British Pound, and it allows the admin to select the default currency.

Anyone game to try this out (along with the updated Donation module that I'm just about to post to that module's issue queue) and give me some feedback?

AttachmentSize
Simple_Paypal-6.x-1.1-dev.tar_.gz7.16 KB

#1

roopletheme - July 8, 2008 - 23:03

The updated and compatible Donations module can be found here.

#2

vwX - July 9, 2008 - 01:55

Can you remove the _ after tar in the file name? Bash auto completion can't find the file when trying to tar xzvf it.

#3

roopletheme - July 9, 2008 - 02:06

I think that's the upload module calling the file_munge_filename function (or the D5 equiv) as a security thing. My uploaded filenames are correct.

#4

sampeckham - July 21, 2008 - 09:28

I'm game to try this out. It's come just at the time when i need to implement this functionality on my development site!

I've downloaded both modules and installed them fine. The configuration pages work fine, but i can't see how to add anything in my site or what to do next. Should there be a block for donations or a page? What am i missing?

(I've never used these modules on Drupal 5 btw)

Thanks

#5

roopletheme - July 21, 2008 - 20:23

You should get a donate page at yoursite/donate, similar to the one at:

http://demo.roopletheme.com/newsflash/donate

#6

sampeckham - July 22, 2008 - 11:32

Thanks. I do indeed have that page, should have checked URL's more closely! Module seems to be working ok, so far.

Is there a method to make this into a block though? It would be much nicer to be able to move this around the page and add to different pages.

#7

kbahey - July 23, 2008 - 03:07
Status:active» needs review

Guys

Please stay on topic. This project is about Paypal as an API, not as an end product (donation, cart, ...etc.).

Let us focus on testing the D6 version of simple_paypal, and not stray into discussions about "how to ...", or other projects/modules, ...etc.

#8

v2egroup - July 25, 2008 - 13:09

I ran your module against coder to check for bugs. It found the following:

Line 29: Menu item titles and descriptions should now no longer be wrapped in t() calls. (Drupal Docs)
'title' => t('Paypal'),
Line 106: Parameters of watchdog() changed, you must remove calls to t() (Drupal Docs)
watchdog('debug', t('Post variables from Paypal IPN @vars', array(
Line 106: Parameters of watchdog() changed, you use $severity WATCHDOG_DEBUG instead of $type 'debug' (Drupal Docs)
watchdog('debug', t('Post variables from Paypal IPN @vars', array(
Line 133: Parameters of watchdog() changed, you must remove calls to t() (Drupal Docs)
watchdog('paypal', t('Call to curl_exec() failed. url=@url vars=@vars', array(

I didn't know about your port and had started my own. I'm now in testing mode. Want to join forces here? I'm trying to combine simple_paypal, signup, and signup_pay.

Thanks.

#9

roopletheme - July 26, 2008 - 09:20

Hey thanks. Will fix and repost.

I'd be happy to combine efforts on this... feel free to use my contact.

#10

roopletheme - July 26, 2008 - 10:34

Cleaned up coder issues. This is a patch against the 5.x HEAD.

AttachmentSize
simple_paypal_280101_0.patch 5.17 KB

#11

kbahey - July 26, 2008 - 15:52

Once a couple of people test this and confirm it is working, I will commit it and create a DRUPAL-6--1 and a dev release.

#12

goatvirus - September 2, 2008 - 20:46

Can someone please give me an update on where this is at? I already posted about this topic BEFORE I saw this list (sorry! experienced php programmer but new to Drupal!) and now I see that it may be close to usable already.

I would be up for trying this out on the Drupal 6.4 site that I am currently working on.

OFFTOPIC: I assume that this is just an API, right? So... what other Drupal modules use this API to implement solutions? I am looking for something straightforward where users pay a yearly fee (different fee for different user types) via PayPal, before their account is activated. I will write this myself if I have to but... why reinvent the wheel? :-)

thanks!
Peter 'Fish' Fisera
GoatVirus Technologies
peter@goatvirus.com

#13

roopletheme - September 3, 2008 - 15:41

I've been using the version from reply #10 on two sites for a couple of months, along with a similar patch I submitted for the Donate module. I know that the Extended Paypal module, the Bounty module, and the Fee module use this module. For a subscription site, you might also check out the lm_paypal module.

#14

goatvirus - September 3, 2008 - 19:59

thanks roopletheme! i will follow your suggestions above, and let you know how it goes.

so... i install the 5.x version of Simple Paypal, and then apply the patch from reply #10, is that correct?

cheers,
Fish
GoatVirus Technologies

#15

markfoodyburton - September 13, 2008 - 21:10

subscribing

#16

markfoodyburton - September 13, 2008 - 21:36

Nearest I can come to getting your patch to apply is to apply it against
this release:
http://drupal.org/node/290655
(I tried against the cvs 5.x HEAD and it didn't go too well :-( )

Even on this release, the patch does not seem to be clean on the .info file :-(
(However, the patch for that is easy to apply by hand:-) )

now, whether this module is what I need - thats another question - so I haven't been able to test the result I'm afraid
(though druapl was happy to install the module, and I could change the config settings :-) )

#17

goatvirus - September 16, 2008 - 21:34

hi good people... sorry, i won't be one of the test rats for this module after all, i have installed a 6.x alpha of lm_paypal instead (see http://drupal.org/node/209287#comment-996562 ), since it integrates with lm_subscriptions (which is EXACTLY what our project needs).

but i will watch this thread to see how it goes with Simple Paypal. good luck all !

cheers
Fish

#18

SteveK - October 23, 2008 - 03:25

I've posted a bounty for this upgrade:

http://drupal.org/node/324987

#19

alienseer23 - January 28, 2009 - 02:39

whats the word on this?

#20

flickerfly - January 28, 2009 - 16:42

$ patch -p0 < simple_paypal_280101_0.patch
patching file simple_paypal/simple_paypal.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file simple_paypal/simple_paypal.info.rej
patching file simple_paypal/simple_paypal.module
Hunk #3 FAILED at 63.
Hunk #4 succeeded at 143 (offset 40 lines).
Hunk #5 succeeded at 170 (offset 40 lines).
1 out of 5 hunks FAILED -- saving rejects to file simple_paypal/simple_paypal.module.rej

Sorry I don't know what to do with the rej files. I've attached them in hopes that they may be useful to someone.

AttachmentSize
Rejects from Patch in #10 to 5.x head 1.06 KB

#21

mgifford - March 14, 2009 - 20:30

Ok, I'm pretty sure I've addressed the outstanding issues with the patch. Tried it against the latest CVS and re-rolled it.

Also included the tarball for those who just want to try the D6 version.

I cleaned up the currency thing again and brought it in - http://drupal.org/node/164807

Used a slightly different approach this time to rank the dropdown.

Donation module is upgraded too.

AttachmentSize
simple_paypal_d6.patch 5.88 KB
simple_paypal_d6.tar_.gz 5.42 KB

#22

kbahey - June 12, 2009 - 14:29

Committed. Thanks all. A release for D6 will be created tonight.

#23

kbahey - June 12, 2009 - 14:30
Status:needs review» fixed

#24

System Message - June 26, 2009 - 14:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#25

moshe weitzman - July 8, 2009 - 05:42
Status:closed» active

no release yet

#26

kbahey - July 9, 2009 - 04:52
Status:active» fixed

Release for 6.x now shows on the project page.

#27

System Message - July 23, 2009 - 05:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.