If comment karma form is displayed you will not be able to submit replies in both Opera (up to 9.51) and IE7 (and almost certainly in IE6) if you choose to preview them first (a real bugger if you want to force preview before submitting..)

It is caused by user karma form being displayed inside reply submit form (not the case if replying without preview). Submitting is impossible either because form in form is not accepted, or because karma form contains line <input type="submit" name="submit" value="Vote" disabled="disabled" /> which might effect both forms - I don't really know.

CommentFileSizeAuthor
#10 extravotingforms_nestedforms_286355_10.patch868 bytescedricfontaine

Comments

Etanol’s picture

Etanol commented

Additional info: it's the nested form - IE and Opera really don't like invalid html

mercmobily’s picture

mercmobily commented

Hi,

I had written a comment here and it got lost. Sorry about this,

Can others confirm that this is happening? I don't have IE nor Opera.
Does this problem arise for example when you add a comment to FSDaily using Opera?

Could this be solved by NOT displaying the voting form during preview? (Not sure how to do it, but it should be possible).

Merc.

Etanol’s picture

Etanol commented

Well, I have done some research and the problem is that in Drupal 5.x reply form has
tag opened BEFORE the previewed content. As a result if there is any form in that content, like comment karma voting form, you end up with nested forms, which is not valid HTML.
IE is quite anal about rendering content and apparently so is Opera. I have checked IE6 SP2, IE7, Opera 9.2x and Opera 9.5x.

The problem would be solved by not displaying voting forms on reply preview.

As for FSDaily I will check as soon as I finally get the account confirmation email

mercmobily’s picture

mercmobily commented

Hi,

OK. I will start working on it once you confirm that FSDaily has the same problem.

Merc.

Etanol’s picture

Etanol commented

I can confirm it is exactly the same with Opera 9.51 on FSDaily. As for other browsers mentioned I can't really tell right now - I don't have access to a windows box at the moment. It is almost 100% sure it will be the same since the code has the very same validation errors.

mercmobily’s picture

mercmobily commented

Hi,

I would like to reproduce this myself.
Which version of Opera?

Merc.

Etanol’s picture

Etanol commented

Opera 9.51 on Vista, Internet Explorer 6 SP2 on XP, Internet Explorer 7 on Vista. I will test Opera on Linux tomorrow morning, but I don't expect any difference.

To reproduce just login, type any reply, click 'preview' and then try to submit - clicking on the button will have no effect.

Leeteq’s picture

Leeteq commented

Subscribing.

cedricfontaine’s picture

cedricfontaine commented
Assigned: Unassigned » cedricfontaine
cedricfontaine’s picture

cedricfontaine commented
Status: Active » Needs review
StatusFileSize
new extravotingforms_nestedforms_286355_10.patch868 bytes

My understanding is that this patch should solve this issue. Sorry, I can't setup a test site for this patch. So please test it.

mercmobily’s picture

mercmobily commented

Hi,

Sicjoy, can you please apply this manually to the DRUPAL-6 trunk as well?

Bye,

Merc.

mercmobily’s picture

mercmobily commented

Hi,

Which version of Opera are you using?
Opera 9.52 doesn't seem to have any problems with OR WITHOUT this patch.

Please test http://www.drigg.com (with the patch) and confirm that IE works.

Bye,

Merc.

mercmobily’s picture

mercmobily commented
Status: Needs review » Fixed

Hi,

Gosh it's nasty when posters disappear...
OK, this is fixed.

Merc.

mercmobily’s picture

mercmobily commented
Status: Fixed » Closed (fixed)