Comment karma form in comment preview prevents submitting replies in IE and Opera [#286355]

If comment karma form is displayed you will not be able to submit replies in both Opera (up to 9.51) and IE7 (and almost certainly in IE6) if you choose to preview them first (a real bugger if you want to force preview before submitting..)

It is caused by user karma form being displayed inside reply submit form (not the case if replying without preview). Submitting is impossible either because form in form is not accepted, or because karma form contains line <input type="submit" name="submit" value="Vote" disabled="disabled" /> which might effect both forms - I don't really know.

Comment	File	Size	Author
#10	extravotingforms_nestedforms_286355_10.patch	868 bytes	cedricfontaine

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Etanol CreditAttribution: Etanol commented 23 July 2008 at 18:06

Additional info: it's the nested form - IE and Opera really don't like invalid html

Comment #2

mercmobily CreditAttribution: mercmobily commented 24 July 2008 at 10:16

Hi,

I had written a comment here and it got lost. Sorry about this,

Can others confirm that this is happening? I don't have IE nor Opera.
Does this problem arise for example when you add a comment to FSDaily using Opera?

Could this be solved by NOT displaying the voting form during preview? (Not sure how to do it, but it should be possible).

Merc.

Comment #3

Etanol CreditAttribution: Etanol commented 25 July 2008 at 08:43

Well, I have done some research and the problem is that in Drupal 5.x reply form has
tag opened BEFORE the previewed content. As a result if there is any form in that content, like comment karma voting form, you end up with nested forms, which is not valid HTML.
IE is quite anal about rendering content and apparently so is Opera. I have checked IE6 SP2, IE7, Opera 9.2x and Opera 9.5x.

The problem would be solved by not displaying voting forms on reply preview.

As for FSDaily I will check as soon as I finally get the account confirmation email

Comment #4

mercmobily CreditAttribution: mercmobily commented 25 July 2008 at 09:59

Hi,

OK. I will start working on it once you confirm that FSDaily has the same problem.

Merc.

Comment #5

Etanol CreditAttribution: Etanol commented 25 July 2008 at 11:08

I can confirm it is exactly the same with Opera 9.51 on FSDaily. As for other browsers mentioned I can't really tell right now - I don't have access to a windows box at the moment. It is almost 100% sure it will be the same since the code has the very same validation errors.

Comment #6

mercmobily CreditAttribution: mercmobily commented 25 July 2008 at 14:36

Hi,

I would like to reproduce this myself.
Which version of Opera?

Merc.

Comment #7

Etanol CreditAttribution: Etanol commented 25 July 2008 at 21:18

Opera 9.51 on Vista, Internet Explorer 6 SP2 on XP, Internet Explorer 7 on Vista. I will test Opera on Linux tomorrow morning, but I don't expect any difference.

To reproduce just login, type any reply, click 'preview' and then try to submit - clicking on the button will have no effect.