Collapsible forum containers

Thanks for doing this. :)

Michelle

wonderful! Can we add +/- icons?

Changing status so I can find it easier. It may be a bit until I can get to this, unfortunately.

Michelle

Modified the two parts of this file. Attached images. I've learned a bit of jquery to make this patch, i hope that this "patch" is not so bad :)

I'm thinkin a way to add automatic ID and function to the containers. Icons path should be dynamic also (i think drupal_path functions or similar are the correct functions...i'll see API)

<div class="name"><a href="<?php print $forum->link; ?>"><?php print $forum->name; ?></a> <?php if ($forum->is_container) print "<span id=\"containerID-".$container."\" style=\"margin:0 1em 0 0; float: right;cursor: pointer;\"><img id='toggleImage-".$container."' src='sites/all/modules/advanced_forum/themes/advforum/images/minimize.gif'></span>";?><!--collapsible container--></div>

//collapsible container jQuery
drupal_add_js (
    
		'$(document).ready(function() {
    	$(\'#containerID-1\').click(function(){
        $(\'.forum-child-1\').toggle();
        if($(\'img#toggleImage-1\').attr("src") == \'sites/all/modules/advanced_forum/themes/advforum/images/minimize.gif\'){
          $("img#toggleImage-1").attr("src","sites/all/modules/advanced_forum/themes/advforum/images/maximize.gif");
        }else{ 
          $(\'img#toggleImage-1\').attr("src","sites/all/modules/advanced_forum/themes/advforum/images/minimize.gif");
        }
      });
  		return false;
		});',
		'inline'
);

Very nice! Don't worry about making a patch top priority. I have some client work I need to do before I can work on the module again so it'll be a while before I can get it in anyway.

Thanks!

Michelle

Ok, so I was supposed to do some client work this weekend but worked on advforum instead. So I got a bunch of stuff fixed and want to make a new set of alphas sometime this week. Any ETA on this? Do you think it will be ready to be included?

Thanks,

Michelle

Getting others to support development beyond saying "+1" can be hard... That's why I'm excited that you took on this part. ;)

If you think it's at a usable point, I just need the current code.

Thanks :)

Michelle

did you add my patch?

done it!

<div class="name"><a href="<?php print $forum->link; ?>"><?php print $forum->name; ?></a> <?php if ($forum->is_container) print "<span id=\"containerID-".$container."\" style=\"margin:0 1em 0 0; float: right;cursor: pointer;\"><img id='toggleImage-".$container."' src=\"sites/all/modules/advanced_forum/themes/advforum/images/minimize.gif\" alt=\"Show or hide the forum\" /></span>";?><!--collapsible container--></div>

//collapsible container jQuery
drupal_add_js (
    
		'$(document).ready(function() {
    	$(\'#containerID-1\').click(function(){
        $(\'.forum-child-1\').toggle();
        if($(\'img#toggleImage-1\').attr("src") == "sites/all/modules/advanced_forum/themes/advforum/images/minimize.gif"){
          $("img#toggleImage-1").attr("src","sites/all/modules/advanced_forum/themes/advforum/images/maximize.gif");
        }else{ 
          $(\'img#toggleImage-1\').attr("src","sites/all/modules/advanced_forum/themes/advforum/images/minimize.gif");
        }
      });
  		return false;
		});',
		'inline'
);

i thought about it yesterday. I think there's a better way to do this: using css classes and recycle code from collapse function.

#18
advf-forum-list.tpl_.php_.plusminus_bogus.txt
tested and also have the same issues/bugs

a nice implementation is here
http://gallery.menalto.com/forum

you can think some code functions to use "all shown" at the beginning or "all hidden" or "hide some individual" containers by an array of numbers for eatch container (eg 1,5,6,8...) for each forum list in that order
every new container can also follow a rule (new collapsed or shown) and then if needed, it can be included manualy in the code as (last) number in the array, just a simple idea.

Yeah, the Gallery forums have long been an inspiration to me. I actually have a copy of their theme from a while back so I could look at the custom code in the forum. (Not allowed to give it out, though.)

Just so you know, I'm not ignoring this issue. Just need to get the style revamp done before I can implement this.

Michelle

Great work! Are you sure to make jquery_plugin Module a "dependence" (i'm not sure this is the correct term)?

Are there the last patched files?

grn - Sorry, I missed your question. The forum container names can be gotten with variable_get('forum_containers', array());

Michelle

Just want to say thanks for your continuing work on this. I don't want you to get discouraged that it's not in, yet. I will add it. Just getting time to work on advforum has been rough lately. :(

Michelle

Find a nice way for users to specify which folders to collapse as default.

The only way that i find is: save on profile or in other table a array of collapsed forum for every users. Mmmm is this so necessary?

@grn. I saw the todo list, but i haven't tried the patch yet. Is there something doesn't work?

I'm getting close to being ready to tackle this but I'm confused on which code I should be using. Could you add a new comment with the latest code when you get a chance?

Michelle

what about 5.x ?

Ok, I spent quite some time tonight trying to work this patch in. Unfortunately, I can't use it as is so I've been trying to understand how it all works and put the pieces in the proper spots. I ran out of time tonight and don't want to commit my half done mangled mess but I wanted to let you know that I am at least working on it. :)

Michelle

Ok, I've spent about two hours on this and I can't afford to take any more time for it right now. I appreciate your work, but this patch just isn't usable as is. Part of that is my fault as I've changed the .tpl so it doesn't apply but even besides that there are too many issues:

• The code doesn't conform to Drupal's coding standards
• Adding an option just for whether they want to use icons in this one spot isn't going to work. That should be handled in the theming. Also, image paths can't be hardcoded.
• There is a huge chunk of code being added to the top of the .tpl. Template files should have minimal amounts of code. This needs to be worked into the preprocess code as much as possible or into the existing foreach array in the template for anything that can't be put in the preprocess.
• jquery code is normally put in a seperate .js file. I don't know jquery so maybe there's some reason why this needs to be inline but, if at all possible, it should be separated out.
• <a onclick="event.cancelBubble = true" doesn't appear related to this issue.

I realize you did this for your own use and I understand if you don't want to take the time to fix it up for general use, but it would be great if you could since this is a feature I'd like to have included.

Thanks,

Michelle

Actually, hold that thought. I was thinking about this in the shower and I think I have a much easier way to do this. My knowledge of jquery is rudimentary but I think it will work. I can't try it out until later today, though.

Michelle

Ok, I worked on this some more during nap time. I don't know jquery, but I have a general understanding of how it targets things so hopefully the changes I made will be helpful.

• Added advanced_forum.js. You can put your functions in here and they will be included.
• Added your icons as container_close.gif and container_open.gif in the naked style.
• Added a class to each container of "container-N" where N is the TID of the container. I used the TID rather than its position so settings will still work even if they get moved around. Plus it will make it easier to specify a list of open/closed containers in admin at some point.
• Added a class to each forum of "in-container-N" where N is the TID of the containing container. There is a bug at the moment where you end up with just "in-container-" for forums at root. I plan to change that to "in-container-none".
• Added <span id="collapse-toggle-N"> where N the TID of the containing container. This is for adding the +/- like you have in your class.

These changes are in CVS and will be in the tarball in about 3 hours. I haven't added any of the jquery at this point. I'm hoping you can use these classes to target your jquery. If you're willing, I'd like to work together on this and have you write the jquery and just tell me what you need in the PHP end and I will make it happen. If you need more classes to be able to target things better, just let me know.

BTW, I read the Gallery page and figured out what that bubble bit was for. :)

Thanks again for your work on this. My intent isn't to just discard all your work. In fact, I've spent quite a bit of time studying it and trying to figure out what you did but the jquery is just beyond me at this point.

Michelle

Sounds great. I'll make sure to add credit for the icons to Psicomante. I've got a second issue about documenting icon sources so it will be taken care of with that.

Michelle

Thanks grn, but my work was very simple related to yours. Anyway i'm thinking about providing better icons for minimize and maximize. When they will be ready, i'll attach them here.

I tried rustling up someone on IRC that can help with this. No luck so far. Will try again this afternoon. I'm headed out of the house for a while.

Michelle

Well you could generalize the function and set an event listener on the elements you want for the onclick (meaning it doesn't have to be a link/image - things like table rows should work)

I think to create that function for each topic would be bad, bad, bad.

yuck... cookies everywhere? your users have to send those to the server on every request.

There's got to be a better way.

grn:

You asked how you could avoid hard-coding each collapse/expand call. I suggest making it a static function.

I'm rather working in the dark because I only have a theoretical knowledge of jquery, but...

How about if I put some sort of "onclick" code on each container's TR/TD that sends the TID to a jquery function? Since all the forum TRs are classed with in-container-TID you can to target them from that.

We'd also need a function on page load that will set up the collapsed state according to 1st the user's cookie and 2nd, if no cookie, the states set up by the admin. On the admin side, I can store a set of TIDs that should be collapsed. Assume any not in that set are uncollapsed. I don't know how jquery cookies work but it seems like you should be able to do the same there. So the onload jquery code would just read the set of collapsed containers and hide them.

Seems simple enough but, then, I don't know how to execute it so maybe I'm way off base. LOL

Thanks,

Michelle

Michelle:

That is exactly how I would have approached.

I'll look into the jQuery later this evening.

I can't get that to work... Can you have a look at http://6dev.shellmultimedia.com/forum and tell me if I put the jquery in the right spot?

Michelle

Well, color me confused. It is working for me, now, too. I can open and close them with just one click. So we just need something for the +/- icons, then. Awesome work!

Michelle

nice approach..
can you please point a delicate way to load the javascript "advanced_forum.js" on 5.x (and 6.x if different)?

@jannalexx - It's loaded via drupal_add_js.

@grn - Ok, so here's the "to do" as I see it:

• Add a function to set the initial collapsed state. This should look first at cookies and, if no cookies, at a list stored in a Drupal variable.
• When you click on a link in the container, it opens/closes the container. I believe that's what that "bubble" thing was meant to fix.
• Add the +/- icons and have them change depending on the container's collapsed state.

Anything I'm missing? Are you able to tackle these?

Thanks!

Michelle

function advanced_forum_js_load() {
drupal_add_js(drupal_get_path('module', 'advanced_forum') .'/advanced_forum.js');
}

or
drupal_add_js("sites/all/modules/advanced_forum/advanced_forum.js", 'module');

But js can't be loaded
error: jq_collapse is not defined

(file is in the directory), whats the code in your side?

@jannalexx - If you're curious about how this is being implemented, please just look at the code so we can keep the issue on topic.

@grn - I used a span instead of an image for the +/- because that is how you had it in your original code and I thought it needed to be that way. I changed it. You'll need to add the javascript to change from close to open as needed.

Setting cookies for the initial states sounds fine.

I have no idea how to send PHP to javascript. I'll see if I can rustle up some help for that.

Changes so far committed.

Thanks,

Michelle

Sorry I disappeared the past few days!

I think grn is on the right approach. Have the JS read from the cookie. Have PHP set the cookie from the DB if one doesn't exist.

This way, you have the option of talking both ways (anything the JS does could eventually be read by the PHP).

jquery_plugin_add("cookie"); is undefined.

Heading out for a couple hours. If you can tell me how to fix that part, I'll commit the latest when I get back.

Thanks,

Michelle

@grn - Oh... Hrm... I missed that when I read through. Is that the only way to do it? If so, I guess I'll just wrap the call in a functon_exists so it doesn't fail for people who don't have the plugin.

Michelle

No, I don't want to do that. I was wondering if there was any way to do it with the jquery available in core. If not, I guess I'll need to include instructions for adding this if people want it. Is there any way to make the +/- change on click so at least that's accurate without cookies?

Michelle

Ok, so how about this for a plan:

1) Initially assume all containers are open
2) I will put in the code to use jquery cookie but will check for the presense of the function. If it's there, the code will run to read the state of the forums from the cookie. If it's not there, this step will be skipped.
3) If the code to read the cookie exists but the cookie itself does not, prefill the cookie with the states from the Drupal variable.
4) When a user clicks to open/close a container, attempt to write it to the cookie and also target the icon to change it. This way the icon will change whether the cookie code is there or not. Of course, this won't be maintained between page refreshes if there is no cookie code.

Does this sound like a plan to you? If so, I believe all that I need from you is the code to change the icon on click. I think you have the rest of it working with the cookie if jquery cookie is installed, correct? Also, could you provide instructions for getting jquery cookie working with D6? You said something about copying the code to jquery plugins but I'm not sure what code and where it goes. It looks like the jquery plugins maintainer may be open to adding it but I need to test this in the mean time as I want to do an alpha in the next day or so and this is one of the last remaining issues.

Thanks,

Michelle

Note to self: I also need to finish the work of making collapsable containers optional so I don't have to endure the wrath of Morbus. ;)

Michelle

A) I admit I don't know jquery but I know enough about it that I don't think it's impossible to toggle between two icons on click without using cookies. I'll see if I can find someone to help with that.

B) I don't, either. Let's see if I can rustle up some more help.

Thanks for the tips on getting the cookie working. Hopefully we can get this sorted. I can't keep holding off on this alpha. The last alpha was in June and that's way too long between.

Michelle

With this new info - I would suggest setting up a new page in your hook_menu to handle AJAX requests. So instead of cookies, you are just speaking to your database. Then on initial load, you can pull the data from the db and populate that into the .tpl file.

The only reason I suggest this route now is I was unaware (aka didn't read) that using cookies required an additional module. This is unacceptable for such a menial feature.

@cridenour - Is this something you're able to help with? I know what hook_menu is but I'm really just out of my league with jquery/ajax. As much as I'd love to work through how to do it and learn how to use them, it's just not possible for me right now. Too much on my plate and I really need to get this working ASAP to replace the buggy alphas we have now. If you have the time to swoop in with a patch that makes this work without relying on jcookie or tons of code packed into the .tpl, that would be really awesome. I think we're close in the direction we're going but I just don't have the knowledge to push the rest of the way there.

Thanks,

Michelle

I likely won't be able to write anything until the weekend. If that changes, I'm sure I'll be in IRC but have a presentation on Friday.

I'll check back here if my schedule opens up in the evenings.

Attached patch goes against 6--1 Branch.

Basically we have an onload AJAX call and AJAX calls after each toggle. It sends it to PHP which handles the cookie (or creates on if it does not exist).

I still need to create the menus to allow the admin to set defaults. However - this could also be done by others - just need to pull down current categories, some checkboxes, serialize the results in a [category_id] => [boolean for collapsed] format :)

Hmm just noticed I still have some debug comments in there as well...

And Michelle I will talk with you tomorrow on D5 roll - some of the jQuery changes I believe. I'll need to do some research during lunch.

Yeah, I can handle the settings page. I was just waiting until this got sorted before adding it.

The patch looks good. I only have a few nits:

1. I think the path should be advanced_forum/collapse rather than advf/collapse
2. The variable should be advanced_forum_collapse_defaults rather than advforum_collapse_defaults
3. As you said, debugging code needs to be removed
4. I don't understand the reason for dropping the last div in <div class="num num-topics"><?php print $forum->num_topics ?></div>

I can take care of the first 3 myself later today if you don't get to it first. The last one needs your input, though. Thanks very much for doing this. :)

Michelle

@2
I was following the advforum_topic_pager_max variable name ... any reason that isn't advanced_form?

@4
I wanted Eclipse to stop telling me there was an unclosed div... I meant to ask you about that. There is a mismatched # of divs in that section - there was no collapse reason for it, I just wanted the errors to go away :)

@2 - That's an error, then. The rest are all advanced_forum. I'll fix that. A lot of those variables just got created on the fly when I decided something should be optional as I wrote it and I must have goofed with that one.

@4 - Interesting... There should be a closing div there so it's messed up somewhere else. I'll look thru it, thanks.

Michelle

Ok, patch in #83 comitted. Thanks for jumping in, cridenour.

Remaining issues:

1. Icon doesn't change between +/-
2. Need to add admin settings for initial states
3. Forum header jumps sideways when opening/closing containers

I can do #2 and probably #3 but I need help with #1.

Thanks,

Michelle

Ok, #2 is done. Still need help with #1.

Michelle

#1 done.

When I apply this, the icon changes, which is great, but the states stop getting saved, which is not good. :(

Michelle

On what browser? The fox? And I also noticed another little bug in my patch. Not seeing the problems you are though.

Will re-roll tonight.

Yes, on FF3. All I did was apply the patch and clear the cache. The icon changed back and forth but as soon as I went to another page and came back, all containers were open again. Reverting the patch made it go back to remembering the container state.

Thanks,

Michelle

On the admin page (admin/settings/advanced-forum) the $options array was not reset after the theme selector dropdown.

Line 190 (approx) needs an:
$options = array();

before the loop before $form['advanced_forum_collapse_defaults'] = array(

It is currently:

Default collapsed containers:
[ ] naked
[ ] blue_lagoon
[ ] cat 1
...

I'll try to checkout the cvs version tonight and make a patch.

@halkeye - Whoops. Missed that. No need to make a patch. I can fix it. Thanks for letting me know.

Michelle

@cridenour - any progress on this? We're almost there. :)

Thanks,

Michelle

In the last few lines, where it pulls the initial state - try chaning container_id to tid (the correct variable name in that function) That might be the problem here.

Sorry school started up and am organizing a Cincy drupal meetup tonight. :)

At this point, collapsable containers are totally broken. I'm sure it's my fault. I applied a bunch of E_ALL notice patches from another issue and something in them broke it. But I don't know what happened or how to fix it. I need someone with jquery knowledge to go in and fix the goof and get this all working. Since this isn't likely to happen tonight, I'm going to hold this one over until after the alpha.

Michelle

Every time I sat down with it, I got pulled away two-five minutes later. Not sure when my schedule will clear. But this is sitting up near the top when it does.

I agree on waiting though.

I am going to be releasing a new alpha with just bugfixes as soon as I can get a hold of John Albin and fix the Zen subtheme problem. I need to either have these containers working or I'll need to pull the code out. I've had a couple of people complaining that the unfinished code is causing problems.

Is anyone going to have time to work on it this week?

Thanks,

Michelle

Should link to the issues I'm duping for this to make sure all problems get fixed...

#317371: Advanced Forum error on page
#317008: Fatal error related with collapsible containers

I really could use help on this issue. I'm waiting on John's help with the Zen subtheme issue this week. Soon as we get that fixed, I'll be rolling a bugfix alpha. If no one has time to get this fixed, I'm just going to take all the code out until someone has time.

Michelle

And another issue caused by this: #318256: Something is wrong with sitewide pager links

I've removed all of the code from both branches for collapsable containers. The work isn't lost as it's there in the CVS history. I don't have the js/ajax skills to do this. If someone wants to do this, I'm open to a patch provided it works, follows Drupal coding guidelines, and doesn't cause any of the issues that caused me to remove all the code.

Thanks to those of you who worked on the code. I do appreciate the effort but I can't leave code in there that causes problems, especially since the code wasn't yet to a working point.

Michelle

Sorry I was pulled away from this. Considering I am unable to reproduce any of the errors on my site with the code I wrote against, like you said earlier, something was broken later on.

The pager links problem is even more confusing to me as it looks like it is appending the cookie to the URL. Maybe once school dies down again, I can approach the problem vs the latest build and find out what went wrong. This one seems to be an issue that might be in core as I'm not doing anything fancy with the cookie but that will have to wait for my schedule to die down.

Again, I apologize for being pulled away from this lately. As you can tell by my absence in IRC / groups.drupal etc, I am not just ignoring this :)

Chris

I understand. Real life gets in the way of fun coding a lot. TBH, I don't see this as a critical feature. It's nice, sure, but we can live without it until we have a solid solution. The code is all out of the dev. If anyone is still having pager issues, be sure to clear your cookies.

I'm going to set this as a postponed feature request until you or some other jquery person can step up and take this home. :)

Thanks for all the time you folks have put into it.

Michelle

Now that I have alpha 13 out, AF is open to new features again. If anyone wants to work on getting this into alpha 14, feel free. :)

Michelle

Will this work on drupal 5?
I installed alpha 13 on my Drupal 5.12, but I didn't see the option "Default collapsed containers".

Thanks

@akiecs - This won't work on either version until someone writes it.

Michelle

grn - Sure. The code is all either in this issue or in cvs. You can use it as a starting point. I need to be firm on this one, though, because this issue sucked up far too much of my time for such a tiny feature. I'm only willing to look at completed, working patches that follow Drupal's coding standards so I can just apply, test, and commit. Normally I'm willing to spend time helping patches along but I've already spent that time on this one.

Michelle

For you still interested in this, I found a nice site about solving this issue: http://www.tobypitman.com/multiple-collapsable-panels-with-cookies/
I've almost managed to get it to work on the forum, but there are still some problems with it, so I can't release my code-snippet yet.

I really like the approach, but I'm still struggling on how to access the right ul to hide for each container.
(See for yourself on the menu to the left on that site)

Just an FYI: Now that each container is its own table, that may help with this. Now is a good time if anyone wants to have another go at a patch as I'm actively working on 2.x. I still don't know any javascript / jquery so this feature is relying on the community stepping up. :)

Michelle

Good idea to give each container a table - might this also open the door to making them sortable?

I will happily test any collapsible patches once 2.x is a little more stable.

@andrewsuth: No, they won't be sortable because they aren't created with theme_table.

Michelle

Notes from IRC:

[10:53] $output = theme('ctools_collapsible', $title, $content, $collapsed);
[11:02] So it's still just a case of taking what's in theme_ctools_collapsible and re-organizing as you like. The handle is the clickable part, the content is the part that will go away. You'd want to provide a different toggle icon but that's doable with CSS easily enough.
[11:02] The javascript adds the toggle icon so it won't appear if .js isn't available.

Michelle

Hello,

i am trying to create a patch for this feature. I tried ctools_collapsible, but that the theme function required a div element, but in the forum containers there is a table element.Thus it's not possible to use the ctools_collapsible unless it supports other html elements. So i think we have to write custom jquery code to support such a feature.

I would prefer to use the CTools code since it's already a dependency. merlinofchaos is currently on vacation but I can talk to him about it after Drupalcon.

Thanks for looking at it,

Michelle

I believe too, that using CTools is a much better solution than writing custom code. But unless ctools_collapsible supports table elements is not possible to use this function.

Thanks for your quick reply,
apanag

Do we have any feedback on this?

apanag

This commit should fix that: http://drupal.org/cvs?commit=261180

Yes i think its perfect for now.
I think i ll be able to provide a patch for the collapsible blocks.

Thank you merlinofchaos, for your work.

Awesome, thanks!

Michelle

@merlinofchaos
I have some problems with the last version of the ctools.

We have an html structure with a table:

table
 thead
 tbody

We want the thead to be the $handle area and tbody to be the $content area. If we use the theme function theme_ctools_collapsible_remembered, we will be having a div area inside a table and that's not valid.
Finally the collapsible-div.js is looking always for div

Drupal.behaviors.CToolsCollapsible = function(context) {
  $('div.ctools-collapsible-container:not(.ctools-collapsible-processed)', context)
    .each(Drupal.CTools.bindCollapsible)
    .addClass('ctools-collapsible-processed');
}

Is it possible to check only for the classes and if there are the correct classes to provide the functionality?
For example if i manually wrote

<table class="ctools-collapsible-remember ctools-collapsible-container"> 
 <thead class="ctools-collapsible-handle">
  <tr><th class="forum-icon"><span class="ctools-toggle"></span></th></tr>
 </thead>
 <tbody class="ctools-collapsible-content">
   <tr><td><td></tr>
 </tbody>

Hello guys,

after working: http://drupal.org/node/558918 with merlinofchaos on ctools collapsed functionality, i created a patch to integrate collapsed areas into advanced_forum.module.
This is my first attempt and i am waiting your feedback. There is still one issue left for display correctly the table.
You have to use the latest dev release of ctools.

Many kudos to merlinofchaos for his hard work.

apanag

PS:
The patch is for naked style only.

Thanks. I'll check this soon as I can. Going to be a very busy weekend and then I'm traveling so will likely be later next week.

Michelle

Any ETA on when this will be working. We have over 10 containers with approximately 15 forums in each. We seriously need collapsable containers to clean up the look and feel of advanced forums.
Many Thanks
Samantha

@SamanthaV : Well, you can always test the patch. The more eyes on it the better. I don't have any personal need for this so it would be great if people who do have a need stepped up to help. :)

Michelle

With regret, moving this to D7.

Michelle

I could test this for D6, i also have a need for this.

2.x isn't final, yet. If someone provides a patch that works well, I'll apply it. So far, I haven't seen one. I don't have containers on my site so it's not something I am going to spend time trying to do at this point.

Michelle

patch in 129 works! You need to explicitly load collapsible-div.js (unless there's some other way, i'm still finding my way around ctools), but once you do it works great. The only issue is, when the container is collapsed the headings (forums, topics, posts, last post) resize. I'm not sure what the best to address that is-- Ill noodle on it a bit and see if I can figure something out.

Thanks, WorldFallz. It's been so long I don't remember what issue I had with the patch anymore. I'll set this back active again since you're looking at it. Would love to get this into 2.0. :)

Michelle

well-- thats turned out to be WAY easier than I thought! Patch attached.

And as a bonus the patch included two fixes for php notices i'd forgotten I added ;-)

Awesome, thanks! I'm just about to head out but will try to look at this soon.

Michelle

no worries-- whenever. I'm going to add a collapsed/expanded indicator also so there will be at least one more patch before you commit.

bah, crosspost

OK, here's what I have so far. Includes two graphics for the expanded and collapsed states. I cannot figure out what css magic I need to do to get the graphic to toggle when expanded. Maybe some css/js guru can figure it out.

And now with less spelling errors (it still doesn't work though).

I always post too soon-- here it is with functioning toggles. You need the graphics from #143 and to load up collapsible-div.js from ctools and you'll have collapsy goodness. ;-).

I'm thinking the best way to make sure collapsible-div.js is loaded it to add a drupal_add_js in the preprocess page function-- but how does that work with other modules? Since ctools is a library, there could be lots of other modules that load collapse-div.js as well. Does drupal_add_js take that into account?

Just had another thought-- do you want this to be always active, or should it be an option at admin/settings/advanced-forum?

Here's another version with a much more subtle plus/minus graphic I recolored to match the colors of your folder icons. This is probably better for a 'generic' style.

You've been busy. :) I wasn't at the computer much last night so haven't gotten to look at this, yet. As for making it a setting, I don't think that's necessary. I've gotten a lot more stingy on what I make an option since I started this. If it can be changed in theming or with a hook, I avoid making it an option. Trying to get away from the jet cockpit look on the settings page. :)

Michelle

yeah -- when I get it in my head to do something I'm pretty much obsessed until it's done, lol. I like the minimal options philosophy and you can easily theme this out by removing the ctools classes in the tpl.php.

I get that way, too, but I only have a couple of kid-free hours most days and about 50 different things clamoring for my attention so I can't really stick with one thing for as long as I'd like. :(

Michelle

Hi

There is no includes/advanced_forum_preprocess_forum_list.inc file anymore, so how to change? Using 6.x-1.1.

Thanks,

That file exists in 1.x, just with a slightly different name. I don't remember exactly what it was off the top of my head but it's similar enough it should be obvious. I doubt you'll be able to use this as is since the code has changed but maybe you can adapt it.

Sorry for never getting to this, WorldFallz. Tagging it as an alpha 4 blocker and will try to get it in before then.

Michelle

no worries ;-)

Ok, I tried applying the patch and it actually did apply which surprised me considering how old it is. The only thing it rejected was a bit in style.inc that doesn't appear to have anything to do with this issue anyway.

Unfortunately, I can't get it to work. I added in the js via ctools_add_js("collapse-div"); and confirmed it was there in the page source. I don't know where else to look at this point since I don't know js. Any suggestions?

Thanks,

Michelle

@michelle, I didn't test this patch but I would try adding ctools_add_js('collapsible-div') and ctools_add_css('collapsible-div'). I think as long as the classes are there that should work.

i should have time to look at this today and reroll as necessary....

I added the js... Not the css. Will give that a shot this evening if WF doesn't come up with something before then.

Thanks,

Michelle

I accidentally mixed this in with another change so just went ahead and committed both. That'll make it easier for you to see exactly what I have and maybe see what I messed up to make it not work. :) Will be in the dev in a few hours or just grab from CVS.

Michelle

ok this actually still works with the commits you just made to the current 2.x dev. I had to add <?php drupal_add_js('sites/all/modules/ctools/js/collapsible-div.js','theme','footer'); ?> to the top of the advanced_forum.naked.forum-list.tpl.php file. I have no clue why the ctools_add_js in the preprocess function isn't doing it.

There's also some issues with layout when the divs get collapsed-- i'm looking at it now.

duh... boy i'm slow today, lol. ctools_add_js("collapse-div"); needs to be ctools_add_js("collapsible-div"); ;-)

Well, lookie there. Works great when I've got the right js file. :) Thanks! Filename change committed.

Removing this as a blocker since the layout glitch is pretty minor. But there's still time to get fixes in before alpha 4.

Michelle

ok, i fixed a problem with the backgrounds not persisting, now I'm just trying to figure out how to keep the table cell width from changing when forums are collapsed.

(originally posted this in the wrong issue, lol)

and cross posted, this is just not my day , lol.

No worries. I'm just grateful that you are doing this. I have no js skills at all and this is something that just can't be done without it.

Michelle

happy i can finally help out on af!

here's tiny patch that fixes the missing backgrounds.

Not sure if I'm doing something wrong... I can't seem to click the +/- now without actually going to that container. Are you seeing that on your end?

Michelle

nope--- functionally nothing changed with the patch here. The only difference I see is that the background image works now-- i'm using cloudless day atm, but I'll look at the themes as well. maybe clear the cache?

It might be a firefox thing, too. If I move the pointer just to the left of the +/- it gets out of the link. Maybe add a little space in there outside of the <a></a> ?

Michelle

ah.... I misunderstood the issue. And yep, I'm getting this too-- i'll have to figure out another way to fix the bg problem.

In the meantime here's a possible fix for the table layout.

ok, all encompassing patch that fixes all the little issues-- against current dev.

I confirm the problem spotted by Michelle in Firefox, otherwise i am not sure the column chosen to collapse containers it's the better for design, the first or last column (at the right of last post for example) will be more nice.

I committed the patch and it works but it is still very touchy with accidentally going to the container instead of collapsing it. If possible, I'd really like to see the +/- moved all the way to the far right. I think people would usually expect it there because that's where Vb has it and it would also get it away from the link to avoid accidental clicking.

Thanks!

Michelle

I am agreeing with Michelle.

Subscribe.

Maybe I missed something, Michelle.. But on my patched version (using patch from #171), I see the collapse feature on the main page, but, I now have lost the subforums from being listed under the main forums on the main forum page. Ie:

The Moonlight Way Complaint Department
Bug report, Feature Request

It just has
The Moonlight Way Complaint Department

Is there a new hidden setting somewhere or did something get overlooked in the recent patch/changes? Just trying to figure out if I have an internal system bug again or not.

Jim

*Edit*

Just spotted one other thing, total posts is not pulling the totals from subforums in it's count either. I have 2 posts in a subforum PC under my forum Video Games.. and the totals on Video Games show 0 Topics, 0 Posts.

Ah, you're right, we lost subforums in there. I missed that. That will need to get fixed.

The post count never pulled in from subforums. That's a feature request in another issue.

Michelle

Okay on both parts. I just wanted to double check on the subforums not being listed. I'm in the process of rebuilding my site (had a major failure here and corrupted something or other) and that's when I noticed it missing on the current dev.

And that would tie into where my posts stats went, as the previous build showed everything for me. Thanks, Michelle for checking on it.

Changing the status because this introduced a serious regression that needs to be fixed before alpha 4.

Michelle

I went through the template and cleaned it up a bit so it's easier to follow so make sure you grab the latest if you work on this. I also removed some code your patch added that made no sense. It had a test to see if we were on a container when we're already in the container section and an else that would never happen.

I haven't figured out why the subforums disappeared and can't see anything in this patch that could have caused it. It's possible something else I was working on caused it but I don't know what. It's really late here... Will dig into this more tomorrow.

Michelle

Decided to have one last look and I found it. In this patch you stuck an isset around an if test that breaks it. Removing that fixes it and doesn't seem to have anything to do with collapsible containers as they still work fine without it. Removed and committed that so downgrading the issue settings off of red alert. :)

Ok, looks like the only thing left here is to move the + over to the far right if that's possible. 2.5 years later, we've nearly got it. Thanks, WorldFallz! :)

Michelle

wow-- i was away from the computer for a while. sorry the patch caused such upheaval!

Ill install fresh and give the icons some breathing room. are all your tweaks in the current dev?

That's ok. It's easy for unrelated stuff to slip into a patch. I think I have it all cleaned up so only the stuff related to collapsing containers is there. It's working great in my testing aside from needing to move the icon. Everything I've done is committed. I'm going to switch over to working on the Page Manager integration issues so I'll be out of this bit of code for a while and won't collide with anything you're doing.

Thanks!

Michelle

Shoot, there's another bug reported in #1028342: Sorting with topic works not good . That issue is hard to read so, to summarize, when you click to go to a forum, the container it is in collapses as well.

Michelle

Just noticed another one. If you go to a forum that has subforums, the forum starts out collapsed.

Sigh... I thought we almost had this one.

Michelle

@Michelle sorry for my language :-)

@pawi81: No need to apologize. You write English better than I write Polish. ;) What I said was to clarify, not criticize.

Michelle

I was just getting set to report this myself, Michelle. But, on the positive side, the changes you made did bring back the subforums being shown as they had been. From what I can see, it appears that the method being used for the initial view setting (collapsed vs. expanded) needs to be flipped is all. Sounds like it should be a quick and simple fix on that. I am not at my coding system currently so I don't have the source code in front of me, but if it's set up like a basic C++ on condition, then the check for the collapse is just reversed.

something like:
on enter_forums
display_collapsed_containers
else
display_expanded_containers

instead they need to be flip-flopped. But this not being C++, it may not be as clear cut as that. Maybe it at least gives you an idea where to check for it.

one thing that might be related -- i currently have it setup so that the collapsible state is remembered from page load to page load. I can turn that off if you think it's confusing. that could be the issue here since i don't set the initial state-- that's done in merlin's js.

@WorldFallz I think that I already reported that to Michelle. Thjs is really annoying :)

@WorldFallz: Remembering the setting is fine as long as it only remembers changes you made and on the page you made them. These are the two problems:

* You're on the main /forum page and all containers are expanded.
* You click on a forum (not a container) that has subforums.
* The new page that loads has the forum collapsed at the top even though you've never collapsed it.

Or
* You're on the main /forum page and all containers are expanded.
* You click on a forum (not a container) to go to that forum
* You go back to the main /forum page and the container that holds the forum you just went to is collapsed.

Neither of these are expected behavior. If fixing them requires turning off the remembering, I think that's a better way to go. I'd rather have it not remember the setting than having things collapsing when you don't tell them to.

Michelle

excellent -- i can now replicate what you're seeing. I'm playing around with it now-- i think it's just a matter of what the js is bound to.

i'm still pulling my hair out with this, lol. Removing the "ctools-collapsible-remember" class does make it function as expected, but I think remembering the state between page refreshes is sort of critical behavior as well.

Maybe it's just my thoughts on this, but, wouldn't it make more sense to have the collapse on the sub forum structure rather than the container themselves? As the code is right now, if we enter into a forum, the container currently collapses, goes to the selected forum, then it opens with everything collapsed, where we now have to open the forum up, then if we want a sub forum selection, select that sub forum, it again collapses everything again, switches to that sub forum. I guess, personally, I don't really see the need for the collapse of the forums myself. If it's something that is perhaps wanted by some people, make it an administrator selectable element for their sites? I'm not meaning to come across negatively on the idea, just give us the option of using it or not.

Jim

@greywolfsspirit
And maybe the default option should be "No". On my forum thiss collapsing has no sense. But of course on some forums this is great thing.

The js we are using at the moment is from ctools and it limits how the collapse functionality works. There's not much I can do if use the ctools js-- I'm just trying to find a way to get it to work on the tables the way it would be expected which is nothing more than playing with what elements get certain classes.

i may end up having to use some custom js unless i can figure this out-- i keep thing I'm just missing something in the config.

And you can always turn it off with a your own preprocess function and/or tpl.php file (just remove the extra classes). Though once I figure it out it probably makes sense to make it an option-- but that's really up to michelle.

@WorldFallz: I understand how that goes. Been there a few times over the years programming, and that one line of code that eludes us. You'll get it, I'm sure. Don't get me wrong in my earlier statement, I like the idea, it's a nice feature, but was just pointing out what would seem to be a more logical location for the collapsing to take place was all. I'm not familiar with the code of course, but if the variables are different from a container and a forum inside the container, are you coding it to use the forum variable and not the container's variable in the collapse routine?

My way of thinking on how this would be effective is something along these lines:

Forum Container
+ Forum Name 1
+ Forum Name 2

then if you click on one of those forums, it opens say, Forum 1 Expanded view of all sub-forum names under there at the top of the page, then under it, the list of topics in the forum 1 main forum. Kind of like this:
Forum 1
+ Sub forum 1
+ Sub forum 2

Messages of Forum 1
(forum messages begin here)

If this is the concept you're going for, I think that would function a lot nicer for everyone. Where whatever forum you go to, it shows the branches available under that forum. But as Dennis Miller would say, "That's just my opinion, I could be wrong." :-)

Actually the problem is I'm not coding it-- i'm trying to get the collapse-div.js code from ctools to work with tables. I've tried putting the classes all over the place. The main problem is that in order for that script to work with tables (as opposed to divs) you must use the 'ctools-no-container' class which has the effect of making the entire table the toggle (see the comments in collapse-div.js for more info). So, when you click the link to go to that container it also collapses the div. I've even tried hacking the code in the hopes I could turn it into something I could submit as a patch to ctools.

I got it working with custom jquery in just a few minutes, so I'm not sure why I can't get the ctools code to work.

ok-- i've got this working GREAT with custom js. I've also made it an option at admin/settings/advanced-forum-- including the ability to choose the type of animation (toggle or fade).

i'm crying uncle with using the ctools script to do this-- take a look and let me know what you think.

also, it doesn't remember between page loads but I can always add that if desired.

Custom js is fine. Thanks for doing this! If you can make it remember the state that would be great. Some sites have a bazillion containers and someone might collapse the ones they aren't interested in and like to have it stay that way each visit.

I'm probably not going to get to this until tomorrow. It's my son's birthday and I've got a ton of stuff to do.

Michelle

no problem-- that'll give me some time to add the cookie support. Also, for some reason, it only expands and contracts once, lol. I'll need to figure out what I did to add that feature, lol.

happy bday to him!

ok this one works for more than one toggle, I have no clue what's wrong with the other one-- probably a typo somewhere.

Tried this with the fading and toggles, and it appears to work just fine for me. Granted, I only use one container, but I tried collapsing one of the forums with sub-forums, and upon going back to that forum, the sub-forums did not remain collapsed as expected. But the patch went in without a problem as long as you remember to put the .js file in the root advanced forum directory.

awesome -- thanks for testing greywolfsspirit! And what you saw is the current correct behavior-- it doesn't remember status at the moment. I'm working on that part now.

@WorldFallz: Not a problem.. I'm currently rebuilding my site anyhow, so I can afford to test the modules out at the moment on my test/development system.

Jim

I've ported this patch to D7.

Few suggestions:
- move <img> style from JS to CSS
- jQuery selector $('thead th:first-child') is too general and it can break other tables on page. Consider using $('thead.collapsible th:first-child') selector and add 'collapsible' class to forums' <thead>
- I would also like to see collapse/expand button on the far right side by default
- put advanced_forum.js into js/ sub-folder to keep files structure clean

1. i thought about that but then i'd have to add an empty span to attach it to-- i prefer the current method, but it's really up to michelle.

2. good point! I can grab onto what's already there though: table.forum-table thead th:first-child {

3. up to michelle

4. up to michelle

Thanks for testing-- You should attach your patch!

1. Why empty span? My suggestion is to change
handleHeader.prepend('<img style="margin-right: 10px;" src="' + collapse + '"alt="Toggle" />');
to
handleHeader.prepend('<img class="collapse-img" src="' + collapse + '"alt="Toggle" />');
and add

.collapse-img {
  margin-right: 10px;
}

to advanced-forum.naked.style.css

2, 3 & 4. Agreed.

ah --- i misunderstand what you were recommending. Agreed on #1 as well. ;-)

Sorry, got a bit distracted from this...

I'd like to see the +- button on the far right. That's where it is in other forum software I've used and seems to be the most intuitive place.

js subdirectory is a good idea. I don't like having a lot in the root. I'm big on compartmentalizing things. :)

The other two I don't have an opinion on. Whatever you think is best. :)

Michelle

Attached is my version (D7!) of javascript with per-page remembered collapse settings. This code should work on D6 with minor adjustments in Drupal.behaviour.advanced_forum.

In order to get this JS working advanced-forum.naked.forum-list.tpl.php needs to be patched:
<thead class="forum-header"> to <thead id="forum-header-<?php print $forum_id;?>" class="forum-header">

awesome troky-- i'll tweak this for d6 and should have a patch rolled later today.

Please wait with tweaking for D6. Code above has one big flaw: it uses one cookie per page and usual browser cookie limitation is 20 (I think) per domain. Currently, I am changing code to use only one cookie.
Also, I've removed markup from javascript (<img> and hardcoded image paths) and moved it to tpl and css using <span>. It makes code much cleaner and simpler (toggling is done by adding/removing span class) and it is completely themeable. This code is already in function so I just need to finish cookie stuff and I will release it.

To get a picture:

in forum-list.tpl.php add the following code where you want +/- icon:

<?php if ($collapsible): // $collapsible is set in preprocess function ?>
  <span id="forum-collapsible-<?php print $forum_id;?>" class="forum-collapsible">&nbsp;</span>
<?php endif; ?>

in images.css add the following code:

span.forum-collapsible {
  width: 9px;
  height: 100%;
  text-indent: -9999px;
  display: block;
  margin-left: 10px;
  float: right;
  background: transparent url(images/container_collapse.png) no-repeat center center;

}

span.container-collapsed {
  background: transparent url(images/container_expand.png) no-repeat center center;
}

@WorldFallz: Just give me a heads-up when you need it tested on D6.

Here is new version that saves all data to one cookie and works with modifications in #213.
Available in D7 cvs.

I hope that it will be implemented in D6 soon in ;)

You can check current functionality HERE

very nice troky. The only hold up on the d6 stuff is the fact that d6 doesn't include the jquery cookie plugin. I need to either write the js to do it or we depend on that plugin. For d6, I think I should just write the cookie handling stuff without a dependency on the plugin.

@pawi81 - i'm sure you mean well, but I can't think of anything less motivating than someone saying 'hurry up' when you're volunteering doing something in your spare time. :-( I hope to get to this later today.

@WorldFallz: If you're up for it, I'd prefer not to have the dependency. People complain enough about having to install stuff for AF. :(

Thanks!

Michelle

agreed!

@WorldFallz I'm sorry, that wasn't my intention :) I'm calm down and waiting for new rls, no hurry. I know the volunteering thing well.

by the way you are all doing great job!

@WorldFallz: I agree, take your time and get it right. :-) It's a work in progress and I'm sure we all agree that with the work you and Michelle have done so far is appreciated.

Jim

Tagging because this should really get sorted before Alpha.

Thanks for all the hard work on this. I appreciate it. :)

Michelle

I'm actively working on trying to get troky's code working on d6. From what I can tell there should be little if any changes necessary but I can't seem to get it working. The js loads, there are no errors, the handles appear, but they don't actually do anything. Hopefully I'll get it sorted soon.

FYI I'm trying first using the jquery cookie plugin (so I actually haven't changed any of the code yet). THen once I can confirm it's working in d6, I can remove the dependency on the plugin.

SUCCESS!!!!!!!!!!!

I finally got it working on d6-- seems you also used the jquery 'once' plugin which I had to change to the core 'one' function. Now to get cookies working...

Yay! I've got a couple other things I'm working on and then I should be able to do alpha 4. :)

Thanks!

Michelle

ok, finally. Here we go.

Sorry troky-- due to all the cookie handling involved, I ended up taking merlin's ctools collapsible js and simply modifying it for af. He had already done all the heavy lifting of the cookie handling so I didn't have to rewrite it. It can also be used almost unchanged for d7 (i'll post the d7 patch later or tomorrow).

I've made myself cross eyed staring at and testing this thing-- please test it before you commit to make sure I didn't miss anything, lol.

Few remarks:
- use $forum_id instead $container_number to build collapsible element id because if you reorder forums and reload page it will collapse wrong containers
- use span.advanced-forum-toggle-collapsed instead of span.advanced_forum-toggle-collapsed.
- I don't see per-page remembered collapse settings is implemented yet?

Anyway, nice job. I tried to port my code to D6 but after I found out that it uses old jQuery and no plugins (relevant to my patch) I quit. :)

thanks for the review-- i'll make the changes you recommend.

Also, yep-- i still need to add the per page settings.

And I know what you mean-- i tried to convert your code first but it ended up being easier to just take merlins, lol. D7 will be much nice to do js with!

Sorry for my bad english,

when I click on a Forum, is there forum automatically folded. This is not very useful, it is possible to disable the fold. How can I make this.
It would be nice if you add this to the admin area as a selection.

I thank you for the wonderful work

@fugazi this is an issue which the programmers here workin on it :) be patient please :)

@troky...

$forum_id instead $container_number

I thought i knew what you meant by this, but since looking at the code to implement it i'm not sure. How can i use the forum id-- there can be multiple forum ids per table? If you could be a little more specific that would be great.

Each forum container (that is actually collapsible) has different forum_id that is unique.

Collapsible element id should be unique and persistent... container_number is just counter and gives you partial uniqueness per page but it isn't persistent.

I see what he's saying and I thought that's where the ID was coming from but it's not. Now I'm not sure if I was remembering wrong or if merlinofchaos changed that when he redid that template. At any rate, I'd be just fine with putting the actual TID of the container in the CSS ID for the container.

Michelle

ahhhh... ok ... so you mean change $container_number to $forum_id in the actual advanced_forum.naked.forum-list.tpl.php file?

so you mean change $container_number to $forum_id in the actual advanced_forum.naked.forum-list.tpl.php file?

Exactly.

Maybe I had to write that $forum_id is actually TID for better understanding.

awesome-- ok the first 2 items are done. Just working on the per page cookie using the format from your code. Then I think we'll be gtg.

@Michelle & @WorldFallz: Is the current dev updated with the current patch in #227? Just trying to see if it's ready to test out. Been busy for a few days and been away from my system so I didn't know what the current status is yet. Thanks.

Jim

No, I was a lazy bum last night and watched American Idol. :) Now WF is working on some other stuff so I'm waiting until she has it ready. :)

Michelle

Ok, thanks, Michelle. Not trying to rush anyone. Just since I have a site I can work with to test on, figured I'd offer to guinea pig it for ya :-)

I was just checking, as I saw there was a dev update that came out the other day, and I didn't see the .js file that was created in the previous patch, so I held off installing until I checked in with you all to see what was going on, just in case. I'll hold until given the nod to test again.

-Jim

Here's the most recent patch (including troky's review comments above). This is 95% done if you want to test it out. The only left to do is make the cookie settings per page (its currently per container). I should get that done today or tomorrow.

I forgot to mention this assume the js file is located in an advanced_forum/js subdirectory.

There's also an alert line in the js file you'll probably want to remove, lol. Sorry about that.

Subscribing

I likely won't get to this until Sunday. My son's birthday party is tonight and tomorrow I will be photographing all day. If anyone else can test this, that would be great. Thanks!

Michelle

I'll take a look at it in a couple minutes, Michelle.

@WF: Which version is this being patched against? The dev version or the last release version? I tried installing it and the + for the collapse didn't show up (granted I tried just making the changes against the one patch to the one you just posted, and also got a warning that it couldnt find a file but it didnt show what file it was, perhaps that's the warning you are referring to in the js file? I just re-installed the vanilla dev copy that is current and will try it again in a bit.

Subscribing

subscribing

subscribing

Sorry for the lack of action on this. My dev site is currently mired in mess from the legend background problem and I don't want to mix this in. Looks like greywolfsspirit had issues with it... Anyone have this working? Would be great to have an RTBC patch waiting for me when I'm ready to commit. :)

Thanks,

Michelle

I went ahead and applied the patch on my current dev install. Looking at configuration I see new options for collapsible options for none/toggle/fade. Did get a small reject file from the patch:

***************
*** 19,24 ****
    variable_del('advanced_forum_topic_pager_max');
    variable_del('advanced_forum_get_new_comments');
    variable_del('advanced_forum_use_topic_navigation');
  }
  
  function advanced_forum_update_5000() {
--- 19,25 ----
    variable_del('advanced_forum_topic_pager_max');
    variable_del('advanced_forum_get_new_comments');
    variable_del('advanced_forum_use_topic_navigation');
+   variable_del('advanced_forum_collapsible_containers');
  }
  
  function advanced_forum_update_5000() {

I had to create the js folder manually and move the javascript file into it, however the collapsible forum containers don't seem to work. There is no collapsible icon, and the headers simply act like the normal links.

The only difference I'm seeing between having toggle on or off, is I get a javascript alert that displays the page location when the collapsible option is enabled.

Seems like it needs more work

i've been run over by the flu truck so i haven't had a clear enough mind for this the few days, but the patch should work against the current dev (don't think they're have been any commits since I rolled it). Though it would be good for if someone else could try.

hopefully i'll be able to finish up the per page cookies once the haze of flu meds clears ;-)

After looking through the patch files for a while, as well as Troky's earlier comments, it seems like there's something missing in advanced_forum.naked.forum-list.tpl.php.

It looks like the javascript file is supposed to find the last TH in the row and add the "span" snippet, but it doesn't add this span tag. I added the snippet below in the table heading manually.

if ($collapsible): // $collapsible is set in preprocess function
<span class="advanced-forum-toggle">&nbsp;</span>
endif;

After adding that, two little icons show up, and only one works (the one that is supposed to be created by the javascript file, which now shows up after modifying the tpl... weird?).

Edit: After adding the span manually the first time, which caused the real one to show up, I removed the code and the javascript-created one still remains. Is that because of the cookie code?

I guess the reason it seems to work on your end is that you already had the span generated, whereas when we are attempting the first patch without it, nothing shows up?

I cleared the cookies for the site, and the collapsible icon still shows up now. Really weird.. after first patching it definitely did not show up. Wasn't until I added the toggle span manually that is showed up. And now it shows up even after deleting my cookies, so I have no idea... but maybe this info will help you debug it further 0.o

I wiped out the mess I had and got a clean checkout. When I tried applying the patch, I got "patch: **** strip count o is not a number". Haven't a clue what that means and there's way too much to that patch to do it all manually. Sounds like there's some issues there, anyway, from what Sansui is reporting. Going to tackle the image stuff again and will wait on this.

Michelle

That's weird-- i'll get a fresh checkout and reroll.

I also applied the patch in my dev site. It works fine for me except for that javascript alert (Also tried with deleting the cookies, clearing cache etc).
As part of the collapsible container feature I have a need for configuring the default state also: Collapsed/normal for each forum and based on that initial page load should display the forums.
Will this feature also be considered as part of the module if developed?
As I need to see how to implement it for my requirement. Any comment on this front?.
Thanks.

Configuring default state per forum/container complicates code in way I don't like and I am not eager to do it in current phase of development.

My idea to do this would be creating multiselect listbox on config page with list of all forums/containers and then in preprocess function add 'collapsed' class to selected container variable and adjusting template file to use it. I think javascript doesn't need to be altered in this case.

how to disable this annoying collapsable containers?

Edit the template and remove the classes that trigger it.

Michelle

@torky: Thanks for the response. I will explore the idea putforth for Configuring default state per forum/container.