...but it works fine in Firefox. Could be a setting in IE - what would keep this from working? Pop up blockers are turned off. Thanks!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Starminder’s picture

I was hoping this only affected my home computer, but the same thing happens (or doesn't happen as the case may be) at work, too. IE version is 70.5730.13

Berdir’s picture

Status: Active » Postponed (maintainer needs more info)

Does work fine for me in IE, Firefox and Chrome...

Can you please check your flash versions, are there any differences between firefox and IE? (Go to http://www.macromedia.com/software/flash/about/)

Starminder’s picture

IE was at 10,0,12,36 - so I upgraded Firefox to latest, now it is broken too.

Starminder’s picture

I rolled back to Flash Player 9.0.124.0 (IE) (available from filehippo.com) and it works as expected.

Berdir’s picture

so it is either a bug in the outdated version of swfupload used here or it has to do with http://www.rooftopsolutions.nl/article/205

Starminder’s picture

It appears to be the latter...

Berdir’s picture

Assigned: Unassigned » Berdir
Status: Postponed (maintainer needs more info) » Active

I'm currently working on a new version of the swfupload module which does use swfupload 2.2, this version adds support for flash 10.

I'm not yet ready to release it, there is still quite a bit of work to do but I'm on it. The current plan is to release a first dev version by the end of next week.

Planned Features
- Support for Flash 10
- Provides a link to the classic upload form
- Instant-Preview of uploaded images
- Integration into the edit/create nodes form
- Provide some error messages to the user when uploads fails

Berdir’s picture

Title: Click here to select image is "dead" in internet explorer » Support for flash 10
Category: support » feature
eastcn’s picture

#7
Good idea. If you release the module, I plan to delete photo_swfu. I let photos.module through your flash module swfupload upload.

Berdir’s picture

Status: Active » Needs review
FileSize
51.73 KB

Ok, I think it's stable enough to release a first version...

Please follow the step-by-step upgrade instructions at the end of this post, it is import to do it that way because the module has the same name but a different folder structure..

Current Features
- Flash 10 Support (tested with 10,0,12,36)
- One button to select the images, uploading does start automatically
- Display of the queued images, successfully uploaded images disappear from the queue after a few seconds
- Live-Preview of uploaded photos, each photo is linked to its site and below a link to the album is displayed
- Upload-Errors are displayed if it is a "user-error" like illegal filetype, size, zip files and so on..
- More detailed errors are logged with watchdog
- Flash upload is possible at /photos/upload and /node/-id-/photos (if node is an album or a node type which allows photo uploads)
- Link to the classic upload script and back...
- Flash detection, should display an errors when loading of flash fails (not sure how good this works... )
- Errors, Queue and Preview are displayed as collapsible form fieldsets...
- general.pot and german translation

- (technical) refactored the upload function into multiple methods
- (technical) removed the upload_node function, as it is not needed anymore

Not yet working stuff
- flash upload at edit node / create node forms
- Cancel queue function ( is there actually any need for this ? )
- configuring the look of the upload button

Upgrade instructions
1. Disable phtos_swfu at /admin/build/modules
2. Delete photos_swfu.info, photos_swfu.module and the directory v102demo
3. Upload the folder photos_swfu from the photos_swfu.zip attachment into sites/all/modules/photos
4. Re-enable photos_swfu module
5. (Probably not necessary but to be sure... ) clear the cache at /admin/settings/performance

Please report here if there are problems, questions or feature requests... (or if it does work... :) )

Starminder’s picture

Works perfectly for me so far! Very nice, thanks!

Starminder’s picture

Wait, I spoke to soon. There is an upload destination issue with multiple albums. If I tell it to upload images to album 3, it will report that it did upload to that album, but then when I go look it has actually defaulted to album 1 and uploaded the images there.

It's still a huge improvement though :)

cjeter’s picture

Version: 6.x-1.4-beta2 » 6.x-2.5-beta3
Category: feature » bug
Status: Needs review » Active

I've applied the updated photos_swfu.zip files per the instructions posted above and am still having problems with flash 10. Upon clicking the link "Click here to select image", the file browsing window is never opened. I'm running Shockwave Flash 10.0 r12 in Firefox 3.0.3 on OS10.5.5. Upload does still work on my other computer with flash 9 in Firefox 3.0.3 on WindowsXPS3.

cjeter’s picture

perhaps I spoke too soon also. I went through the install of the new photos_swfu.zip files again. This time moving the .info .module and demo directory completely outside of the /modules/photo directory instead of a backup directory inside of the photo directory. It seems the module was still finding the old versions of the swfu software even inside of the backups directory. Once I moved these files and turned the photos_swfu module back on, things so far seem to be functioning at least somewhat normally. And uploads from my firefox/flash version 10 worked.

najibx’s picture

i'm amazed with the improvement ! Good job ! Yeahh ... it's not putting the images to right album.

Stephane Bouillet’s picture

Title: Support for flash 10 » max dimension & png
FileSize
14.25 KB

Hello,

thank you for your job.
There still some problems if you try to upload an image which dimensions is over of
what specified in /admin/settings/photos:
the uploading will freeze at the end, when creating the thumbnail.

Other problem with PNG images,
some are not visible, or thumbnail appear on the side of cursor instead of up.

Good job !

Stephane Bouillet’s picture

Title: max dimension & png » Flash 10 - Max dimension & png

(just to change title of subjet)

Starminder’s picture

Thanks, working much better now - please don't forget the destination album issue. So far any user with multiple albums is experiencing photos going to the first album created regardless of album selected to upload to.

eastcn’s picture

@Berdir
Great. I suggest that the choice of image, not to immediately upload.

In addition, I will give you send a mail.

Berdir’s picture

Title: Flash 10 - Max dimension & png » Support for flash 10
Category: bug » feature
Status: Active » Needs review
FileSize
49.83 KB

I'm attaching a new version which should solve some issues, thanks for testing and reporting them.

Fixes/Updates

- Updated to swfupload 2.2 beta 2
- Album Selection should now work, there were some issues with the permissions check
- Fixed an issue with images that are smaller than the defined thumbnail size, they should now be displayed correctly
- Some other minor fixes that I don't remember :)

@eastcn: I am not sure if and how this can be done. The whole button "Upload Images" is now a flash applet, this is the only way to be flash 10 compatible AFAIK. And all examples at demo.swfupload.org are starting the upload directly now. I can try to get it working if it is a common need, so anyone should answer if he thinks that there should be a second button "Start Upload" ore similiar... (Maybe a better button text would do the trick, too... I'm open for suggestions!)

@bouddidje@drupal.org: I'm unable to reproduce your dimension problem, please try the new version and describe it as clear as you can if the issue is still existent. I'm quite sure that the PNG issue is resolved, this was about the size not the format. Again, please test the new version.

PS: Please don't change the title, just set the status back to patch (node needs work) if you have problems with the current version (and of course, describe them as exactly as possible)

gatonero’s picture

Hello Berdir,

this must be a hard job for You, thank You for all Your labour.

There are still some bugs

  • Linux, Firefox v3.0.3, Shockwave Flash 10.0 r12
    "Flash upload is taking a long time to load or the load has failed. Please make sure that the Flash Plugin is enabled and that a working version of the Adobe Flash Player is installed."
    "Flash upload is not working? Click here to switch to the classic upload form" -> classic works fine
  • Windows XP, Internet Explorer v7.0.5730.13, Adobe Shockwave Player Version 11.0.0.465
    "Errors...
    Flash upload could not load. You may need to install or upgrade Flash Player. Visit the Adobe website to get the Flash Player."
    "Flash upload is not working? Click here to switch to the classic upload form" -> classic works fine
  • Windows XP. Firefox v3.0.3, Shockwave Flash 10.0 r12
    Flash Upload is working, but to the first directory,
    classic works fine

If You need more informations, tell me.
I like album photos very much

Berdir’s picture

I can confirm that it does not work with Shockwave Player, I'm not sure if a can do anything about that because neither the actual flash upload nor the flash detection script is written by myself. Have to look into that at a later point.

However, it should work fine under Linux, Firefox, Flash 10, it's actually the combo that I'm using to develop it. Try to look into the JavaScript Console if there are any errors reported...

gatonero’s picture

When I opened the page to üpload pictures, I got to errors in JavaScript Console:

1) Error with declaration 'cursor' in photos.css line 108
.photos-vote-sum{
width:70px;
float:left;
text-align:center;
line-height:15px;
cursor:hand;
}

2) Error with declaration 'filter' in admin_menu.css (shouldn't be important here) in line 26
#admin-menu li li { width: 160px; background: #202020; filter:Alpha(opacity=88); opacity: 0.88; }

najibx’s picture

based on my testing, the multi albums works if you go to /photos/upload and manually select album from the pulldown list which "Upload to album: * "

The functionally is not functioning when click "Organize images" for respective album.

TQ

Starminder’s picture

Unfortunately, based on my testing, it doesn't matter which album is selected for upload, the actual photos end up in a different album and then have to be moved manually.

Berdir’s picture

FileSize
13.95 KB

@gatonero

Both are CSS warnings, they don't have to do with the problem. No idea what's your problem, though. If possible, you could try to update your flash version.

@najibx
Thanks for reporting, should be fixed in the new version.

@Starminder
album selection at photos/upload does not work ? Are you sure that you are using the updated version?

Fixes/Updates in the new version:
- Removed swfupload from the zip, each user needs to download it from http://code.google.com/p/swfupload/ now (2.2 beta2 core or newer) (external library policy of drupal) and extract it to the swfupload folder
- Added an information at admin/reports/status if swfupload is correctly installed. If not, the upload form will not be displayed.
- fixed automatic album selection at node/xxx/photos

Updating from a previous version of my photos_swfu module should be easy, just upload and overwrite the existing files.

Starminder’s picture

Updated from the .gz and added the beta2 swf, but no matter what I do, it keeps reporting it is not installed correctly. I think at least for me, a whole new module release is probably in order so I can kill this folder and start over - not sure what I did at this point but I gotta go for a clean start.

everfree’s picture

Hello Berdir,
I use patch(photos_swfu.tar_.gz). Admin upload files successfully,but others fails when users upload a lot of files. Could you tell me what caused it? Does my setting have any problems? Thanks!!

Berdir’s picture

@Starminder
I have to add a README explaining what to download exactly and where to put it. Did you extract the complete content of the core zip file into the folder swfupload ? (Almost) every file in this zip is needed, not only the swf.

@everfree
I'm quite sure this is a feature and not a bug :) At admin/settings/photos, there is a setting (the first one) which defines the number of uploads a normal user can upload at once. The select currently only contains values from 1-10, this should probably be extended for the flash upload.

However, I haven't really tested it and maybe the error reporting does not work as intended in this case. I'll try to test and improve this. Maybe adding an own settings form for swfupload, so that it is possible to set different limits for swfupload and normal upload ( while a limit of 100 files could be fine for swfupload, you would end up with 100 file upload elements when flash does not work for some reason and you have to use the classic form)

Starminder’s picture

Not sure what I did, but I think with previous fixes I likely put something in a wrong folder, it just didn't look right. SO, I killed the folder and started over, and patched back up to this point. photos are now being directed to the correct folder, so I am satisfied - thanks!!!!!!

Addendum - Can no longer flash view images :/

tedbramble’s picture

Thank you!

As a designer (tech challenged), that worked out great and was simple to swap out and fix.

Looks great~

hendrakieran’s picture

can somebody report back if the flashview works with the latest patch? I'm thinking of replacing the original swfupload with this one so just want to make sure first. thanks.

hendrakieran’s picture

I couldn't get it to work, all I get is the "Flash upload is not working? Click here to switch... ", even after scrapping my earlier photos module dir and start fresh by carefully following the instruction. Is there some kind of a checklist that I can go thru to correct this?

BTW, I downloaded the SWFupload package from here http://swfupload.googlecode.com/files/SWFUpload%20v2.2.0%20Beta%203%20Co... and from the photos_swfu.install code i can see that it's looking for swfupload.swf in the swfupload/Flash but after extracting the package, that particular file is located as swfupload/ so only after I moved the file I can get rid of the "SWFUpload not installed correctly" message from the module, but then it still not working for me.

Thanks in advance for any reply on this.

hmorgan’s picture

It appears that the SWFUplad Beta 3 release has moved the location of hte swfupload.swf file. If you go with the Beta 2 instead, that issue should work itself out for you. You can get the Beta 2 here: http://swfupload.googlecode.com/files/SWFUpload%20v2.2.0.Beta2%20Core%20...

Also, I tested the latest photos_swfu patch with SWFUpload Beta 2 on IE with Flash Player 10, and it worked great. However, Firefox with Flash Player 9 did not work. I upgraded to version 10 of the player, and now it works. So, it seems that supporting Flash 10 has meant removing support for Flash 9. Oh well, I guess you can't win them all.

hendrakieran’s picture

I'm no flash expert but this uploading of files seems to be basic function, but why must it use specific flash version to work?

Berdir’s picture

It should work with a flash version newer than 9. If it does not, it's a bug, I need to test that. The problem with Flash 10 is caused by security changes, not complexity.

Thanks for pointing out the issue with the file location change, I'll update that one too.

NeilPorter’s picture

Berdir I just want to say you're a star for all the work you are doing on this module. I've experienced the same as hmorgan, when I updated flash for FF it worked again, so it seems that it was broken for 9 after patching.

hexag’s picture

hey,

really wanting to get this module working, seem to have the same problem as hendrakieran, there's no graphic for the flash upload, adblocker plus, interestingly, offers to block the object, but there's nowt there. I'm using the beta 2 UP1.

If/when I get this is working (question 2), what I'd love for this module to do is this... I'd like to take away the option for users to select the album they upload to & their uploads are automatically put in a gallery of their user name, automating the whole process & hopefully removing any potential SNAFUs.

Cheers for the hard work & help!

Nick,

praresh’s picture

Berdir, I am having the same upload problem as few mentioned above. I tried upgrading flash to 10, updating with the fixes you listed above. But still keep getting "Flash upload is not working? Click here to switch to the classic upload form". Even if I select the classic upload, it doesnt seem to work. Do you have a final version with all the updates you have mentioned above. I am sure I would have messed up something while installing multiple patches. Help please....

Morn’s picture

There is a D6 Branch of the swfupload module which seems to work (http://drupal.org/node/271293) . Can it be used instead of photo_sfwupload?

hexag’s picture

eve morn,

i'm by no means an expert (look at my questions, i'm really flumaxing about finding my feet still), *but*, to hopefully answer your question I've just installed th SWFUpload module, and I must say, it's probably just what I need. The image properties in all these other flavours might not actually be terribly important, as it depends on how & by what your images are being pulled by, in my site, I'm using dfgallery/photo album to achieve my aims & i can get dfgallery to use files from specific path (user based), then that formats everything happily for me. well buddy, that's the theory & i'm busting m'balls trying to empirically prove this. the swfupload module is really nice btw.

cheers,

nick,

Starminder’s picture

Berdir - Is there anything I can try to get flash view working again? Thanks

andersh’s picture

Files added with this new version does not show. It seems that they are referenced without their ending. Forinstance the .JPG ending is missing. The files in the /sites/default/files/photos/image_1/catalog also misses their ending. If I change the URL reported for a thumb from:

/sites/default/files/photos/image_1/t_281107491227879359.

to

/sites/default/files/photos/image_1/t_281107491227879359.jpg

AND renames the corresponding file, the picture shows.

Please advice.

Update: I turned off renaming of images, and it works.

Starminder’s picture

Now that I'm patched to this point, uploading is working corrertly but the flash viewing does not work. Does anyone have any suggestions as to what I can check to get it working? Thanks - please need some help

UPDATE: Nevermind, I am an idiot. I wiped out the whole module directory stucture to start over and left out the part about putting in dfgallery.

sermojohn’s picture

Berdir,
thank you very much for the help, but could you please let me know if this solution should work with
photos-1.3 as well. I m trying to patch my version, but it doesn't seem to work. It always returns the
message 'SWFUpload is not installed correctly'. If you have any suggestions, please let me know.

jagadmin’s picture

Hi,

When I use the flash upload, I get the error

Error on .jpg:

Any idea what is causing this?

maxchock’s picture

i'm using drupal 6.6 ,Album Photo 2.5 beta 3 and swfupload 2.2. i've follow the instruction about the fix for Flash 10 compatibility on #26 but I still get the "SWFUpload is not installed correctly" error message. the error message is very vague and I've no idea what goes wrong.

can someone provide a list of checkpoint which so I can diagnose 1 by 1 to find out my problem?

Thanks.

Max.

maxchock’s picture

I found the solution myself for #47. The problem is because I've install swfupload 2.2 beta 3 which is too new, and the swfupload.swf is in different location. so either u can install swfupload 2.2 beta 2, or follow steps below if you really need 2.2 beta 3.

1- copy every file from swfupload 2.2 beta 3 to /site/all/modules/photos/swfupload/
2- copy again the every file from swfupload 2.2 beta 3 to /site/all/modules/photos/swfupload/Flash/

using beta3, my IE can run without error on the far bottom left.

Starminder’s picture

Version: 6.x-2.5-beta3 » 6.x-1.4-beta3
Status: Needs review » Active

I upgraded to 1.4 beta 3. On flash upload, the "select images" button is gone.

eastcn’s picture

FileSize
9.35 KB

#49

Please clear the cache.

chakrax’s picture

Clearing the cache exposed the "Upload" button. However in Firefox, the job just hung after the first picture. It worked in IE. I think I have Flash 10 in FF, since it was broken before beta3. I have Flash 9 in IE.

Starminder’s picture

Status: Active » Fixed

I reinstalled it and the button showed up. Upload worked fine for me, thanks!

I was wondering if since this was my open case and there is quite a bit going on, can we now consider this resolved / fixed and then if anyone else is having trouble have them open a new case? thanks!

chakrax’s picture

Wanted to report back that after I reinstalled flash in Firefox, upload doesn't stall after the first image. Issue is resolved for me.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

likewhoa’s picture

Status: Closed (fixed) » Active

i like to reopen this issue as I can't get this working with drupal-6.8 and -dev copy of photos modules and link from http://drupal.org/node/324497#comment-1102758
what I am getting is "Flash upload is not working? Click here to switch to the classic upload form"

Lityi’s picture

likewhoa - as far as I experienced, logging out and in solved the problem.

Don't forget to dl the swfupload from the Google repo (http://code.google.com/p/swfupload/), copy the .zip content into modules/photos/swfupload.

Maybe clearing the cache at /admin/settings/performance would be nice, as well.

Works perfectly for me.

Thank you all for your kind help to resolve this issue!

likewhoa’s picture

I've done most of the steps to rule stuff out, I have not tested with another browser like IE but I will have to since that would rule out FF on my end.

hendrakieran’s picture

Version: 6.x-1.4-beta3 » 6.x-2.5-beta4

I'm on 6.x.2.5-beta4 and the flash upload stopped after the first file on FF 3 and Flash 10.

chakrax’s picture

@hendrakieran: It's probably this issue: http://drupal.org/node/357168

radiofranky2009’s picture

I think a lot of users might have older flash player, maybe is a good to add a URL link below "upload" bottom
"click here to get the latest flash player" so that users might stop wondering and get mad - how do i upload the damn photos? :)

my two cents,

Starminder’s picture

I think if there were a single new release (not 6x1x and 6x2x) instead of patches we could probably put this now lengthy topic to rest and all get a clean start :) Just my two cents!

eastcn’s picture

Please try 2.6-x ...

Starminder’s picture

Status: Active » Fixed

No longer having this issue

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

smartango’s picture

Status: Closed (fixed) » Needs work

I tried I got:
Upload of 02.jpg failed,
Fatal error: Call to undefined function _photos_check_path() in /home/mhd-01/www.redtendaggi.com/htdocs/sites/all/modules/photos/photos_swfu/photos_s... on line 277

I replaced with photos_check_path() (without _ ) I got:
Error on 03.jpg:

(no description)
this in http://drupal.org/project/photos 6.x-2.6-beta3

Nathaniel’s picture

Status: Needs work » Closed (fixed)