Configure multiple images for project nodes

This is a d.o configuration issue, not code for project.module.

Moving to the Redesign project. Check here to see who has been assigned to implement this section and the staging server it'll live on during implementation: http://groups.drupal.org/node/37064

Moving to new section-specific component for the Orchestrateam guys to pick up.

Imagefield has been on for some time.

drumm was a bit confused. he meant "image attach", not imagefield. Even though image attach has been on for some time, it's totally broken. See:

#460750: Cannot change the main image on my project
#669098: A way to delete and attached image on module project page
#799818: Best practices for screenshots on project pages?
...

Furthermore, the redesign mockup for project pages calls for multiple screenshot images for each project, not just a single image like we support now. That's the point of this issue.

We have imgagefield & imagecache now.

If nothing else, the migration to Drupal 7 can handle this. It would still be nice to get this done in Drupal 6 because it fixes the bugs mentioned in #5 and makes sure we have the UI details figured out.

Adding a finish line and a smoke test URL.

Attached are the combined patch for this and feature for the field. This is working on a dev site, http://project_img-drupal.redesign.devdrupal.org/project/service_links and http://project_img-drupal.redesign.devdrupal.org/project/bad_judgement.

This update does take awhile, there are just under 4000 project images. And it is destructive, it actually removes the now-unused image nodes. I'll be testing it again and watching closely on staging. For deployment, we should first disable the "attach images" permission so no new images show up while migrating.

This is now running on staging:
http://staging.devdrupal.org/project/service_links has multiple images
http://staging.devdrupal.org/project/bad_judgement has a cat

I think this is ready to deploy.

Deployed. The feature didn't turn itself on properly, so we did lose project images. I restored them using data from staging.

Not all project images appear to have been restored. Compare http://drupal.org/project/unitag vs. http://webcache.googleusercontent.com/search?q=cache:31lkCBF9PsAJ:drupal...

-K

Hi,

A number of my themes lost their 6.x branch. Not sure if it was related to this change, but the timing is either suspicious or a coincidence.

For example, one of my themes with this problem was recently updated by this item:

http://drupal.org/node/1233258/revisions

Any idea?

Oops, my bad. Sorry, I made a mistake. Please ignore me.

drumm,

For my projects - the ones that were having only one screen shot all is fine ( http://drupal.org/project/pixlr http://drupal.org/project/nodefeedback http://drupal.org/project/cache_external_files ); the ones that were having more than one screen shot - all of them are gone ( http://drupal.org/project/ulogin http://drupal.org/project/imageeditor ) - can we fix it somehow as I have already lost the images itself and will need to redo them...

Thanks
AndyB

Why weren't affected page owners (i.e. module owners) warned about this?! I had 4 modules and Saturday they all suddenly appeared in my list of updated pages (in the section "Your Posts") and they all lost all their images!! I was in the bath at the time (iPad, ahem), and could have drowned with shock ;-) !!

The 4 modules are:

• http://drupal.org/project/vchess (all the images are still gone)
• http://drupal.org/project/alexa_widgets (seems OK now)
• http://drupal.org/project/urs (seems OK now)
• http://drupal.org/project/tsort (seems OK now)

I of course immediately raised an issue http://drupal.org/node/1572922 (I didn't find anything when I looked if others had the same problem), where silverwing helpfully pointed me to this thread. I also now see that in the page revision history its been added:

"11/05/2012 - 20:03 by Anonymous (not verified)
Migrating images, see http://drupal.org/node/371999"

Most importantly, when is my VChess module going to have its images back?! (As for duozersk, this module had many images, whereas the other modules only had a single image)

Thanks!

drupalshrek
Maintainer of the VChess module visible in use at chess website Chesspos.com

@drupalshrek:

Why weren't affected page owners (i.e. module owners) warned about this?!

Because there weren't supposed to be any changes visible to project maintainers other than seeing the project nodes show up in their tracker (and the revision message was supposed to help you understand why that happened). Something went wrong with the deployment, and some things got messed up. If drumm knew ahead of time there was going to be a problem, he would have fixed it so there wasn't a problem. Either way, "warning" project maintainers wouldn't have made sense. ;)

Anyway, mistakes happen. I'm sure drumm and the rest of the infra team are going to do whatever they can to restore the lost images. It's not like we just deleted all your code. A few screenshots are missing and they'll be back ASAP. Meanwhile, I suggest taking a few deep breaths and trying to relax. Being this stressed out about a few images temporarily missing can't be good for your health.

Cheers,
-Derek

OK, thanks Derek!

I've confirmed that the images themselves do still exist on our dev sites, for example http://project_img-drupal.redesign.devdrupal.org/files/images/unitag.png for http://drupal.org/project/unitag. I disabled out job to sync those, which could have deleted them in the future. Usually, it runs every 24 hours, so I expect we won't actually lose too many.

I'm going to work on restoring all of these. That means you will get a duplicate image if you manually upload a new copy right now. Please wait for me to restore the images, or be prepared to remove duplicates later.

A summary of known project pages with missing images would be nice to have.

Hi,

Here are mine which are missing images:

http://drupal.org/project/tma
http://drupal.org/project/composite

Hi,

http://drupal.org/project/blockquote is another example of missing image. Also the addition of the tag “Under active development” seems to have moved from 25/07/2010 revision to the latest revision.

The edit page http://drupal.org/node/282670/edit has two rows under Images: both blank: does it think one (or both) has data?

Thanks for looking in to this.

Out of my projects, the following are now missing their images:

http://drupal.org/project/ad_agency
http://drupal.org/project/coder

Neil (drumm)! You are the man! For my affected projects (uLogin and Image Editor) all the screen shots are back. ;)

Thanks a lot for the job nicely done!

AndyB

This should be fixed now. I checked these projects from comments here, and others I noticed:

• service_links
• tma
• composite
• blockquote
• unitag
• ulogin
• imageeditor
• vchess
• ad_agency
• coder
• controlpanel
• sandbox/pp/1244926

Everything was done in batches, so all 969 missing images should be restored.

Anyone want to try out the issues linked from #5 here? The move from image attach to an image field should fix things up a bit.

Neil,

For the 3 issues linked in the #5:
#460750: Cannot change the main image on my project - I tried reordering of the images on the project edit form - and it works just fine, showing the images on the project page in the order you define on the edit form. If this is the point of changing the main image (making it the first one) - then this is fine.
#669098: A way to delete and attached image on module project page - Didn't try deleting any images... as I don't really have one to be deleted. But it should be fine as we are now on the Imagefield, right?
#799818: Best practices for screenshots on project pages? - never had this issue with previews... most likely it was fixed even with the old screen shots handling architecture.

But I still noticed one issue regarding the project teasers on the project listing page (http://drupal.org/project/modules and alike) - they are missing the image; previously it was showing one image (not sure which one exactly, probably the first one uploaded). Do we plan on keeping this feature? Let me know if this one should be moved to another issue.

Hope it helps ;)

AndyB

Images are back for my project also. Issues in #5 appear to be fixed.

Here is also related issue about missing images on project listings #1573076: thumbnails in the themes' list

Images are back for the VChess module. Thanks Drumm!

drupalshrek
Maintainer of the VChess module visible in use at chess website Chesspos.com

Images have returned! Thanks.

The image title however, is missing from the view page, although the description is on the edit page. (alt text is fine.)

I fixed:

• #26 and 28 reported project listings no longer having images.
• #27 reported downloads heading getting separated from its table.

#30: I left the title enabled in case we want to do a fancier gallery in a followup issue. This could be done with a view. I think it is out of scope of this issue since it was about changing how existing functionality was implemented.

I'm a bit confused by your comment re. #30 – the <img> tag has title="", whereas it used to have the description in this attribute; see http://webcache.googleusercontent.com/search?channel=fs&q=cache:9i2TXjZb... (11 May).
(If you remove 'thumbnail.' from src attribute, you will see the image with tooltip title.)

I was mistakenly thinking of a title that would be shown next to the image. We do have the image description, which is currently enabled, but we don't do anything with it. We don't have the title attribute enabled, which I think is okay since we have alt. We don't want too many text fields getting in the way of simply uploading images. I only found one string to migrate from old images, and that's in both the description and alt text.

A good followup issue would be showing the image descriptions somewhere.

If a project maintainer has used the Resources: Look at screenshots field, to link to an image – that link might now be broken by this issue.

In that case, node/N/edit is their friend. ;)

Yes, of course, I forgot to put the remedy in my comment. My concern was that no-one would fix it until they realised it was broken.

Image filenames (might) have changed.

… sorry for shouting.

s/project_issue/project/

...accidental issue title change?