In order to fulfill requirements of a customer, I have written a webform_add_ons module that works well with the 2.3 version.
I would like to contribute the functions that the module include to the community, however I do not know which ones are really of interest to everyone. There's also the question of "how to". Some of these should clearly be submitted as patches but I guess some of them should be submitted as submodules (for instance, survey translation is dependent on the translation framework and we would not want the webform module to be dependent on it).

webform_add_ons module has its own install file and it adds the following functions to webforms:

- Translation of surveys to different languages using the translation framework (http://drupal.org/project/translation_framework)
- Survey templates that allow re-use of surveys to create new ones; copy option.
- Survey drafts (I see that there has already been some arguments & commits on this issue)
- Addition of percentages to the analysis section
- A separate setting to control which roles can view the results of a particular survey.
- The ability to sort the results by country
- Open/close survey tabs.
- Available surveys block (checks organic groups, post to associates), removes completed surveys from the block.

Committing the whole code (2.3 compatible) as a separate module is the easiest option but I think it is better to keep (at least some of these functions) inside the webform code.

I would appreciate any direction on how to proceed (patches/submodules per each functionality). Following the responses, I will create & commit 2.6 compatible patches/submodules.

EMRE

CommentFileSizeAuthor
#2 webform_add_ons.zip13.41 KByarimbiyik
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quicksketch’s picture

Hi yarimbiyik, all this sounds rather interesting. As you said, there's already several issues open for many of the items you posted about. I agree getting most of these changes into Webform would be a good thing. I think the first step is to post what code you have, then I can take a look at the approach you've used. For most of these features, I'll probably want things more generalized than what you've put together so far (if previous experience on client-work tells me anything).

I'm extremely, extremely busy, and despite having maintained it for 3 years, I don't actually use Webform (other than my simple contact form on my blog), so I'll probably be slow to answering most of these requests. But please post what you've got and I'll take a look as soon as possible.

yarimbiyik’s picture

FileSize
13.41 KB

I attached the code as it is < for 2.3 > ..
I agree with you on the necessity of generalization. I even had to use the term "survey" instead of "webform" in the messages shown to the user.
A code clean up will also be done in the following commits.

shadowdknight’s picture

Is this work for 6.x-26?

Thanks

vnadasan’s picture

Hi yarimbiyik,
These additions were exactly the things I was looking for. Let me know if you've done the clean up. I tested the submodule as it. I got some errors, nevertheless I know that's what I need. It would be wonderful to have it completely functional.

yarimbiyik’s picture

Hi vnadasan and quicksketch,
Vnadasan, have you actually had these errors at 2.3 version? I have not tried it on 2.6, so it is normal for you to have errors there.

The module is a big one and making it all work for 2.6 is not a good solution because when 2.7 is published similar effort will have to be spent. I will try to submit parts of the code as patches either to 2 or 3.dev branch. It looks like branch 3 is the way to go, correct, quicksketch?

quicksketch’s picture

Yes, the 3.x version is the way Webform will head in the future. The features mentioned in this issue will not be implemented unless they are split up and submitted separately as patches.

quicksketch’s picture

Status: Active » Closed (won't fix)

Please reopen if interested in filing these as separate issues. As a large chunk, these are not feasible for review.