Incompatible with Ubercart 2 VAT support

uc_discounts_alt should be calling uc_price() rather than uc_currency_format() to ensure the VAT alterer modifies the price correctly. But I'm not currently sure what context you should be calling uc_price() with, and this will have to be done carefully as tax may need to be calculated differently depending on whether the discount applies to an individual product or the full order - see #475474: Price alterer contexts and VAT support for the current discussion on this in Ubercart core.

@ryan, VAT works the same as taxes, this is what i did:
1/ created a tax rule for all products, add 21%
2/ created a discount buy 2 one for free ('2 + 1 gratis')
3/ created a product with sell price 10
4/ product page shows 12,10 as price (dev load shows 10), so VAT is added
5/ added 3 items to cart, the cart shows The discount, '2 + 1 gratis', was applied for a discount of 10,00€. (should be 12,10) while the cart line shows the price including VAT
6/ checkout
- shows price = 30, vat = 6,30, total = 36,30
- enter discount codes pane shows The discount, '2 + 1 gratis', was applied for a discount of 10,00€. (should be 12,10)
- order total preview pane shows
Order total preview:
Subtotal: 30,00€
Afhalen: 0,00€
Total discount: -10,00€
Subtotal excluding taxes: 20,00€
21% BTW: 6,30€ (should be 4,20)
Order total: 26,30€ (should be 24,20)

7/ checkout review shows
Subtotal: 30,00€
2 + 1 gratis: -10,00€
Afhalen: 0,00€
Subtotal excluding taxes: 20,00€
21% BTW: 6,30€ (should be 4,20)
Total: 26,30€ (should be 24,20)

8/ same results on store/orders/nid

I hope it helps, if not let me know

So the discount calculated by uc_discounts_alt is consistent, it just doesn't take into account VAT.

Since VAT is a tax, it seems like the VAT module should work like uc_taxes. In uc_taxes you can specify which line items each tax is applies to (it's a setting in each tax rule as "Taxed line items"). If the VAT module worked like uc_taxes, you would tell the VAT module to include "Discounts" line items in its calculations. Then VAT would be correctly calculate at 4,20 because it would add 21% to 20 (30 + -10).

Ask Longwave what he thinks about this. Thanks!

Actually, I'm not sure how this will work when discounts apply to multiple products. If you have a taxed product at $10 and an untaxed product at $10, then you give a $10 discount when both are purchased together, I'm not sure what the correct tax calculation would be in this case - if the discount is"buy X get Y free" then this is a different calculation to "$5 off each product". How does uc_discounts_alt currently handle this?

Hi,

I have this problem as well. I'm trying to use the VAT module for Australian GST.

I'm going to try and hack the module to get it to work for me. Has any work been done on this problem before I start?

It also shows as a problem on the product page. The discounted price shown for the product uses the price without GST as a starting point. Also I notice from a brief look at the code sometimes $product->price is used and sometimes $product->sell_price is this meant to be that way?

Thanks for your help. I'll let you know how I go.

Andrew

Updated patches to match 6.x-1.0-beta36.

Updated patches for 6.x-2.x-dev

The Patch works for me - but there ist another problem with VAT for European Stores into the cart pane:

If you activate a percentage discount for the total order - the discount is calculated in the cart pane by subtotal without VAT.

In germany - like European Stores to - we need to calculate the discount for customers from the subtotal with VAT.

This example show what I mean:

you have a percent discount of 10% of Total Order.
The VAT for each product ist also 10%.

Product A and B costs each 10,- EUR without VAT and 11,-EUR incl. VAT

The customer see on the cart pane:
Product A 11,- EUR (incl. VAT)
Product B 11,- EUR (incl. VAT
Subtotal = 22,- EUR (incl. VAT)

If I activate a 10% discount to subtotal actually is following cart pane shown:
Product A 11,- EUR (incl. VAT)
Product B 11,- EUR (incl. VAT)
Subtotal = 22,- EUR (incl. VAT)
Discount= 2,- EUR (=> The Problem: The Discount is calculated from Subtotal without VAT)
Subtotal incl. Disount=20,- EUR (incl. VAT)

The correct Cart pane would be:
Product A 11,- EUR (incl. VAT)
Product B 11,- EUR (incl. VAT)
Subtotal = 22,- EUR (incl. VAT)
Discount= 2,20- EUR (=> 10% from Subtotal incl. VAT)
Subtotal incl. Disount=19,80 EUR

The checkout pane works correct and calculate the discount from the subtotal incl. VAT - if you apply VAT to discounts in the UC VAT Module.

There's another problem with the calculations when there're products in the order with different vat rates.

There's an option in the vat rate configuration form to include the discount line in that rate calculation. This is correct.

An example:

Price without vat: 100
vat 16%: 16
Price with vat: 116

Applying a 10% discount ->
Price without vat: 90
discount without vat: 10
vat 16%: 14,4
discount with vat: 11,6
Price with vat: 104,4

So, 116 - 11,6 = 104,4 that's correct

But, to include the calculations of the other vat rates in the discount line I need to check that option in the corresponding vat rate configuration form and then the module calculates the vat amount over the discount though there isn't any item of that kind in the order.

In a try to solve this with ca, I've added conditions to every vat rate that limits the product classes this calculation applies but it doesn't work as expected.

Example:
vat rate: 16% applied to products class A and discount line.
Conditional actions for 16%:
Conditions: Product is class A
Actions: Apply 16%

vat rate: 7% applied to products class B and discount line.
Conditional actions for 7%:
Conditions: Product is class B
Actions: Apply 7%

Order with:
1 x Product class A
Price without vat: 100
discount 10%: 10
New price without vat: 90
vat 16%: 14,4
Discount with vat: 11,6
Price with vat: 104,4

1 x Product class B
Price without vat: 2
No discount
vat 7%: 0,14
Price with vat: 2,14

Checkout:
Must be:
Subtotal: 118,14€ (vat incl.)
Total discount: -11,60€ (vat incl.)
Subtotal vat excl.: 92,00€
VAT 16%: 14,40€
VAT 7%: 0,14€
Order total: 106,54€

But, it shows:
Subtotal: 118,14€ (vat incl.)
Total discount: -12,30€ (vat incl.) (wrong!)
Subtotal vat excl.: 92,00€
VAT 16%: 14,40€
VAT 7%: -0,56€ (wrong!)
Order total: 105,84€ (wrong!)

Because it was calculating the 7% vat rate over the 10 € discount of product class A (0.7), too and substracting it from vat 7% (0.14) (0.14 - 0.7 = -0.56) and adding the 0,7 to the real discount of 11,6 (11,6 + 0,7 = 12,30)
The conditions in vat 7% conditional actions says that only must be calculated if product belongs to class B but this isn't taken into account.

Hi,
is there something new regarding this patch? It would be really great to have UC_discount_alt working correctly with VAT like in #17 from miguel_angel described.

Thank you in advance.
yours
ingolf

Hi,
I also run into this problem. Has anything been made on this.

br,
gapa

Right, I've got a patch which seems to be working okay for me for both issues.

One thing to note is that you need to de-select the discount line item on the tax rate page.
The reason for this is we don't want tax to be added to our discount, as we've already included the tax using the uc_price() function.

I've tested it with an order consisting of two items with different tax rates and discount rates applied.

ITEM 1
PRICE £6.04
TAX 17.5%
DISCOUNT 6%
QUANTITY 5

5 * (6.04 + 17.5%) = 35.49
Discount: 35.49 * 0.06 = 2.13

ITEM 2
PRICE £20
TAX 10%
DISCOUNT 50%
QUANTITY 3

3 * (£20 + 10%) = £66
Discount: 66 * 0.5 = £33

Subtotal: 35.5 + 66 = 101.5
Discount: 2.13 + 33 = 35.13

Order total: 101.5 - 35.13 = 66.37

This works for me.

Let me know if there's any probs. Also, I havent tested this out without using the vat module. It should work the same as uc_price() will then get the price exc tax, and you could tax the discount by selecting this line item on the tax admin page.

Thanks

Leon

hi gapa,

On the invoice you get the items price and then the total discount below it, the same as on the cart and checkout review pages.
You want the item price to include the discount rather than listing them separately? Isn't that a bit misleading as you're not showing what the normal cost of the product was (plus losing the opportunity to show what the customer saved in discounts).

Anyway, the invoices are php files so I guess you could use the uc_price() method inside them to work out the discounted price.

Thanks for the patches but, with both patches #23 and #24, I got the message:

patching file uc_discounts.module
Hunk #2 succeeded at 955 (offset 15 lines).
patch: **** malformed patch at line 56: @@ -1387,25 +1422,25 @@

Thanks

gapa,

this one worked
you saved my day, thank you!

Hi Gapa,

Thanks for your update.

Can't imagine it has to do with the patch but for some reason the field discounted price disappeared.

Hi Joachim

I attached the patched versions of uc_vat and uc_discount_alt.
As far as I can see so far it works as aspected.

Paul

i tried uninstalling the module
unchecked it in the module section, deleted the files, ran update.php

reinstalling it
upped the files you gave me, checked discount box in modules section.

my discount rules are still there
and it still isn't working :((((

i tried searching in the admin/store/settings/taxes page
i have three taxe rates one for books, one for magazines, and one for normal product

when in one taxe rate i check the taxable line item option "discount"

it works on checkout but not in the cart

if i check the taxable line item option "discount" on the second taxe rate

on checkout it outputs two taxes (see pic for discount checkboxes)

can anybody tell me what does the "taxable line item" do ? what are "empty line" and "taxe" options for ?

Is there a way to make this work ?

I feel i'm missing something

thanks to all

Found another issue. In the attached picture you can see two product with same discount (50% off). Why are this two products rounded differently? If I divide original price (this is VAT inclusive) I get 2,295 and 3,755. As I can see this two are rounded differently. I also tried to do this calculation without VAT inclusive prices and I still get to same result.
I also am trying to get discounted price into invoice template. And as far as I could do I used this code to pass another parameter into ordered products. And "discounted_price" is 2.29 and 3.76. Why is this different than in product display page? I just can't figure it out. To be honest, I am not a coder so I don't understand completely how things works. Any help is welcome.

Thanks for answer leon.nk.
I will check rounding problem and report back what I will found.
As for invoice template. I don't know if tokens are meant to be used this way. Cause every product that would have discounted price should also have it's own token. Or did you have any other idea implementing this?
That's why I thought it would be best to attach discounted price to products that are in order. So I could go through order->products array and display original sell price and discounted price (if product has discounted price). And also total price without discount and total price with discounted price.

br,
gapa

I have looked at your patch and I think that it doesn't include your new patches. Could you please have another look at this?

br,
gapa

Re uploading this *** patch :p
I don't know if it's the best way to share this function, I think the Drupal way is to create a module for this. But as it's a very basic function, I used this.
About your issues, I didn't get this problem yet but I will let you know...

Hi,

Sorry to be a pain but any chance somebody could post a patched version of this module. Having spent a few hours (as a non programmer) trying to work out how to apply a patch under windows (yep I should probably be running Linux, I'll get there one day) frustration is kicking in and i am getting no where. This might be a simple process for most people but not here, it would be a big help if I could just grab the already patched mod from somewhere and upload it.

Thanks a lot to anybody that can help, and to everybody for solving these issues.

Andy

I see these get_ucprice patches has been applied to the latest dev version of uc_discounts_alt - also VAT support "almost" works.

I tested on a test site - purchasing 3 items costing a 100 kr. (80 kr. without VAT) and a discount of 30 kr. if 3 is purchased.

The total became 270 - so that was correct, but the VAT amount was still 60 - it should have been 54 (the 6 deducted as the discount amount (30) is 24 + 6 in VAT).

the patches with get_uc_price returns a price of 0.

I tried to fix it up - and the below works, except VAT is NOT applied. I can't seem to figure out why :(

function get_uc_price($item) {
$price_info = array(
'price' => $item->price,
'qty' => $item->qty,
);
$context = array(
'type' => 'cart_item',
'revision' => 'altered',
'field' => 'price',
'subject' => array(
'cart_item' => $item,
'node' => node_load($item->nid),
),
);

return uc_price($price_info, $context);
}

I fixed it - you need to feed it a proper item - or perhaps try to change from cart_item to line_item - I haven't gotten line_item working yet though.

+1 subscribing

Can we port a final version of all working patches from above that work with the current uc_vat dev, please?

The discounts and VAT support are a difficult problem to solve for all cases of use (and all countries).
Perhaps the solution is that any module that alters prices must have a price alterer function and find the right order to apply them.

Meanwhile, I've wrote a patch to uc_discounts_alt (6.x-2.x-dev 2010-Aug-24) that handles discounts in orders with mixed VAT rates.
The solution calling uc_price contributed in this thread doesn't work for me.

This patch creates a different line item per vat rate, so you can assign in VAT settings the right discount line item to each vat rate.
For this to work, the discounts created must no mix products of different vat rates.

You can have a vat rate for products class: A, B, C and discount line item "VAT rate 1"
other for products class: D, E and discount line item "VAT rate 2"
and a discount that qualify for products class A, B or C
other discount that qualify for products class D or E
but not discounts that qualify for products B or D, for example (due to different vat rates of B and D classes)

I've tested the patch with modules:
uc_vat, uc_taxes, uc_discounts_alt enabled
uc_vat, uc_taxes disabled and uc_discounts_alt enabled
uc_vat, uc_taxes enabled and uc_discounts_alt disabled

This isn't an elegant solution, but it works.

Please, feel free to try the patch and your feedback is welcome.

@Peter76: Why would anyone send those patched files to you? Think broader, think about the community and ask to port those patches to dev. That way you will get your patched files, the rest of the community could test it and the maintainer will get more feedback.

@Peter76 I believe what @madjoe was getting at, is that this is a community project and the efforts of people like yourself could benefit everyone else.

So instead of waiting around for someone to make the patch for you. You could have taken the time to understand how to manually apply a patch. These patches were relatively small and would have been good experience for you. However, me being the nice guy that I am. I went ahead and created a new patch file for you.

I even took an extra step and hunted down a post here on Drupal.org that explains how you can help out by reapplying patches manually. Then all you would have to do is create a new patch file for everyone else to use.

Apply a patch file manually
Create a patch file
Apply a patch file

For testing, I've just checked out the latest release from the CVS head which appears to incorporate the above changes but I'm getting the following error code:

It would appear that 'uc_discounts.module' around line 1950 has some code which looks out of place and is effecting the function 'uc_discounts_add_discount_rate_id'.

I'm happy to post my copy 'uc_discounts.module' if that would help.

Hi all, I've just downloaded the 6.x-2.x-dev version of Ubercart Discounts (Alternative) and tried to manage a term based discount but occurred in the problem described here: the discount is applied before taxes, which is not correct here in Italy. Actually the taxes are managed correctly by Ubercart 2 VAT support module.

I've read the whole thread, even the links posted by davexoxide about patches, then tried to apply patches both manually and using the Eclipse tool, but it seems to me (consider that I'm not an expert), that the patches aren't suitable for current 6.x-2.x-dev release (like stated in the previous post too).

Is there any chance to port the fixes in the -dev version ?

To #68
Doing a manual patch (manual for search the strings to change) of uc_discounts.module and using code from #30 works for me.

uc_discounts.module is at: sites/all/modules/uc_discounts_alt/uc_discounts

Using 6.x-2.x-dev

There's still a problem with patch #30. The sub-total and total price is correct now, but if you enable "Show VAT amounts in separate columns at checkout." (admin/store/settings/taxes/vat) the VAT amounts ignore the discount(s).

Example and difference between uc_discounts_alt and uc_coupon (which has a special fix for uc_vat):
1 x Product (incl. 19% VAT) - 4,99 €

uc_coupon:
Sub-total: 4,99€
Coupon (20%): -1,00€
Shipping (incl. 19%): 5,95€
Total: 9,94€
incl. 19%: 1,59€

uc_discounts_alt:
Sub-total: 4,99€
20% discount: -1,00€
Shipping (incl. 19%): 5,95€
Total: 9,94€
incl. 19%: 1,75€

Now an example with two products and two different VATs:
Product-A (incl. 19% VAT) - 4,99 €
Product-B (incl. 7% VAT) - 29,00 €

uc_coupon:
Sub-total: 33,99€
Coupon (20%): -6,80€
Shipping (incl. 19% VAT): 5,95€
Total: 33,14€
incl. 7%: 1,52€
incl. 19%: 1,59€

uc_discounts_alt:
Sub-total: 33,99€
20% Discount: -6,80€
Shipping (incl. 19%): 5,95€
Total: 33,14€
incl. 7%: 1,90€
incl. 19%: 1,75€

As you can see everything except the VAT amounts are identical. The VAT amounts ignore the discounts in uc_discounts_alt. I think the solution can be found by looking in the last changes of uc_coupon, because they had the same problems before.

Update:

uc_vat supports a 'tax_adjustment' callback. Take a look into the 'uc_vat_line_item_price_alter' (uc_vat.module) function: $callback = _line_item_data($line_item['type'], 'tax_adjustment');

and uc_coupon registers that callback:

/**
* Implementation of hook_line_item().
*/
function uc_coupon_line_item() {
$items[] = array(
'id' => 'coupon',
'title' => t('Coupon discount'),
'tax_adjustment' => 'uc_coupon_tax_adjustment',
'weight' => 0,
'default' => FALSE,
'stored' => TRUE,
'add_list' => TRUE,
'calculated' => TRUE,
);
return $items;
}

hello,

I have tried many configuration, patches, modules versions ..etc and i just cannot get to the right calculations in the checkout. It's a shame because discounts are actually not usuable for European shops right now. At least I haven't found a solution.

I would be happy to sponsor a development to solve the problems between uc_vat and uc_discounts_alt
Contact me if you are interested.

Hi!
This message is for all of you that say "it doesn't work".
My solution at #59 works for my particular case.
If it doesn't work for yours, please, give us information about your problem.
With more detailed information we can get an almost optimal solution.

Thank you.

@Gapa, have tried your patch in #30 and it fixes part of it, but am still having some troubles;

My setup:

• Drupal (6.22) + Ubercart (6.x-2.7) + UC Vat (6.x-1.2) + UC Discounts Alt (6.x-2.4)
• Products are added with sell prices exclusive of VAT
• 6.75 Flat rate shipping rate added exclusive of VAT
• VAT rate is 19%
• On admin/store/settings/taxes/1/edit 'discount' unchecked
• On admin/store/settings/taxes/vat only checked 'Allow per line-item tax adjustments' and 'Use shipping line item settings from the tax rate configuration pages'
• On admin/store/uc_discounts/add created a discount of 50% on product class with min qualifying amount of 1 item

First I had some troubles with incorrect VAT calculations, possibly due to change in Ubercart 6.x-2.6, this was solved here http://drupal.org/node/1170992#comment-5536898

Then I noticed that discounts on both cart and checkout page were calculated based on sell price exclusive of VAT. Tried many things mentioned in this and other issues and many different settings but nothing worked.

/cart/checkout before patch:

I have applied #30 by hand to UC Discounts Alt (6.x-2.4) and since then the discounts are correctly calculated after VAT has been applied. Yet the patch causes the subtotal exclusive of VAT and the VAT line to be incorrect. Seems like they don't know about the discounted prices.

So partially there but no complete fix. Tried manually applying patches in #59 but they are based on the dev release from sept 2009 I believe so that's not really working out well.

Back to square one? Can't believe there isn't a live webshop out there that doesn't have uc_vat and uc_discount_alt combined which is working... can anyone who's got this working share a bit more info?!

Cheers