This patch makes the previous, up and next arrows look more sophisticated in the Pushbutton template. Includes new arrow images and adjusted positioning in stylesheet patch.

CommentFileSizeAuthor
#10 arrows_1.zip5.11 KBrobert castelo
#9 arrows_0.zip4.58 KBrobert castelo
#7 arrows.zip3.69 KBrobert castelo
pushbutton-prev-up-next.zip2.6 KBrobert castelo

Comments

jonbob’s picture

jonbob commented
Category: bug » feature

Not a bug, and should be set to "patch."

TDobes’s picture

TDobes commented

Could you provide some PNG versions, please? Other than that, I like this style of arrow better, so +1.

Steven’s picture

Steven commented

Applied pngcrush'ed versions to CVS.

robert castelo’s picture

robert castelo commented

Many thanks Steven, one less thing on my to do list!

(My ADSL line cut out after a thunderstorm on Tuesday, so I'm stuck on dial-up. Everything takes forever to do this week....)

robert castelo’s picture

robert castelo commented

Many thanks Steven, one less thing on my to do list!

(My ADSL line cut out after a thunderstorm on Tuesday, so I'm stuck on dial-up. Everything takes forever to do this week....)

Anonymous’s picture

(not verified) commented
robert castelo’s picture

robert castelo commented
StatusFileSize
new arrows.zip3.69 KB

Somehow Pushbutton slipped back to using the old arrows!

Attached is a patch which restores the new arrows.

It also adds CSS for the 'visited' link state, fixing a bug where the arrow would disapear on visted links.

Visited state arrows are also included, to match the colour of the links.

robert castelo’s picture

robert castelo commented

Example here:

http://www.cortexttranslation.com/culture

You will have to move around on the book a bit to see the 'visited' links ;-)

robert castelo’s picture

robert castelo commented
StatusFileSize
new arrows_0.zip4.58 KB

This patch contains code and all necessary images (sorry - forgot to include replacement arrows in preveious post).

robert castelo’s picture

robert castelo commented
StatusFileSize
new arrows_1.zip5.11 KB

Doh!

OK, this time with the images as png instead of gif.

This patch contains all neccessary files.

Steven’s picture

Steven commented

Applied to CVS, after pngcrush'ing them (strip-out gamma information to avoid png gamma browser inconsistencies).

Steven’s picture

Steven commented

By the way, you should consider using CSS sprites for these arrows: you put all states in the same file stacked vertically (with some space in between), and use background-position: 0px -20px; or something to switch to another sprite.

This avoids the problem where the alternate state arrows are only loaded when you hover over them (resulting in a short time without arrow). I've used it on several sites already, it works marvelous except for one bug. In Safari/Konqueror the background is sometimes repeated even if no-repeat is set. To avoid problems, just add some extra padding at the bottom (if you stack vertically).

I use this trick for the tabs in bluebeach:
http://www.drupal.org/themes/bluebeach/main-tab1.png

robert castelo’s picture

robert castelo commented

Thanks.

I saw that on A List Apart, it's a clever solution, which I've been meaning to explore ;-)

Anonymous’s picture

(not verified) commented