This is a meta-bug to regroup all the bugs and tasks that need to be done to have decisions 5.x-ready.

Right now our status is: not functional.

Bugs:

  • #83040 - uninstall hook
  • #92107 - can't create decision (fixed)
  • #83100 - update node info (fixed)
  • #92126 - voting forms do not display
CommentFileSizeAuthor
#3 decisions_5.patch20.13 KBDavid Lesieur
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anarcat’s picture

DRUPAL-5 branch created: not yet, development happens on CVS HEAD. The plan is now to make the HEAD work on 5.x and create the branch when it is working properly.

anarcat’s picture

Useful resources:

David Lesieur’s picture

Status: Active » Needs work
FileSize
20.13 KB

Here's a patch, but it is still a work-in-progress. I did not try to fully fix the ranking mode yet; I think it is best to make the poll mode work first. ;-)

At least now (for poll mode) we get the voting form and the votes are recorded in the database. But results are not displayed, and there are certainly lots of bugs because it is mostly untested at this point.

anarcat’s picture

Priority: Normal » Critical

I think we should focus on this issue to make sure we work with the current CVS.

The patch is kinda big and I would like to see it trimmed and filed in seperate issues... I would be very afraid if this whole patch would go in one shot in the CVS.

anarcat’s picture

Note that this patch doesn't apply cleanly on CVS anymore:

patching file decisions.module
Hunk #1 FAILED at 12.
Hunk #4 FAILED at 180.
Hunk #5 succeeded at 682 (offset 28 lines).
Hunk #6 succeeded at 718 (offset 28 lines).
Hunk #7 FAILED at 732.
Hunk #8 succeeded at 768 (offset 33 lines).
Hunk #9 succeeded at 795 (offset 33 lines).
Hunk #10 succeeded at 811 (offset 33 lines).
Hunk #11 succeeded at 870 (offset 33 lines).
Hunk #12 succeeded at 904 (offset 33 lines).
3 out of 12 hunks FAILED -- saving rejects to file decisions.module.rej

anarcat’s picture

Ok, now with the last commit (#44398), everything I tested on 5.x and that is listed in this bug report *works*. So we now have basic functionality. Things like blocks and other are not likely to be working, however, so this is not yet complete.

anarcat’s picture

Status: Needs work » Active

I've updated our status on the forum post.

I think we should keep this issue active until all functionalities work, esp. blocks, which I think are broken right now.

anarcat’s picture

Assigned: Unassigned » anarcat
Status: Active » Fixed

With the fix on the poll mode, things are now running smoothly on 5.x, including blocks, so I'm closing this.

Anonymous’s picture

Status: Fixed » Closed (fixed)