[D7] Themage

Link to the project page and git clone command are missing in the issue summary, please add them.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Its my first review so pardon me if its wrong.Here are some points
1-Info files doesnot have regions define in it if some one have to make new region in it i think so problem will come.
2-On 320x480 your pager layout brokes.Either its drupal system pager or views pager.
Thanks

Hi,

You should define regions in your info file. Now, if I want to add another region, I will have to define all the default ones too. Otherwise they will not appear.

Cheers.

I love that you're building with accessibility in mind! Thank you for that.
One thing - the skip link in your beautiful theme doesn't have an href, so you're relying on JS. Which functionally is probably fine, but it's better to include the href, too. You can use the WebAim toolbar for Firefox to check for things like this.
http://wave.webaim.org/toolbar/
Other than that, it looks super!

~R~

2-On 320x480 your pager layout brokes.Either its drupal system pager or views pager

I can confirm that its working fine now.
+1 for this theme.

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/template.php
  --------------------------------------------------------------------------------
  FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   16 | ERROR | Inline comments must end in full-stops, exclamation marks, or
      |       | question marks
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. block.tpl.php: the aside tag might not be appropriate for the general block? A block can be in the header, footer, main content area etc. Better override the block template for the specific sidebar regions?

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to cubeinspire as he might have time to take a final look at this.

Trying to remove tag again.

no objections for more than a week, so ...

Thanks for your contribution, pplantinga!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.