'Acta HTML5' is extended and improve version of 'Acta' theme(Currently available Drupal 5 only) in term of features and design. While porting same idea into Drupal 7 theme, I prefer develop it with my own coding style with latest bleeding edge technology of HTML5 and CSS3. So I prefer new project and new name as 'Acta HTML5'.

'Acta HTML5' is a two column fixed design (optimized for width 960px).

Implement new advance cutting edge technology of HTML5 and CSS3.
Minimum use of images in theme design. So it's become more light weight and execute fast then Drupal 5 version.

Project Page :
================
https://drupal.org/sandbox/itapplication/1877502

Link of the repository :
================
git clone http://git.drupal.org/sandbox/itapplication/1877502.git acta_html5

Version : Drupal 7
================

Reviews of other projects:
================
https://drupal.org/node/2023203#comment-7562365
https://drupal.org/node/1989736#comment-7567773
https://drupal.org/node/1986548#comment-7567873
https://drupal.org/node/2024875#comment-7570091

================
Automated project review from ventral.org/pareview
http://ventral.org/pareview/httpgitdrupalorgsandboxitapplication1877502git

================
You can also find live theme at -
http://www.acta.itapplication.net/

Only local images are allowed.

CommentFileSizeAuthor
#9 camparisan_d5-d7.jpg109.58 KBitapplication
#4 acta.png136.91 KBalinouman
Acta HTMl5.png117.67 KBitapplication

Comments

itapplication’s picture

itapplication commented
Issue summary: View changes

Update for project link.

itapplication’s picture

itapplication commented
Issue summary: View changes

Addition of image.

itapplication’s picture

itapplication commented
Issue summary: View changes

Minor changes.

itapplication’s picture

itapplication commented
Status: Active » Needs review

To change status from active to need review.

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

PA robot commented
Issue summary: View changes

Minor changes.

itapplication’s picture

itapplication commented
Issue summary: View changes

Reviews of other projects

itapplication’s picture

itapplication commented
Issue summary: View changes

Automated project review

itapplication’s picture

itapplication commented

Hi,

As per above guideline I review other project and contribute Drupal community by reviewing other projects/code.

Reviews of other projects:
================

alinouman’s picture

alinouman commented
Issue tags: -#theme +PAreview: review bonus
StatusFileSize
new acta.png136.91 KB

I am getting following notice when i m on homepage.

Notice: Undefined variable: acta_postfooter in include() (line 78 of /var/www/drupal/sites/all/themes/acta_html5/node.tpl.php).

Going to line 78,That code looks strange to me what does it do 

 <?php if ($page != 0): ?>
      <?php if ($submitted): ?>
          <?php  print $acta_postfooter; ?>
      <?php endif; ?>
    <?php endif; ?>
itapplication’s picture

itapplication commented

Hi alinouman,

Thanks for taking the time to review my Theme.
I have now fixed the issues of node.tpl.php. Please review the theme again and provide me your valuable feedback.

Thanks.
itapplication.
(Shiv.)

itapplication’s picture

itapplication commented
Issue summary: View changes

Some minor changes

Ujval Shah’s picture

Ujval Shah commented
Status: Needs review » Needs work

Hi,

Manual/Code Review :

(1) .info file un-used regions mentioned :

regions[page_top] = Page top
regions[page_bottom] = Page bottom

they are in No use at page.tpl.php, please remove them from .info file.

(2) user-name and password text-boxes are not identifiable when login block is enabled in the right-side. because border is set as none and background of block and text-box are same.

#sidebar #edit-pass, #sidebar #edit-name, #sidebar #edit-name--2
border is defined as none;

I would recommend to provide some border on text-box, that will be easier for a user to identify the text-box.

Thanks,
Ujval

itapplication’s picture

itapplication commented
Status: Needs work » Needs review

Hi Ujval,

Thanks for taking your valuable time to review my Theme. I fix Login block's issue of user-name and password text-boxes.

In Drupal 7 regions[page_top], regions[page_bottom] are mandatory regions which are hidden. Those two region replace Drupal 6's $closure. These regions are not use in page.tpl.php but use in html.tpl.php which I was missing and added it now.

Thanks.

itapplication’s picture

itapplication commented
Issue summary: View changes

Addition for review link

itapplication’s picture

itapplication commented
Issue summary: View changes

Add reference of developer of Drupal 5 version

itapplication’s picture

itapplication commented
Issue summary: View changes

minor changes

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Postponed (maintainer needs more info)

This sounds like a feature that should live in the existing acta project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the acta issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

itapplication’s picture

itapplication commented
Issue summary: View changes

minor changes into description.

itapplication’s picture

itapplication commented
Priority: Normal » Major
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new camparisan_d5-d7.jpg109.58 KB

Hi Klaus ,

Thanks for your review and suggestions.
I already ask for maintainer role for 'Acta' project to project creator/owner and I get maintainer role . As we can see in 'Acta' project original developer develop Drupal 5 theme only and no interest to extend project for next versions of theme. As I get maintainer role for 'Acta' project I am planing to develop Drupal 7 version of same theme without any changes.

In my 'Acta HTML5' I extend theme with some new features; I also develop theme with new CSS3 code. Differences of both theme/project are mention in below -

  • Different style sheet. In this style sheet I use CSS3 code instead of images to get effect of round corner, shadow and boxes
  • Including page.tpl.php almost all files code are different
  • New regions. I created three new regions 'Highlighted', 'Help' and 'Header'.
  • I also decided to extend the design to make it more fresh and new.
  • As a 'Acta' name suggest feel of sea beach, I created footer design as a sandy beach. And this jaint step keep huge distance between both theme.
  • Minimum use of images. In 'Acta HTML5' I use minimum images and use css3 code instead of images. Which help theme to become light weight.

Some webmaster prefer to upgrade there site in terms of features and code only they prefer to keep similar look and feel for there site for those people I plane to develop Drupal 7 version as maintainer of 'Acta'. but at the same time I also want to offer extended design, features and code as a separate project. I want to offer Drupal community two option for a similar idea/subject. So I think it is not competition rather than it is new, improve, fresh and extended version of old idea.

I hope I explain well, why it should be separate project. I invest several hours to develop theme to contribute it to Drupal community. I trust in your fine judgement and review. I am sure you will support me and encourage me to work actively, energetically for Drupal community and allow me to create full projects.

I also attached screenshot of both theme.

Best Regards,
Shiv.(itapplication)
Comparison

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Assigned: Unassigned » stborchert
Priority: Major » Normal
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus

Fair enough, I just thought it does not make sense to port the original version of the theme without using HTML5 and CSS3 anyway.

Review of the 7.x-1.x branch:

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
FILE: /home/klausi/pareview_temp/html.tpl.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
  3 | ERROR | Missing file doc comment
 15 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

  • "theme_get_setting('acta_mission')": that setting is not defined? Did you mean acta_html5_mission, which is also upper cased wrong in acta_html5_form_system_theme_settings_alter()?

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to stBorchert as he might have time to take a final look at this.

itapplication’s picture

itapplication commented

Hi,

Thanks for your valuable review and support.
I fix both bugs.
Here is the link for Automated Project Review from ventral.org http://ventral.org/pareview/httpgitdrupalorgsandboxitapplication1877502git

I hope you will support and encourage me to work actively, energetically for Drupal community and allow me to create full projects.

Best Regards,
Shiv.(itapplication)

itapplication’s picture

itapplication commented
Priority: Normal » Major
Issue tags: +PAreview: review bonus

Hi,

I eagerly waiting for next action.
I also keep working to contribute my favorite Drupal by review other project applications.

Here are my some other reviews -

I also add tag PAReview: review bonus tag again, hop this will make process faster.

I am waiting for to dive in Drupal organization to contribute my efforts to making it more better and better destination for 'Open Source' community.

itapplication’s picture

itapplication commented
Priority: Major » Normal

Sorry for so much excited. I make priority normal to major. I realize that it is not right. I should wait with patience. Changing it again as normal.

stborchert’s picture

stborchert
he/him
Primary language German
commented

This may be a dumb question but where exactly did you use HTML5? I expected to see at least <article>, <header> and <footer> in node.tpl.php ...

itapplication’s picture

itapplication commented

Hi Stefan,

Thanks for you review and suggestion. I just focused on CSS3 and forgot to use HTML5. Thanks again for your guidance. I update node.tpl.php file with HTML5 code.
Your support encourage me to work actively and energetically for Drupal community.

Best Regards,
Shiv.

Ujval Shah’s picture

Ujval Shah commented

@itapplication,

I appreciate your contribution.

Generally Naming conventions and technical vocabulary means lot in our IT Industry.

If you are not planning to add the HTML-5 support then I would suggest that you may remove HTML-5 from the title/name because that will mis-lead people since there is no usage of HTML-5.

Or you may add HTML-5 support as "up-coming" feature.

This is my suggestion only, decision will be yours only !!

itapplication’s picture

itapplication commented

@Ujval Shah,
Thanks for your suggestion. I use HTML5 code as per Stefan's suggestion. node.tpl.php file is updated with HTML5 code.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

no other objections for more than a week, so ...

Thanks for your contribution, itapplication!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

itapplication’s picture

itapplication commented

Hi klausi,

Thanks for your support and encouragement to work actively and energetically for Drupal community. As per your suggestion I also become member of group of "Code Review of Full Project Applications".

Thanks.
Shivcharan (Shiv)
itapplication.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Changing approach. Offering new options with new features rather than competition.