[D7] Field Group Colorbox

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxbrockfanning2124897git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi
Your git repo is asking for password. Please check.

Excellent idea for a module! I am still seeing errors in the pareview regarding line endings and such: http://pareview.sh/pareview/httpgitdrupalorgsandboxbrockfanning2124897git

Also, the project page could use screenshots and the links in the right-hand side (documentation, etc.) although your README/page instructions are very clear so maybe not. See here if it helps: https://drupal.org/node/997024

In terms of manually checking, the module worked exactly as expected with no errors in the log or in javascript. Great work!

pareview checked out and the project page looks great to me. Good work!

in function field_group_colorbox_field_group_format_settings, the description test is not been passed thru t(). Its good if you can fix this.

This is not a blocker for Project application, its good to RTBC.

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/field_group_colorbox.module
  --------------------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  --------------------------------------------------------------------------------
   287 | ERROR | Doc comment short description must be on a single line, further
       |       | text should be a separate paragraph
  --------------------------------------------------------------------------------
  
  FILE: /home/klausi/pareview_temp/field_group_colorbox.install
  --------------------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  --------------------------------------------------------------------------------
   4 | ERROR | Doc comment short description must end with a full stop
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

• field_group_colorbox_init(): why do you need hook_init()? You should only add your CSS when it is actually needed and such a field group is displayed? Whenever you invoke your theme functions, for example in field_group_colorbox_field_group_pre_render() maybe?

But otherwise looks good to me, so ...

Thanks for your contribution, brockfanning!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.