[D7] Anonymous Date Reminder

Installed and tested on fresh Drupal 7, everything ran as expected. Automated tests picked up some problems with legacy code from Date Reminder I fixed and committed. Automated tests are now clear.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

fixing clone link

I agree with your logic around the need for a new project as opposed to trying to build this into the Date Reminder module. Although perhaps the modules could perhaps eventually be integrated.

After running the module through Coder, it appears that a space should likely be added within the array on line 236 of anon_datereminder.admin.inc:

'#token_types' => array('anon_datereminder','node'),

If you remove that space it will eliminate the error generated by the Coder module.

Also note that on line 73 of mailer.inc, you should include enclose within a t() so that it is translatable by the [i18n_8] module:

drupal_set_message('email is required', 'error');

Line 73: The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable. [i18n_8]
drupal_set_message('email is required', 'error');

I also suggest revising your ReadMe documentation slightly by expanding on the installation process and confirming that Date and Token are required modules.

Did you see the other issue that arises when you run you module through the Code module? I'm wondering if perhaps there's a way to code this differently so that it doesn't raise a warning.

anon_datereminder.module

severity: normalreview: style_function_spacingLine 487: Functions should be called with no spaces between the function name and opening parentheses [style_function_spacing]
  $countemails = array_filter($reminders, function($reminder) use ($email) {

Also note that on line 299 & 300 the spacing/tabs need to be adjusted based on the report from the Coder module:

Line 299: Use an indent of 2 spaces, with no tabs [style_indent_spaces]
   && ($en != ANON_DATEREMINDER_TYPE_ON)
severity: minorreview: style_indent_spacesLine 300: Use an indent of 2 spaces, with no tabs [style_indent_spaces]
   && ($en != ANON_DATEREMINDER_TYPE_RETAIN)) {

Hello, I found small coder issues in the latest version of code:

anon_datereminder_form.inc

severity: normalLine 257: Comments containing code should be removed for releases. [production_code]
    // date_timezone_set($dobj, $tz);

this one should be fixed.

There is also following two

anon_datereminder.module

severity: normalreview: style_function_spacingLine 523: Functions should be called with no spaces between the function name and opening parentheses [style_function_spacing]
  $countemails = array_filter($reminders, function($reminder) use ($email) {

db7.inc

severity: normalLine 149: Comments containing code should be removed for releases. [production_code]
 *   $reminders = _anon_datereminder_load_reminders(array('uid' => $uid));

but these are probably cause be strange syntax of anonymous function, and not recognized example tag.

And also I would prefer to have all hooks in module file to be on the top of file, and the custom functions on the bottom.
Otherwise it looks fine.

Sorry, for mistake.

Changing status.

coder highlighting callback function note

This is really minor but could you please put the full git clone command into your issue summary? I didn't know the name of your module so when I git cloned it I had to figure it out. It just makes the project two steps easier to review. Thanks!
git clone http://git.drupal.org/sandbox/uniwales/2100301.git anon_datereminder
A direct link to your pareview.sh results would also help:
http://pareview.sh/pareview/httpgitdrupalorgsandboxuniwales2100301git

Your README.txt is well written and easy to follow. Good work.
You use constants far more than I typically see in Drupal modules. I don't see anything wrong with that but it sure sticks out!

It seems that you could reduce the size of your .module file even more by moving some of the functions out. I'm thinking of some of those internal functions.

Has this been tested with sites using MIMEmail and other such modules? That's quite common.

The code is readable and seems logical. The documentation is logical and easy to understand.

Good work!

Candotri

please don't RTBC your own issues, see the project application workflow: https://drupal.org/node/532400

great work.
There are only two small problems
1. Your GIT file tree should not contain .DS_Store file http://drupalcode.org/sandbox/uniwales/2100301.git/tree
2. Why is two % in Hook_uninstall http://drupalcode.org/sandbox/uniwales/2100301.git/blob/HEAD:/anon_dater...

->condition('name', 'anon_datereminder%%', 'LIKE')),

Nice Idea and Great Work. When this work will be available as a module for use?

Thanks,
Senthil

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Review of the 7.x-1.x branch:

• Remove all .DS_Store files from your repository.
• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: /home/klausi/pareview_temp/includes/anon_datereminder_form.inc
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   43 | WARNING | The extra check_plain() is not necessary for placeholders, "@"
      |         | and "%" will automatically run check_plain()
  --------------------------------------------------------------------------------
  

• Codespell has found some spelling errors in your code.
  

  ./anon_datereminder.module:10: occurance  ==> occurrence
  ./anon_datereminder.module:589: occurrance  ==> occurrence
  ./anon_datereminder.module:636: occurrance  ==> occurrence
  ./anon_datereminder.module:640: occurrance  ==> occurrence
  ./anon_datereminder.module:644: occurrance  ==> occurrence
  ./anon_datereminder.admin.inc:8: adminstrative  ==> administrative
  ./anon_datereminder.admin.inc:46: occurence  ==> occurrence
  ./includes/node.inc:61: occurance  ==> occurrence
  ./includes/node.inc:63: occurance  ==> occurrence
  ./includes/date.inc:89: occurance  ==> occurrence
  ./includes/date.inc:97: occurance  ==> occurrence
  ./includes/date.inc:107: occurance  ==> occurrence
  ./includes/date.inc:115: occurance  ==> occurrence
  ./includes/cron.inc:12: occurrance  ==> occurrence
  ./includes/anon_datereminder_form.inc:421: occurrances  ==> occurrences
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. anon_datereminder_menu(): why do you need the module_load_include() call for the admin.inc file here? You are noit calling a function from the file here?
2. anon_datereminder_allowed_access_node(): global $user will always be set, so that if clause has no effect.
3. anon_datereminder_nodeapi(): hook_nodeapi() does not exist in Drupal 7, so this function should be removed.
4. anon_datereminder_node_type(): hook_node_type() does not exist in D7, so this function should be removed as well.
5. "@param reminder $r": "reminder" is not a valid data type, see https://drupal.org/node/1354#types
6. anon_datereminder_perm(): Again Drupal 6 code that should be removed. I have the feeling that you are mixing a D6 module and a D7 module here, which is a bad idea. This can lead to subtle bugs and the code is harder to understand for contributors. You should create a dedicated 6.x-1.x branch with D6 code only to keep that clearly separated.
7. _anon_datereminder_get_node_enabled(): Do not use db_select() for simple static queries, use db_query() instead. See http://drupal.org/node/310075 . Also elsewhere.

Those are not critical application blockers, otherwise I would say this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to MiSc as he might have time to take a final look at this.

After cleanup this is ready to go, as far as I can see.

When this would be available as a module ? Looking forward at an early date.
Thanks

no objections for more than a week, so ...

Thanks for your contribution, batdesign!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Thanks batdesign for your good work on this module. I really appreciate this.

Thanks also to klausi for his untiring effort on the review process. People like you are an asset to the Open Source Community.

I am not a technical / Development resource and your dedication makes me to inspire and regret my inability to code or doing a code review. However, I can help in testing the functionality.

Klausi's guide on the review process will inspire many others.. I am sure.

Thanks again

Since I got no answer on the forum I try to reach somebody here.
I can install date reminder and it works on my sie. I de-install Date Reminder and install Anonymous Date Reminder. I see no errors, but The fields don't show. I emptied the cache several times, tried a block, no result.
What am I doing wrong?